[PATCH] xen/vtd: cleanup some comments

[PATCH] xen/vtd: cleanup some comments

[Tiejun Chen]

In some cases Dom0 and hardware domain are not one same domain.

Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
 xen/drivers/passthrough/vtd/iommu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 00f72cb..73165dc 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
 
     if ( !iommu_passthrough && !need_iommu(d) )
     {
-        /* Set up 1:1 page table for dom0 */
+        /* Set up 1:1 page table for hardware domain */
         vtd_set_hwdom_mapping(d);
     }
 
@@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
     if ( iommu_use_hap_pt(d) )
         return 0;
 
-    /* do nothing if dom0 and iommu supports pass thru */
+    /* do nothing if hardware domain and iommu supports pass thru */
     if ( iommu_passthrough && is_hardware_domain(d) )
         return 0;
 
@@ -1740,7 +1740,7 @@ static int intel_iommu_map_page(
 
 static int intel_iommu_unmap_page(struct domain *d, unsigned long gfn)
 {
-    /* Do nothing if dom0 and iommu supports pass thru. */
+    /* Do nothing if hardware domain and iommu supports pass thru. */
     if ( iommu_passthrough && is_hardware_domain(d) )
         return 0;
 
-- 
1.9.1

Re: [PATCH] xen/vtd: cleanup some comments

[Jan Beulich]

>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
>  
>      if ( !iommu_passthrough && !need_iommu(d) )
>      {
> -        /* Set up 1:1 page table for dom0 */
> +        /* Set up 1:1 page table for hardware domain */
>          vtd_set_hwdom_mapping(d);
>      }
>  
> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
>      if ( iommu_use_hap_pt(d) )
>          return 0;
>  
> -    /* do nothing if dom0 and iommu supports pass thru */
> +    /* do nothing if hardware domain and iommu supports pass thru */

If you clean up comments, please make them match ./CODING_STYLE.

Jan

Re: [PATCH] xen/vtd: cleanup some comments

[Chen, Tiejun]

On 2014/10/24 18:33, Jan Beulich wrote:
>>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
>>
>>       if ( !iommu_passthrough && !need_iommu(d) )
>>       {
>> -        /* Set up 1:1 page table for dom0 */
>> +        /* Set up 1:1 page table for hardware domain */
>>           vtd_set_hwdom_mapping(d);
>>       }
>>
>> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
>>       if ( iommu_use_hap_pt(d) )
>>           return 0;
>>
>> -    /* do nothing if dom0 and iommu supports pass thru */
>> +    /* do nothing if hardware domain and iommu supports pass thru */
>
> If you clean up comments, please make them match ./CODING_STYLE.

Sorry, could you say this explicitly?

 From my point of view, this is just one line and this line is already 
less than 80 characters in length. Or just add a period at the end of 
the sentence?

Thanks
Tiejun

Re: [PATCH] xen/vtd: cleanup some comments

[Jan Beulich]

>>> On 27.10.14 at 02:33, <tiejun.chen@intel.com> wrote:
> On 2014/10/24 18:33, Jan Beulich wrote:
>>>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
>>> --- a/xen/drivers/passthrough/vtd/iommu.c
>>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>>> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct 
> domain *d)
>>>
>>>       if ( !iommu_passthrough && !need_iommu(d) )
>>>       {
>>> -        /* Set up 1:1 page table for dom0 */
>>> +        /* Set up 1:1 page table for hardware domain */
>>>           vtd_set_hwdom_mapping(d);
>>>       }
>>>
>>> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
>>>       if ( iommu_use_hap_pt(d) )
>>>           return 0;
>>>
>>> -    /* do nothing if dom0 and iommu supports pass thru */
>>> +    /* do nothing if hardware domain and iommu supports pass thru */
>>
>> If you clean up comments, please make them match ./CODING_STYLE.
> 
> Sorry, could you say this explicitly?
> 
>  From my point of view, this is just one line and this line is already 
> less than 80 characters in length. Or just add a period at the end of 
> the sentence?

Right (plus, in the second quoted case, upper case the first
character).

Jan