* [PATCH] xen/vtd: cleanup some comments
@ 2014-10-24 2:50 Tiejun Chen
2014-10-24 10:33 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Tiejun Chen @ 2014-10-24 2:50 UTC (permalink / raw)
To: yang.z.zhang, kevin.tian; +Cc: xen-devel
In some cases Dom0 and hardware domain are not one same domain.
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
xen/drivers/passthrough/vtd/iommu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 00f72cb..73165dc 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
if ( !iommu_passthrough && !need_iommu(d) )
{
- /* Set up 1:1 page table for dom0 */
+ /* Set up 1:1 page table for hardware domain */
vtd_set_hwdom_mapping(d);
}
@@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
if ( iommu_use_hap_pt(d) )
return 0;
- /* do nothing if dom0 and iommu supports pass thru */
+ /* do nothing if hardware domain and iommu supports pass thru */
if ( iommu_passthrough && is_hardware_domain(d) )
return 0;
@@ -1740,7 +1740,7 @@ static int intel_iommu_map_page(
static int intel_iommu_unmap_page(struct domain *d, unsigned long gfn)
{
- /* Do nothing if dom0 and iommu supports pass thru. */
+ /* Do nothing if hardware domain and iommu supports pass thru. */
if ( iommu_passthrough && is_hardware_domain(d) )
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/vtd: cleanup some comments
2014-10-24 2:50 [PATCH] xen/vtd: cleanup some comments Tiejun Chen
@ 2014-10-24 10:33 ` Jan Beulich
2014-10-27 1:33 ` Chen, Tiejun
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2014-10-24 10:33 UTC (permalink / raw)
To: Tiejun Chen; +Cc: yang.z.zhang, kevin.tian, xen-devel
>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
>
> if ( !iommu_passthrough && !need_iommu(d) )
> {
> - /* Set up 1:1 page table for dom0 */
> + /* Set up 1:1 page table for hardware domain */
> vtd_set_hwdom_mapping(d);
> }
>
> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
> if ( iommu_use_hap_pt(d) )
> return 0;
>
> - /* do nothing if dom0 and iommu supports pass thru */
> + /* do nothing if hardware domain and iommu supports pass thru */
If you clean up comments, please make them match ./CODING_STYLE.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/vtd: cleanup some comments
2014-10-24 10:33 ` Jan Beulich
@ 2014-10-27 1:33 ` Chen, Tiejun
2014-10-27 9:19 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Chen, Tiejun @ 2014-10-27 1:33 UTC (permalink / raw)
To: Jan Beulich; +Cc: yang.z.zhang, kevin.tian, xen-devel
On 2014/10/24 18:33, Jan Beulich wrote:
>>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
>>
>> if ( !iommu_passthrough && !need_iommu(d) )
>> {
>> - /* Set up 1:1 page table for dom0 */
>> + /* Set up 1:1 page table for hardware domain */
>> vtd_set_hwdom_mapping(d);
>> }
>>
>> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
>> if ( iommu_use_hap_pt(d) )
>> return 0;
>>
>> - /* do nothing if dom0 and iommu supports pass thru */
>> + /* do nothing if hardware domain and iommu supports pass thru */
>
> If you clean up comments, please make them match ./CODING_STYLE.
Sorry, could you say this explicitly?
From my point of view, this is just one line and this line is already
less than 80 characters in length. Or just add a period at the end of
the sentence?
Thanks
Tiejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/vtd: cleanup some comments
2014-10-27 1:33 ` Chen, Tiejun
@ 2014-10-27 9:19 ` Jan Beulich
0 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2014-10-27 9:19 UTC (permalink / raw)
To: Tiejun Chen; +Cc: yang.z.zhang, kevin.tian, xen-devel
>>> On 27.10.14 at 02:33, <tiejun.chen@intel.com> wrote:
> On 2014/10/24 18:33, Jan Beulich wrote:
>>>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
>>> --- a/xen/drivers/passthrough/vtd/iommu.c
>>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>>> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct
> domain *d)
>>>
>>> if ( !iommu_passthrough && !need_iommu(d) )
>>> {
>>> - /* Set up 1:1 page table for dom0 */
>>> + /* Set up 1:1 page table for hardware domain */
>>> vtd_set_hwdom_mapping(d);
>>> }
>>>
>>> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
>>> if ( iommu_use_hap_pt(d) )
>>> return 0;
>>>
>>> - /* do nothing if dom0 and iommu supports pass thru */
>>> + /* do nothing if hardware domain and iommu supports pass thru */
>>
>> If you clean up comments, please make them match ./CODING_STYLE.
>
> Sorry, could you say this explicitly?
>
> From my point of view, this is just one line and this line is already
> less than 80 characters in length. Or just add a period at the end of
> the sentence?
Right (plus, in the second quoted case, upper case the first
character).
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-27 9:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-24 2:50 [PATCH] xen/vtd: cleanup some comments Tiejun Chen
2014-10-24 10:33 ` Jan Beulich
2014-10-27 1:33 ` Chen, Tiejun
2014-10-27 9:19 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.