All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support
Date: Wed, 05 Nov 2014 16:10:34 +0000	[thread overview]
Message-ID: <545A4BFA.30704@redhat.com> (raw)
In-Reply-To: <1414017251-5772-2-git-send-email-m.smarduch@samsung.com>



On 23/10/2014 00:34, Mario Smarduch wrote:
> This patch adds support for architecture implemented VM TLB flush, currently
> ARMv7 defines HAVE_KVM_ARCH_TLB_FLUSH_ALL. This leaves other architectures 
> unaffected using the generic version. In subsequent patch ARMv7 defines
> HAVE_KVM_ARCH_TLB_FLUSH_ALL and it's own TLB flush interface.
> 
> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
> ---
>  virt/kvm/Kconfig    |    3 +++
>  virt/kvm/kvm_main.c |    2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig
> index fc0c5e6..3796a21 100644
> --- a/virt/kvm/Kconfig
> +++ b/virt/kvm/Kconfig
> @@ -37,3 +37,6 @@ config HAVE_KVM_CPU_RELAX_INTERCEPT
>  
>  config KVM_VFIO
>         bool
> +
> +config HAVE_KVM_ARCH_TLB_FLUSH_ALL
> +       bool
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33712fb..887df87 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -184,6 +184,7 @@ static bool make_all_cpus_request(struct kvm *kvm, unsigned int req)
>  	return called;
>  }
>  
> +#ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL
>  void kvm_flush_remote_tlbs(struct kvm *kvm)
>  {
>  	long dirty_count = kvm->tlbs_dirty;
> @@ -194,6 +195,7 @@ void kvm_flush_remote_tlbs(struct kvm *kvm)
>  	cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
>  }
>  EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs);
> +#endif
>  
>  void kvm_reload_remote_mmus(struct kvm *kvm)
>  {
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mario Smarduch <m.smarduch@samsung.com>,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org,
	agraf@suse.de, catalin.marinas@arm.com, cornelia.huck@de.ibm.com,
	borntraeger@de.ibm.com, james.hogan@imgtec.com,
	marc.zyngier@arm.com, xiaoguangrong@linux.vnet.ibm.com
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	kvm-ia64@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	steve.capper@arm.com, peter.maydell@linaro.org
Subject: Re: [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support
Date: Wed, 05 Nov 2014 16:10:34 +0000	[thread overview]
Message-ID: <545A4BFA.30704@redhat.com> (raw)
In-Reply-To: <1414017251-5772-2-git-send-email-m.smarduch@samsung.com>



On 23/10/2014 00:34, Mario Smarduch wrote:
> This patch adds support for architecture implemented VM TLB flush, currently
> ARMv7 defines HAVE_KVM_ARCH_TLB_FLUSH_ALL. This leaves other architectures 
> unaffected using the generic version. In subsequent patch ARMv7 defines
> HAVE_KVM_ARCH_TLB_FLUSH_ALL and it's own TLB flush interface.
> 
> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
> ---
>  virt/kvm/Kconfig    |    3 +++
>  virt/kvm/kvm_main.c |    2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig
> index fc0c5e6..3796a21 100644
> --- a/virt/kvm/Kconfig
> +++ b/virt/kvm/Kconfig
> @@ -37,3 +37,6 @@ config HAVE_KVM_CPU_RELAX_INTERCEPT
>  
>  config KVM_VFIO
>         bool
> +
> +config HAVE_KVM_ARCH_TLB_FLUSH_ALL
> +       bool
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33712fb..887df87 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -184,6 +184,7 @@ static bool make_all_cpus_request(struct kvm *kvm, unsigned int req)
>  	return called;
>  }
>  
> +#ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL
>  void kvm_flush_remote_tlbs(struct kvm *kvm)
>  {
>  	long dirty_count = kvm->tlbs_dirty;
> @@ -194,6 +195,7 @@ void kvm_flush_remote_tlbs(struct kvm *kvm)
>  	cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
>  }
>  EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs);
> +#endif
>  
>  void kvm_reload_remote_mmus(struct kvm *kvm)
>  {
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support
Date: Wed, 05 Nov 2014 17:10:34 +0100	[thread overview]
Message-ID: <545A4BFA.30704@redhat.com> (raw)
In-Reply-To: <1414017251-5772-2-git-send-email-m.smarduch@samsung.com>



On 23/10/2014 00:34, Mario Smarduch wrote:
> This patch adds support for architecture implemented VM TLB flush, currently
> ARMv7 defines HAVE_KVM_ARCH_TLB_FLUSH_ALL. This leaves other architectures 
> unaffected using the generic version. In subsequent patch ARMv7 defines
> HAVE_KVM_ARCH_TLB_FLUSH_ALL and it's own TLB flush interface.
> 
> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
> ---
>  virt/kvm/Kconfig    |    3 +++
>  virt/kvm/kvm_main.c |    2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig
> index fc0c5e6..3796a21 100644
> --- a/virt/kvm/Kconfig
> +++ b/virt/kvm/Kconfig
> @@ -37,3 +37,6 @@ config HAVE_KVM_CPU_RELAX_INTERCEPT
>  
>  config KVM_VFIO
>         bool
> +
> +config HAVE_KVM_ARCH_TLB_FLUSH_ALL
> +       bool
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33712fb..887df87 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -184,6 +184,7 @@ static bool make_all_cpus_request(struct kvm *kvm, unsigned int req)
>  	return called;
>  }
>  
> +#ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL
>  void kvm_flush_remote_tlbs(struct kvm *kvm)
>  {
>  	long dirty_count = kvm->tlbs_dirty;
> @@ -194,6 +195,7 @@ void kvm_flush_remote_tlbs(struct kvm *kvm)
>  	cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
>  }
>  EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs);
> +#endif
>  
>  void kvm_reload_remote_mmus(struct kvm *kvm)
>  {
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mario Smarduch <m.smarduch@samsung.com>,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org,
	agraf@suse.de, catalin.marinas@arm.com, cornelia.huck@de.ibm.com,
	borntraeger@de.ibm.com, james.hogan@imgtec.com,
	marc.zyngier@arm.com, xiaoguangrong@linux.vnet.ibm.com
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	kvm-ia64@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	steve.capper@arm.com, peter.maydell@linaro.org
Subject: Re: [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support
Date: Wed, 05 Nov 2014 17:10:34 +0100	[thread overview]
Message-ID: <545A4BFA.30704@redhat.com> (raw)
In-Reply-To: <1414017251-5772-2-git-send-email-m.smarduch@samsung.com>



On 23/10/2014 00:34, Mario Smarduch wrote:
> This patch adds support for architecture implemented VM TLB flush, currently
> ARMv7 defines HAVE_KVM_ARCH_TLB_FLUSH_ALL. This leaves other architectures 
> unaffected using the generic version. In subsequent patch ARMv7 defines
> HAVE_KVM_ARCH_TLB_FLUSH_ALL and it's own TLB flush interface.
> 
> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
> ---
>  virt/kvm/Kconfig    |    3 +++
>  virt/kvm/kvm_main.c |    2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig
> index fc0c5e6..3796a21 100644
> --- a/virt/kvm/Kconfig
> +++ b/virt/kvm/Kconfig
> @@ -37,3 +37,6 @@ config HAVE_KVM_CPU_RELAX_INTERCEPT
>  
>  config KVM_VFIO
>         bool
> +
> +config HAVE_KVM_ARCH_TLB_FLUSH_ALL
> +       bool
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33712fb..887df87 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -184,6 +184,7 @@ static bool make_all_cpus_request(struct kvm *kvm, unsigned int req)
>  	return called;
>  }
>  
> +#ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL
>  void kvm_flush_remote_tlbs(struct kvm *kvm)
>  {
>  	long dirty_count = kvm->tlbs_dirty;
> @@ -194,6 +195,7 @@ void kvm_flush_remote_tlbs(struct kvm *kvm)
>  	cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
>  }
>  EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs);
> +#endif
>  
>  void kvm_reload_remote_mmus(struct kvm *kvm)
>  {
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

  parent reply	other threads:[~2014-11-05 16:10 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 22:34 [PATCH v12 1/6] KVM: Add architecture-defined TLB flush support Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-30 12:06 ` Cornelia Huck
2014-10-30 12:06   ` Cornelia Huck
2014-10-30 12:06   ` Cornelia Huck
2014-10-30 12:06   ` Cornelia Huck
2014-11-05 16:10 ` Paolo Bonzini [this message]
2014-11-05 16:10   ` Paolo Bonzini
2014-11-05 16:10   ` Paolo Bonzini
2014-11-05 16:10   ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2014-10-28 16:29 [PATCH v12 0/6] 2nd-request for review comments: arm/KVM: dirty page logging support for ARMv7 ( Mario Smarduch
2014-10-28 16:29 ` [PATCH v12 0/6] 2nd-request for review comments: arm/KVM: dirty page logging support for ARMv7 (3.17.0-rc1) Mario Smarduch
2014-10-28 16:29 ` Mario Smarduch
2014-10-28 16:29 ` [PATCH v12 0/6] 2nd-request for review comments: arm/KVM: dirty page logging support for ARMv7 ( Mario Smarduch
2014-10-22 22:34 [PATCH v12 4/6] arm: KVM: Add initial dirty page locking infrastructure Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 [PATCH v12 3/6] arm: KVM: Add ARMv7 API to flush TLBs Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 [PATCH v12 2/6] KVM: Add generic support for dirty page logging Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-30 12:14 ` Cornelia Huck
2014-10-30 12:14   ` Cornelia Huck
2014-10-30 12:14   ` Cornelia Huck
2014-10-30 12:14   ` Cornelia Huck
2014-10-30 19:19 ` Mario Smarduch
2014-10-30 19:19   ` Mario Smarduch
2014-10-30 19:19   ` Mario Smarduch
2014-10-30 19:19   ` Mario Smarduch
2014-11-01 10:12 ` James Hogan
2014-11-01 10:12   ` James Hogan
2014-11-01 10:12   ` James Hogan
2014-11-01 10:12   ` James Hogan
2014-11-03  3:01 ` Takuya Yoshikawa
2014-11-03  3:01   ` Takuya Yoshikawa
2014-11-03  3:01   ` Takuya Yoshikawa
2014-11-03  3:01   ` Takuya Yoshikawa
2014-11-03 18:44 ` Mario Smarduch
2014-11-03 18:44   ` Mario Smarduch
2014-11-03 18:44   ` Mario Smarduch
2014-11-03 18:44   ` Mario Smarduch
2014-11-03 19:34 ` Mario Smarduch
2014-11-03 19:34   ` Mario Smarduch
2014-11-03 19:34   ` Mario Smarduch
2014-11-03 19:34   ` Mario Smarduch
2014-11-05 16:09 ` Paolo Bonzini
2014-11-05 16:09   ` Paolo Bonzini
2014-11-05 16:09   ` Paolo Bonzini
2014-11-05 16:09   ` Paolo Bonzini
2014-11-05 23:05 ` Mario Smarduch
2014-11-05 23:05   ` Mario Smarduch
2014-11-05 23:05   ` Mario Smarduch
2014-11-05 23:05   ` Mario Smarduch
2014-11-06 10:14 ` Paolo Bonzini
2014-11-06 10:14   ` Paolo Bonzini
2014-11-06 10:14   ` Paolo Bonzini
2014-11-06 10:14   ` Paolo Bonzini
2014-11-06 18:07 ` Mario Smarduch
2014-11-06 18:07   ` Mario Smarduch
2014-11-06 18:07   ` Mario Smarduch
2014-11-06 18:07   ` Mario Smarduch
2014-10-22 22:34 [PATCH v12 0/6] arm/KVM: dirty page logging support for ARMv7 (3.17.0-rc1) Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-22 22:34 ` Mario Smarduch
2014-10-27 23:26 ` Wanpeng Li
2014-10-27 23:26   ` Wanpeng Li
2014-10-27 23:26   ` Wanpeng Li
2014-10-27 23:26   ` Wanpeng Li
2014-10-28  0:28 ` Mario Smarduch
2014-10-28  0:28   ` Mario Smarduch
2014-10-28  0:28   ` Mario Smarduch
2014-10-28  0:28   ` Mario Smarduch
2014-10-28  1:24 ` Wanpeng Li
2014-10-28  1:24   ` Wanpeng Li
2014-10-28  1:24   ` Wanpeng Li
2014-10-28  1:24   ` Wanpeng Li
2014-10-28 16:15 ` Mario Smarduch
2014-10-28 16:15   ` Mario Smarduch
2014-10-28 16:15   ` Mario Smarduch
2014-10-28 16:15   ` Mario Smarduch
2014-10-30 12:11 ` Christian Borntraeger
2014-10-30 12:11   ` Christian Borntraeger
2014-10-30 12:11   ` Christian Borntraeger
2014-10-30 12:11   ` Christian Borntraeger
2014-10-30 19:27 ` Mario Smarduch
2014-10-30 19:27   ` Mario Smarduch
2014-10-30 19:27   ` Mario Smarduch
2014-10-30 19:27   ` Mario Smarduch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545A4BFA.30704@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.