From: Jonathan Cameron <jic23@kernel.org>
To: Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Andrew Bresticker <abrestic@chromium.org>,
James Hartley <james.hartley@imgtec.com>,
Phani Movva <phani.movva@imgtec.com>
Cc: linux-iio@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
devicetree@vger.kernel.org,
Naidu Tellapati <Naidu.Tellapati@imgtec.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v2 2/3] DT: iio: adc: Add CC_10001 binding documentation
Date: Sat, 08 Nov 2014 12:59:01 +0000 [thread overview]
Message-ID: <545E1395.6040606@kernel.org> (raw)
In-Reply-To: <1415224611-22096-3-git-send-email-ezequiel.garcia@imgtec.com>
On 05/11/14 21:56, Ezequiel Garcia wrote:
> From: Phani Movva <Phani.Movva@imgtec.com>
>
> Add the devicetree binding document for Cosmic Circuits 10001 ADC device.
>
> Signed-off-by: Phani Movva <Phani.Movva@imgtec.com>
> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
> [Ezequiel: minor style cleaning]
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
I'm unobservant. You did cc'd the list for device tree - convention is to
also cc the listed maintainers.. (done on this reply).
> ---
> .../devicetree/bindings/iio/adc/cc_10001_adc.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt b/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
> new file mode 100644
> index 0000000..6491839
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
> @@ -0,0 +1,19 @@
> +* Cosmic Circuits - Analog to Digital Converter (CC-10001-ADC)
> +
> +Required properties:
> + - compatible: Should be "cosmic,10001-adc"
> + - reg: Should contain adc registers location and length.
> + - cosmic,adc-available-channels: Bitmask of the channels currently enabled.
> + - clock-names: Should contain "adc".
> + - clocks: phandles to input clocks.
> + - vref-supply: The regulator supply ADC reference voltage.
> +
> +Example:
> +adc: adc@18101600 {
> + compatible = "cosmic,10001-adc";
> + reg = <0x18101600 0x24>;
> + cosmic,adc-available-channels = <0xa>;
> + clocks = <&adc_clk>;
> + clock-names = "adc";
> + vref-supply = <®_1v8>;
> +};
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Ezequiel Garcia
<ezequiel.garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
James Hartley
<james.hartley-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
Phani Movva <phani.movva-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
knaack.h-Mmb7MZpHnFY@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Naidu Tellapati
<Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH v2 2/3] DT: iio: adc: Add CC_10001 binding documentation
Date: Sat, 08 Nov 2014 12:59:01 +0000 [thread overview]
Message-ID: <545E1395.6040606@kernel.org> (raw)
In-Reply-To: <1415224611-22096-3-git-send-email-ezequiel.garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
On 05/11/14 21:56, Ezequiel Garcia wrote:
> From: Phani Movva <Phani.Movva-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
>
> Add the devicetree binding document for Cosmic Circuits 10001 ADC device.
>
> Signed-off-by: Phani Movva <Phani.Movva-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Naidu Tellapati <Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
> [Ezequiel: minor style cleaning]
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
I'm unobservant. You did cc'd the list for device tree - convention is to
also cc the listed maintainers.. (done on this reply).
> ---
> .../devicetree/bindings/iio/adc/cc_10001_adc.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt b/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
> new file mode 100644
> index 0000000..6491839
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
> @@ -0,0 +1,19 @@
> +* Cosmic Circuits - Analog to Digital Converter (CC-10001-ADC)
> +
> +Required properties:
> + - compatible: Should be "cosmic,10001-adc"
> + - reg: Should contain adc registers location and length.
> + - cosmic,adc-available-channels: Bitmask of the channels currently enabled.
> + - clock-names: Should contain "adc".
> + - clocks: phandles to input clocks.
> + - vref-supply: The regulator supply ADC reference voltage.
> +
> +Example:
> +adc: adc@18101600 {
> + compatible = "cosmic,10001-adc";
> + reg = <0x18101600 0x24>;
> + cosmic,adc-available-channels = <0xa>;
> + clocks = <&adc_clk>;
> + clock-names = "adc";
> + vref-supply = <®_1v8>;
> +};
>
next prev parent reply other threads:[~2014-11-08 12:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 21:56 [PATCH v2 0/3] iio: Add Cosmic Circuits ADC support Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
2014-11-05 21:56 ` [PATCH v2 1/3] iio: adc: Cosmic Circuits 10001 ADC driver Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
2014-11-08 12:55 ` Jonathan Cameron
2014-11-08 12:55 ` Jonathan Cameron
2014-11-10 19:51 ` Ezequiel Garcia
2014-11-10 19:51 ` Ezequiel Garcia
2014-11-05 21:56 ` [PATCH v2 2/3] DT: iio: adc: Add CC_10001 binding documentation Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
2014-11-08 12:57 ` Jonathan Cameron
2014-11-08 12:57 ` Jonathan Cameron
2014-11-10 19:50 ` Ezequiel Garcia
2014-11-10 19:50 ` Ezequiel Garcia
2014-11-10 19:59 ` Ezequiel Garcia
2014-11-10 19:59 ` Ezequiel Garcia
2014-11-10 21:28 ` Andrew Bresticker
2014-11-10 21:28 ` Andrew Bresticker
2014-11-11 16:29 ` Ezequiel Garcia
2014-11-11 16:29 ` Ezequiel Garcia
2014-11-08 12:59 ` Jonathan Cameron [this message]
2014-11-08 12:59 ` Jonathan Cameron
2014-11-05 21:56 ` [PATCH v2 3/3] DT: Add a vendor prefix for Cosmic Circuits Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545E1395.6040606@kernel.org \
--to=jic23@kernel.org \
--cc=Mark.Rutland@arm.com \
--cc=Naidu.Tellapati@imgtec.com \
--cc=Pawel.Moll@arm.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@imgtec.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=james.hartley@imgtec.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=phani.movva@imgtec.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.