From: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andrew Bresticker <abrestic@chromium.org>,
James Hartley <james.hartley@imgtec.com>,
Phani Movva <phani.movva@imgtec.com>
Cc: <linux-iio@vger.kernel.org>, <pmeerw@pmeerw.net>,
<knaack.h@gmx.de>, <devicetree@vger.kernel.org>,
Naidu Tellapati <Naidu.Tellapati@imgtec.com>
Subject: Re: [PATCH v2 1/3] iio: adc: Cosmic Circuits 10001 ADC driver
Date: Mon, 10 Nov 2014 16:51:22 -0300 [thread overview]
Message-ID: <5461173A.1010307@imgtec.com> (raw)
In-Reply-To: <545E12DA.2040107@kernel.org>
On 11/08/2014 09:55 AM, Jonathan Cameron wrote:
> On 05/11/14 21:56, Ezequiel Garcia wrote:
>> From: Phani Movva <Phani.Movva@imgtec.com>
>>
>> This commit adds support for Cosmic Circuits 10001 10-bit ADC device.
>>
>> Signed-off-by: Phani Movva <Phani.Movva@imgtec.com>
>> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
>> [Ezequiel: code style cleaning]
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
> Looks good to me. Some utter nitpicks. I'd have let them go
> but would like this to sit on the list to give others time for
> a second review.
>
Done, all nitpicks fixed. I'll send v3 now.
Thanks,
--
Ezequiel
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
James Hartley
<james.hartley-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>,
Phani Movva <phani.movva-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
knaack.h-Mmb7MZpHnFY@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Naidu Tellapati
<Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 1/3] iio: adc: Cosmic Circuits 10001 ADC driver
Date: Mon, 10 Nov 2014 16:51:22 -0300 [thread overview]
Message-ID: <5461173A.1010307@imgtec.com> (raw)
In-Reply-To: <545E12DA.2040107-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On 11/08/2014 09:55 AM, Jonathan Cameron wrote:
> On 05/11/14 21:56, Ezequiel Garcia wrote:
>> From: Phani Movva <Phani.Movva-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
>>
>> This commit adds support for Cosmic Circuits 10001 10-bit ADC device.
>>
>> Signed-off-by: Phani Movva <Phani.Movva-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Naidu Tellapati <Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
>> [Ezequiel: code style cleaning]
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
> Looks good to me. Some utter nitpicks. I'd have let them go
> but would like this to sit on the list to give others time for
> a second review.
>
Done, all nitpicks fixed. I'll send v3 now.
Thanks,
--
Ezequiel
next prev parent reply other threads:[~2014-11-10 19:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 21:56 [PATCH v2 0/3] iio: Add Cosmic Circuits ADC support Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
2014-11-05 21:56 ` [PATCH v2 1/3] iio: adc: Cosmic Circuits 10001 ADC driver Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
2014-11-08 12:55 ` Jonathan Cameron
2014-11-08 12:55 ` Jonathan Cameron
2014-11-10 19:51 ` Ezequiel Garcia [this message]
2014-11-10 19:51 ` Ezequiel Garcia
2014-11-05 21:56 ` [PATCH v2 2/3] DT: iio: adc: Add CC_10001 binding documentation Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
2014-11-08 12:57 ` Jonathan Cameron
2014-11-08 12:57 ` Jonathan Cameron
2014-11-10 19:50 ` Ezequiel Garcia
2014-11-10 19:50 ` Ezequiel Garcia
2014-11-10 19:59 ` Ezequiel Garcia
2014-11-10 19:59 ` Ezequiel Garcia
2014-11-10 21:28 ` Andrew Bresticker
2014-11-10 21:28 ` Andrew Bresticker
2014-11-11 16:29 ` Ezequiel Garcia
2014-11-11 16:29 ` Ezequiel Garcia
2014-11-08 12:59 ` Jonathan Cameron
2014-11-08 12:59 ` Jonathan Cameron
2014-11-05 21:56 ` [PATCH v2 3/3] DT: Add a vendor prefix for Cosmic Circuits Ezequiel Garcia
2014-11-05 21:56 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5461173A.1010307@imgtec.com \
--to=ezequiel.garcia@imgtec.com \
--cc=Naidu.Tellapati@imgtec.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hartley@imgtec.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=phani.movva@imgtec.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.