Re: [PATCH v2 2/3] DT: iio: adc: Add CC_10001 binding documentation

[Ezequiel Garcia <ezequiel.garcia@imgtec.com>]

On 11/10/2014 04:50 PM, Ezequiel Garcia wrote:
> On 11/08/2014 09:57 AM, Jonathan Cameron wrote:
>> On 05/11/14 21:56, Ezequiel Garcia wrote:

>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt b/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
>>> new file mode 100644
>>> index 0000000..6491839
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/adc/cc_10001_adc.txt
>>> @@ -0,0 +1,19 @@
>>> +* Cosmic Circuits - Analog to Digital Converter (CC-10001-ADC)
>>> +
>>> +Required properties:
>>> +  - compatible: Should be "cosmic,10001-adc"
>>> +  - reg: Should contain adc registers location and length.
>>> +  - cosmic,adc-available-channels: Bitmask of the channels currently enabled.
>> I suspect there may be other preferred ways of doing this (child nodes perhaps
>> for each enabled channel?)
> 
> Hm, I'm not sure about this. As far I can recall, if a node has children
> then it *must* be a bus, which is not the case. Of course, you'll find
> examples doing this wrong.
> 

On a second thought... I guess you meant something like this?

adc: adc@18101600 {
        compatible = "cosmic,10001-adc";
        reg = <0x18101600 0x24>;
        clocks = <&adc_clk>;
        clock-names = "adc";
        vref-supply = <&reg_1v8>;
        cosmic,channels {
                #address-cells = <1>;
                #size-cells = <0>;
                channel@0 {
                        reg = <0>;
                };
                channel@1 {
                        reg = <1>;
                };
        };
};

Might be better, but I don't have a strong opinion on it.

-- 
Ezequiel