From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Anil Kumar <anilk4.v@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, broonie@kernel.org
Cc: tiwai@suse.de, davinci-linux-open-source@linux.davincidsp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
Date: Mon, 10 Nov 2014 14:53:29 +0200 [thread overview]
Message-ID: <5460B549.40203@ti.com> (raw)
In-Reply-To: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com>
On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> ---
> :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c
> sound/soc/davinci/davinci-mcasp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> ret = pm_runtime_get_sync(&pdev->dev);
> if (IS_ERR_VALUE(ret)) {
> dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> + pm_runtime_disable(&pdev->dev);
> return ret;
> }
>
>
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
Date: Mon, 10 Nov 2014 14:53:29 +0200 [thread overview]
Message-ID: <5460B549.40203@ti.com> (raw)
In-Reply-To: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com>
On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> ---
> :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c
> sound/soc/davinci/davinci-mcasp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> ret = pm_runtime_get_sync(&pdev->dev);
> if (IS_ERR_VALUE(ret)) {
> dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> + pm_runtime_disable(&pdev->dev);
> return ret;
> }
>
>
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Anil Kumar <anilk4.v@gmail.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
<broonie@kernel.org>
Cc: <perex@perex.cz>, <tiwai@suse.de>,
<davinci-linux-open-source@linux.davincidsp.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
Date: Mon, 10 Nov 2014 14:53:29 +0200 [thread overview]
Message-ID: <5460B549.40203@ti.com> (raw)
In-Reply-To: <1415537114-9642-1-git-send-email-anilk4.v@gmail.com>
On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> ---
> :100644 100644 0eed9b1... 99c747d... M sound/soc/davinci/davinci-mcasp.c
> sound/soc/davinci/davinci-mcasp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
> ret = pm_runtime_get_sync(&pdev->dev);
> if (IS_ERR_VALUE(ret)) {
> dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> + pm_runtime_disable(&pdev->dev);
> return ret;
> }
>
>
--
Péter
next prev parent reply other threads:[~2014-11-10 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 12:45 [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure Anil Kumar
2014-11-09 12:45 ` Anil Kumar
2014-11-10 12:53 ` Peter Ujfalusi [this message]
2014-11-10 12:53 ` Peter Ujfalusi
2014-11-10 12:53 ` Peter Ujfalusi
2014-11-10 13:45 ` Mark Brown
2014-11-10 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460B549.40203@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=anilk4.v@gmail.com \
--cc=broonie@kernel.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.