All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
@ 2014-11-09 12:45 ` Anil Kumar
  0 siblings, 0 replies; 7+ messages in thread
From: Anil Kumar @ 2014-11-09 12:45 UTC (permalink / raw)
  To: alsa-devel, linux-kernel, lgirdwood, broonie
  Cc: perex, tiwai, peter.ujfalusi, davinci-linux-open-source,
	linux-arm-kernel, anilk4.v

If probe fails then we need to call pm_runtime_disable() to balance
out the previous pm_runtime_enable() call.

Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
---
:100644 100644 0eed9b1... 99c747d... M	sound/soc/davinci/davinci-mcasp.c
 sound/soc/davinci/davinci-mcasp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 0eed9b1..99c747d 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
 	ret = pm_runtime_get_sync(&pdev->dev);
 	if (IS_ERR_VALUE(ret)) {
 		dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
+		pm_runtime_disable(&pdev->dev);
 		return ret;
 	}
 
-- 
1.9.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
@ 2014-11-09 12:45 ` Anil Kumar
  0 siblings, 0 replies; 7+ messages in thread
From: Anil Kumar @ 2014-11-09 12:45 UTC (permalink / raw)
  To: linux-arm-kernel

If probe fails then we need to call pm_runtime_disable() to balance
out the previous pm_runtime_enable() call.

Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
---
:100644 100644 0eed9b1... 99c747d... M	sound/soc/davinci/davinci-mcasp.c
 sound/soc/davinci/davinci-mcasp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 0eed9b1..99c747d 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
 	ret = pm_runtime_get_sync(&pdev->dev);
 	if (IS_ERR_VALUE(ret)) {
 		dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
+		pm_runtime_disable(&pdev->dev);
 		return ret;
 	}
 
-- 
1.9.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
  2014-11-09 12:45 ` Anil Kumar
  (?)
@ 2014-11-10 12:53   ` Peter Ujfalusi
  -1 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2014-11-10 12:53 UTC (permalink / raw)
  To: Anil Kumar, alsa-devel, linux-kernel, lgirdwood, broonie
  Cc: tiwai, davinci-linux-open-source, linux-arm-kernel

On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> ---
> :100644 100644 0eed9b1... 99c747d... M	sound/soc/davinci/davinci-mcasp.c
>  sound/soc/davinci/davinci-mcasp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
>  	ret = pm_runtime_get_sync(&pdev->dev);
>  	if (IS_ERR_VALUE(ret)) {
>  		dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> +		pm_runtime_disable(&pdev->dev);
>  		return ret;
>  	}
>  
> 


-- 
Péter

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
@ 2014-11-10 12:53   ` Peter Ujfalusi
  0 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2014-11-10 12:53 UTC (permalink / raw)
  To: linux-arm-kernel

On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> ---
> :100644 100644 0eed9b1... 99c747d... M	sound/soc/davinci/davinci-mcasp.c
>  sound/soc/davinci/davinci-mcasp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
>  	ret = pm_runtime_get_sync(&pdev->dev);
>  	if (IS_ERR_VALUE(ret)) {
>  		dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> +		pm_runtime_disable(&pdev->dev);
>  		return ret;
>  	}
>  
> 


-- 
P?ter

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
@ 2014-11-10 12:53   ` Peter Ujfalusi
  0 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2014-11-10 12:53 UTC (permalink / raw)
  To: Anil Kumar, alsa-devel, linux-kernel, lgirdwood, broonie
  Cc: perex, tiwai, davinci-linux-open-source, linux-arm-kernel

On 11/09/2014 02:45 PM, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> Signed-off-by: Anil Kumar <anilk4.v@gmail.com>
> ---
> :100644 100644 0eed9b1... 99c747d... M	sound/soc/davinci/davinci-mcasp.c
>  sound/soc/davinci/davinci-mcasp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0eed9b1..99c747d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -1235,6 +1235,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev)
>  	ret = pm_runtime_get_sync(&pdev->dev);
>  	if (IS_ERR_VALUE(ret)) {
>  		dev_err(&pdev->dev, "pm_runtime_get_sync() failed\n");
> +		pm_runtime_disable(&pdev->dev);
>  		return ret;
>  	}
>  
> 


-- 
Péter

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
  2014-11-09 12:45 ` Anil Kumar
@ 2014-11-10 13:45   ` Mark Brown
  -1 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2014-11-10 13:45 UTC (permalink / raw)
  To: Anil Kumar
  Cc: alsa-devel, linux-kernel, lgirdwood, perex, tiwai, peter.ujfalusi,
	davinci-linux-open-source, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

On Sun, Nov 09, 2014 at 06:15:14PM +0530, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure
@ 2014-11-10 13:45   ` Mark Brown
  0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2014-11-10 13:45 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Nov 09, 2014 at 06:15:14PM +0530, Anil Kumar wrote:
> If probe fails then we need to call pm_runtime_disable() to balance
> out the previous pm_runtime_enable() call.

applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141110/2fc8df86/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-11-10 13:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-09 12:45 [PATCH] ASoC: davinvi-mcasp: Balance pm_runtime_enable() on probe failure Anil Kumar
2014-11-09 12:45 ` Anil Kumar
2014-11-10 12:53 ` Peter Ujfalusi
2014-11-10 12:53   ` Peter Ujfalusi
2014-11-10 12:53   ` Peter Ujfalusi
2014-11-10 13:45 ` Mark Brown
2014-11-10 13:45   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.