* [review-request] michaelw/toaster/new-build-button-v2 @ 2014-11-17 15:07 Michael Wood 2014-11-18 12:29 ` Barros Pena, Belen 0 siblings, 1 reply; 5+ messages in thread From: Michael Wood @ 2014-11-17 15:07 UTC (permalink / raw) To: toaster@yoctoproject.org poky-contrib michaelw/toaster/new-build-button-v2 bitbake: toaster: project page remove additional tooltip for Change pencil bitbake: toaster: libtoaster: fix missing tooltip hover on pencil icon bitbake: toaster: Add New Build Button feature bitbake: toaster: libtoaster: Add getProjectInfo utility function bitbake: toaster: Create libtoaster.js with some utility functions Thanks, Michael ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [review-request] michaelw/toaster/new-build-button-v2 2014-11-17 15:07 [review-request] michaelw/toaster/new-build-button-v2 Michael Wood @ 2014-11-18 12:29 ` Barros Pena, Belen 2014-11-18 14:42 ` Michael Wood 0 siblings, 1 reply; 5+ messages in thread From: Barros Pena, Belen @ 2014-11-18 12:29 UTC (permalink / raw) To: Wood, Michael G; +Cc: toaster@yoctoproject.org Hi Michael, This is working really nicely. I just found a couple of tiny issues with the layout. There is a patch here http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/n ew-build-button2&id=dbd175cf9d74ce57382444baab0d516562397ab6 I've also found a small problem with the project input field: the save button should be disabled whenever the field is empty, which is not the case right now. This is how I tested it: in the new build dialog, click on the 'change' icon, select a different project and then, without clicking 'save', delete the project name from the input field. The 'save' button is still enabled (it should be disabled) and, if you click it, it will set the project to the project name you just deleted from the input field, which is a bit weird. We can avoid this kind of thing (and also having to show error messages) by disabling the buttons when their input fields are empty. Thanks!! Belén On 17/11/2014 15:07, "Michael Wood" <michael.g.wood@intel.com> wrote: > >poky-contrib michaelw/toaster/new-build-button-v2 > >bitbake: toaster: project page remove additional tooltip for Change pencil >bitbake: toaster: libtoaster: fix missing tooltip hover on pencil icon >bitbake: toaster: Add New Build Button feature >bitbake: toaster: libtoaster: Add getProjectInfo utility function >bitbake: toaster: Create libtoaster.js with some utility functions > >Thanks, > >Michael >-- >_______________________________________________ >toaster mailing list >toaster@yoctoproject.org >https://lists.yoctoproject.org/listinfo/toaster ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [review-request] michaelw/toaster/new-build-button-v2 2014-11-18 12:29 ` Barros Pena, Belen @ 2014-11-18 14:42 ` Michael Wood 2014-11-18 18:03 ` Barros Pena, Belen 0 siblings, 1 reply; 5+ messages in thread From: Michael Wood @ 2014-11-18 14:42 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org Thanks. I've pushed that fix for that to the same branch. On 18/11/14 12:29, Barros Pena, Belen wrote: > Hi Michael, > > This is working really nicely. I just found a couple of tiny issues with > the layout. There is a patch here > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/n > ew-build-button2&id=dbd175cf9d74ce57382444baab0d516562397ab6 > > I've also found a small problem with the project input field: the save > button should be disabled whenever the field is empty, which is not the > case right now. This is how I tested it: in the new build dialog, click on > the 'change' icon, select a different project and then, without clicking > 'save', delete the project name from the input field. The 'save' button is > still enabled (it should be disabled) and, if you click it, it will set > the project to the project name you just deleted from the input field, > which is a bit weird. We can avoid this kind of thing (and also having to > show error messages) by disabling the buttons when their input fields are > empty. > > Thanks!! > > Belén > > > > On 17/11/2014 15:07, "Michael Wood" <michael.g.wood@intel.com> wrote: > >> poky-contrib michaelw/toaster/new-build-button-v2 >> >> bitbake: toaster: project page remove additional tooltip for Change pencil >> bitbake: toaster: libtoaster: fix missing tooltip hover on pencil icon >> bitbake: toaster: Add New Build Button feature >> bitbake: toaster: libtoaster: Add getProjectInfo utility function >> bitbake: toaster: Create libtoaster.js with some utility functions >> >> Thanks, >> >> Michael >> -- >> _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [review-request] michaelw/toaster/new-build-button-v2 2014-11-18 14:42 ` Michael Wood @ 2014-11-18 18:03 ` Barros Pena, Belen 2014-11-20 10:47 ` Damian, Alexandru 0 siblings, 1 reply; 5+ messages in thread From: Barros Pena, Belen @ 2014-11-18 18:03 UTC (permalink / raw) To: Wood, Michael G; +Cc: toaster@yoctoproject.org On 18/11/2014 14:42, "Michael Wood" <michael.g.wood@intel.com> wrote: >Thanks. I've pushed that fix for that to the same branch. That disables the save button when the input field is empty, but the alert for projects with incomplete configurations no longer comes up for me. Cheers Belén > >On 18/11/14 12:29, Barros Pena, Belen wrote: >> Hi Michael, >> >> This is working really nicely. I just found a couple of tiny issues with >> the layout. There is a patch here >> >> >>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp >>/n >> ew-build-button2&id=dbd175cf9d74ce57382444baab0d516562397ab6 >> >> I've also found a small problem with the project input field: the save >> button should be disabled whenever the field is empty, which is not the >> case right now. This is how I tested it: in the new build dialog, click >>on >> the 'change' icon, select a different project and then, without clicking >> 'save', delete the project name from the input field. The 'save' button >>is >> still enabled (it should be disabled) and, if you click it, it will set >> the project to the project name you just deleted from the input field, >> which is a bit weird. We can avoid this kind of thing (and also having >>to >> show error messages) by disabling the buttons when their input fields >>are >> empty. >> >> Thanks!! >> >> Belén >> >> >> >> On 17/11/2014 15:07, "Michael Wood" <michael.g.wood@intel.com> wrote: >> >>> poky-contrib michaelw/toaster/new-build-button-v2 >>> >>> bitbake: toaster: project page remove additional tooltip for Change >>>pencil >>> bitbake: toaster: libtoaster: fix missing tooltip hover on pencil icon >>> bitbake: toaster: Add New Build Button feature >>> bitbake: toaster: libtoaster: Add getProjectInfo utility function >>> bitbake: toaster: Create libtoaster.js with some utility functions >>> >>> Thanks, >>> >>> Michael >>> -- >>> _______________________________________________ >>> toaster mailing list >>> toaster@yoctoproject.org >>> https://lists.yoctoproject.org/listinfo/toaster > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [review-request] michaelw/toaster/new-build-button-v2 2014-11-18 18:03 ` Barros Pena, Belen @ 2014-11-20 10:47 ` Damian, Alexandru 0 siblings, 0 replies; 5+ messages in thread From: Damian, Alexandru @ 2014-11-20 10:47 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 2584 bytes --] Taken, pushed to toaster/master On Tue, Nov 18, 2014 at 6:03 PM, Barros Pena, Belen < belen.barros.pena@intel.com> wrote: > On 18/11/2014 14:42, "Michael Wood" <michael.g.wood@intel.com> wrote: > > >Thanks. I've pushed that fix for that to the same branch. > > That disables the save button when the input field is empty, but the alert > for projects with incomplete configurations no longer comes up for me. > > Cheers > > Belén > > > > >On 18/11/14 12:29, Barros Pena, Belen wrote: > >> Hi Michael, > >> > >> This is working really nicely. I just found a couple of tiny issues with > >> the layout. There is a patch here > >> > >> > >> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp > >>/n > >> ew-build-button2&id=dbd175cf9d74ce57382444baab0d516562397ab6 > >> > >> I've also found a small problem with the project input field: the save > >> button should be disabled whenever the field is empty, which is not the > >> case right now. This is how I tested it: in the new build dialog, click > >>on > >> the 'change' icon, select a different project and then, without clicking > >> 'save', delete the project name from the input field. The 'save' button > >>is > >> still enabled (it should be disabled) and, if you click it, it will set > >> the project to the project name you just deleted from the input field, > >> which is a bit weird. We can avoid this kind of thing (and also having > >>to > >> show error messages) by disabling the buttons when their input fields > >>are > >> empty. > >> > >> Thanks!! > >> > >> Belén > >> > >> > >> > >> On 17/11/2014 15:07, "Michael Wood" <michael.g.wood@intel.com> wrote: > >> > >>> poky-contrib michaelw/toaster/new-build-button-v2 > >>> > >>> bitbake: toaster: project page remove additional tooltip for Change > >>>pencil > >>> bitbake: toaster: libtoaster: fix missing tooltip hover on pencil icon > >>> bitbake: toaster: Add New Build Button feature > >>> bitbake: toaster: libtoaster: Add getProjectInfo utility function > >>> bitbake: toaster: Create libtoaster.js with some utility functions > >>> > >>> Thanks, > >>> > >>> Michael > >>> -- > >>> _______________________________________________ > >>> toaster mailing list > >>> toaster@yoctoproject.org > >>> https://lists.yoctoproject.org/listinfo/toaster > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 4142 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-20 10:48 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-17 15:07 [review-request] michaelw/toaster/new-build-button-v2 Michael Wood 2014-11-18 12:29 ` Barros Pena, Belen 2014-11-18 14:42 ` Michael Wood 2014-11-18 18:03 ` Barros Pena, Belen 2014-11-20 10:47 ` Damian, Alexandru
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.