* [review-request] bbarrosp/all-pages
@ 2014-11-13 11:40 Barros Pena, Belen
2014-11-17 18:46 ` Michael Wood
0 siblings, 1 reply; 6+ messages in thread
From: Barros Pena, Belen @ 2014-11-13 11:40 UTC (permalink / raw)
To: toaster@yoctoproject.org
This branch:
* Fixes the layout of the dependencies modal dialog
* Removes the external link icon from the target name column when the cell
is empty
* Adds the 'no results' state to the all layers page
Thanks!
Belén
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] bbarrosp/all-pages
2014-11-13 11:40 [review-request] bbarrosp/all-pages Barros Pena, Belen
@ 2014-11-17 18:46 ` Michael Wood
2014-11-18 14:33 ` Barros Pena, Belen
0 siblings, 1 reply; 6+ messages in thread
From: Michael Wood @ 2014-11-17 18:46 UTC (permalink / raw)
To: Barros Pena, Belen, toaster@yoctoproject.org
On 13/11/14 11:40, Barros Pena, Belen wrote:
> This branch:
>
> * Fixes the layout of the dependencies modal dialog
> * Removes the external link icon from the target name column when the cell
> is empty
> * Adds the 'no results' state to the all layers page
>
> Thanks!
>
> Belén
>
commit e8107bbb44afeec888667f5239afa33bf71235b4
<td class="target">
{{o.name}}
- <a target="_blank"
href="{{o.get_layersource_view_url}}"><i class="icon-share
get-info"></i></a>
+ {% if o.name %}
+ <a target="_blank"
href="{{o.get_layersource_view_url}}"><i class="icon-share
get-info"></i></a>
+ {% endif%}
</td>
A tiny tiny niggle would be that {{o.name}} could be inside the if
statement so that when you read it, it's not "use this var... now check
it exists" the templating engine will do the right thing so it's just a
reading issue.
commit 8c38eec9e48e2bcf492584f70991056a3513c479
IMO we should avoid using 'Named access on the Window object' as they're
a bit dodgy/too magic[1]. But as you know other templates in toaster
already have this same code, so we may as commit it and fix it with a
next refactoring commit.
other than that looks good to me.
Michael
[1] good article about that here
http://tjvantoll.com/2012/07/19/dom-element-references-as-global-variables/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [review-request] bbarrosp/all-pages
2014-11-17 18:46 ` Michael Wood
@ 2014-11-18 14:33 ` Barros Pena, Belen
2014-11-18 15:07 ` Michael Wood
0 siblings, 1 reply; 6+ messages in thread
From: Barros Pena, Belen @ 2014-11-18 14:33 UTC (permalink / raw)
To: Wood, Michael G, toaster@yoctoproject.org
On 17/11/2014 18:46, "Michael Wood" <michael.g.wood@intel.com> wrote:
>On 13/11/14 11:40, Barros Pena, Belen wrote:
>> This branch:
>>
>> * Fixes the layout of the dependencies modal dialog
>> * Removes the external link icon from the target name column when the
>>cell
>> is empty
>> * Adds the 'no results' state to the all layers page
>>
>> Thanks!
>>
>> Belén
>>
>commit e8107bbb44afeec888667f5239afa33bf71235b4
>
><td class="target">
> {{o.name}}
>- <a target="_blank"
>href="{{o.get_layersource_view_url}}"><i class="icon-share
>get-info"></i></a>
>+ {% if o.name %}
>+ <a target="_blank"
>href="{{o.get_layersource_view_url}}"><i class="icon-share
>get-info"></i></a>
>+ {% endif%}
> </td>
>
>A tiny tiny niggle would be that {{o.name}} could be inside the if
>statement so that when you read it, it's not "use this var... now check
>it exists"
When you put it that way, it does sound silly.
>the templating engine will do the right thing so it's just a
>reading issue.
>
>commit 8c38eec9e48e2bcf492584f70991056a3513c479
You mean like this?
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/a
ll-pages-v2&id=90c6ebf2647acd2e8feb0404700dd87467a4f8aa
Thanks!
Belén
>
>IMO we should avoid using 'Named access on the Window object' as they're
>a bit dodgy/too magic[1]. But as you know other templates in toaster
>already have this same code, so we may as commit it and fix it with a
>next refactoring commit.
>
>other than that looks good to me.
>
>Michael
>
>[1] good article about that here
>http://tjvantoll.com/2012/07/19/dom-element-references-as-global-variables
>/
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [review-request] bbarrosp/all-pages
2014-11-18 14:33 ` Barros Pena, Belen
@ 2014-11-18 15:07 ` Michael Wood
2014-11-20 10:21 ` Damian, Alexandru
0 siblings, 1 reply; 6+ messages in thread
From: Michael Wood @ 2014-11-18 15:07 UTC (permalink / raw)
To: Barros Pena, Belen, toaster@yoctoproject.org
On 18/11/14 14:33, Barros Pena, Belen wrote:
>> commit e8107bbb44afeec888667f5239afa33bf71235b4
>>
>> <td class="target">
>> {{o.name}}
>> - <a target="_blank"
>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>> get-info"></i></a>
>> + {% if o.name %}
>> + <a target="_blank"
>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>> get-info"></i></a>
>> + {% endif%}
>> </td>
>>
>> A tiny tiny niggle would be that {{o.name}} could be inside the if
>> statement so that when you read it, it's not "use this var... now check
>> it exists"
> When you put it that way, it does sound silly.
>
>
>> the templating engine will do the right thing so it's just a
>> reading issue.
>>
>> commit 8c38eec9e48e2bcf492584f70991056a3513c479
> You mean like this?
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/a
> ll-pages-v2&id=90c6ebf2647acd2e8feb0404700dd87467a4f8aa
Yep. looks good to me.
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [review-request] bbarrosp/all-pages
2014-11-18 15:07 ` Michael Wood
@ 2014-11-20 10:21 ` Damian, Alexandru
2014-11-20 10:47 ` Damian, Alexandru
0 siblings, 1 reply; 6+ messages in thread
From: Damian, Alexandru @ 2014-11-20 10:21 UTC (permalink / raw)
To: Michael Wood; +Cc: toaster@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]
Now that I think of it, we should enable 'strict' - mode javascript across
all pages...
On Tue, Nov 18, 2014 at 3:07 PM, Michael Wood <michael.g.wood@intel.com>
wrote:
> On 18/11/14 14:33, Barros Pena, Belen wrote:
>
>> commit e8107bbb44afeec888667f5239afa33bf71235b4
>>>
>>> <td class="target">
>>> {{o.name}}
>>> - <a target="_blank"
>>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>>> get-info"></i></a>
>>> + {% if o.name %}
>>> + <a target="_blank"
>>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>>> get-info"></i></a>
>>> + {% endif%}
>>> </td>
>>>
>>> A tiny tiny niggle would be that {{o.name}} could be inside the if
>>> statement so that when you read it, it's not "use this var... now check
>>> it exists"
>>>
>> When you put it that way, it does sound silly.
>>
>>
>> the templating engine will do the right thing so it's just a
>>> reading issue.
>>>
>>> commit 8c38eec9e48e2bcf492584f70991056a3513c479
>>>
>> You mean like this?
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
>> commit/?h=bbarrosp/a
>> ll-pages-v2&id=90c6ebf2647acd2e8feb0404700dd87467a4f8aa
>>
> Yep. looks good to me.
>
> Michael
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 3136 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [review-request] bbarrosp/all-pages
2014-11-20 10:21 ` Damian, Alexandru
@ 2014-11-20 10:47 ` Damian, Alexandru
0 siblings, 0 replies; 6+ messages in thread
From: Damian, Alexandru @ 2014-11-20 10:47 UTC (permalink / raw)
To: Michael Wood; +Cc: toaster@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]
And taken, pushed to toaster/master
On Thu, Nov 20, 2014 at 10:21 AM, Damian, Alexandru <
alexandru.damian@intel.com> wrote:
> Now that I think of it, we should enable 'strict' - mode javascript across
> all pages...
>
> On Tue, Nov 18, 2014 at 3:07 PM, Michael Wood <michael.g.wood@intel.com>
> wrote:
>
>> On 18/11/14 14:33, Barros Pena, Belen wrote:
>>
>>> commit e8107bbb44afeec888667f5239afa33bf71235b4
>>>>
>>>> <td class="target">
>>>> {{o.name}}
>>>> - <a target="_blank"
>>>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>>>> get-info"></i></a>
>>>> + {% if o.name %}
>>>> + <a target="_blank"
>>>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>>>> get-info"></i></a>
>>>> + {% endif%}
>>>> </td>
>>>>
>>>> A tiny tiny niggle would be that {{o.name}} could be inside the if
>>>> statement so that when you read it, it's not "use this var... now check
>>>> it exists"
>>>>
>>> When you put it that way, it does sound silly.
>>>
>>>
>>> the templating engine will do the right thing so it's just a
>>>> reading issue.
>>>>
>>>> commit 8c38eec9e48e2bcf492584f70991056a3513c479
>>>>
>>> You mean like this?
>>>
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
>>> commit/?h=bbarrosp/a
>>> ll-pages-v2&id=90c6ebf2647acd2e8feb0404700dd87467a4f8aa
>>>
>> Yep. looks good to me.
>>
>> Michael
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>>
>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 4032 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-20 10:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-13 11:40 [review-request] bbarrosp/all-pages Barros Pena, Belen
2014-11-17 18:46 ` Michael Wood
2014-11-18 14:33 ` Barros Pena, Belen
2014-11-18 15:07 ` Michael Wood
2014-11-20 10:21 ` Damian, Alexandru
2014-11-20 10:47 ` Damian, Alexandru
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.