All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wood <michael.g.wood@intel.com>
To: toaster@yoctoproject.org
Subject: Re: [review-request] adamian/20141215-development
Date: Tue, 16 Dec 2014 15:29:11 +0000	[thread overview]
Message-ID: <54904FC7.1070700@intel.com> (raw)
In-Reply-To: <CAJ2CSBuY0wSu0VYbSESSMB4dN8UnEvi_Wff_6=brjr_gKAhKxA@mail.gmail.com>

Only one little thing, could we rename "get_actual_commit" to something 
like "get_vcs_reference" as what we're aiming for is the output of the 
function + layer.vcs_url would give you the correct url + reference to 
be able to checkout or recognise the repository with it's associated 
branch/tag/commit.

Thanks,

Michael

On 16/12/14 12:38, Damian, Alexandru wrote:
> This patch changes the build variable setting from in-process 
> injection to a pre-conf file.
>
> Thanks,
> Alex
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>



  reply	other threads:[~2014-12-16 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-16 12:38 [review-request] adamian/20141215-development Damian, Alexandru
2014-12-16 15:29 ` Michael Wood [this message]
2015-01-08 13:00   ` Damian, Alexandru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54904FC7.1070700@intel.com \
    --to=michael.g.wood@intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.