[review-request] adamian/20141215-development

[review-request] adamian/20141215-development

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

This patch changes the build variable setting from in-process injection to
a pre-conf file.

Thanks,
Alex

-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 554 bytes --]

Re: [review-request] adamian/20141215-development

[Michael Wood]

Only one little thing, could we rename "get_actual_commit" to something 
like "get_vcs_reference" as what we're aiming for is the output of the 
function + layer.vcs_url would give you the correct url + reference to 
be able to checkout or recognise the repository with it's associated 
branch/tag/commit.

Thanks,

Michael

On 16/12/14 12:38, Damian, Alexandru wrote:
> This patch changes the build variable setting from in-process 
> injection to a pre-conf file.
>
> Thanks,
> Alex
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>

Re: [review-request] adamian/20141215-development

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

Renamed method from get_actual_commit to get_vcs_reference, as it way
clearer.

Taken in submission queue.

On Tue, Dec 16, 2014 at 3:29 PM, Michael Wood <michael.g.wood@intel.com>
wrote:

> Only one little thing, could we rename "get_actual_commit" to something
> like "get_vcs_reference" as what we're aiming for is the output of the
> function + layer.vcs_url would give you the correct url + reference to be
> able to checkout or recognise the repository with it's associated
> branch/tag/commit.
>
> Thanks,
>
> Michael
>
>
> On 16/12/14 12:38, Damian, Alexandru wrote:
>
>> This patch changes the build variable setting from in-process injection
>> to a pre-conf file.
>>
>> Thanks,
>> Alex
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>>
>>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 2047 bytes --]