* [review-request] adamian/20141215-development
@ 2014-12-16 12:38 Damian, Alexandru
2014-12-16 15:29 ` Michael Wood
0 siblings, 1 reply; 3+ messages in thread
From: Damian, Alexandru @ 2014-12-16 12:38 UTC (permalink / raw)
To: toaster@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
This patch changes the build variable setting from in-process injection to
a pre-conf file.
Thanks,
Alex
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 554 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [review-request] adamian/20141215-development
2014-12-16 12:38 [review-request] adamian/20141215-development Damian, Alexandru
@ 2014-12-16 15:29 ` Michael Wood
2015-01-08 13:00 ` Damian, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: Michael Wood @ 2014-12-16 15:29 UTC (permalink / raw)
To: toaster
Only one little thing, could we rename "get_actual_commit" to something
like "get_vcs_reference" as what we're aiming for is the output of the
function + layer.vcs_url would give you the correct url + reference to
be able to checkout or recognise the repository with it's associated
branch/tag/commit.
Thanks,
Michael
On 16/12/14 12:38, Damian, Alexandru wrote:
> This patch changes the build variable setting from in-process
> injection to a pre-conf file.
>
> Thanks,
> Alex
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [review-request] adamian/20141215-development
2014-12-16 15:29 ` Michael Wood
@ 2015-01-08 13:00 ` Damian, Alexandru
0 siblings, 0 replies; 3+ messages in thread
From: Damian, Alexandru @ 2015-01-08 13:00 UTC (permalink / raw)
To: Michael Wood; +Cc: toaster@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
Renamed method from get_actual_commit to get_vcs_reference, as it way
clearer.
Taken in submission queue.
On Tue, Dec 16, 2014 at 3:29 PM, Michael Wood <michael.g.wood@intel.com>
wrote:
> Only one little thing, could we rename "get_actual_commit" to something
> like "get_vcs_reference" as what we're aiming for is the output of the
> function + layer.vcs_url would give you the correct url + reference to be
> able to checkout or recognise the repository with it's associated
> branch/tag/commit.
>
> Thanks,
>
> Michael
>
>
> On 16/12/14 12:38, Damian, Alexandru wrote:
>
>> This patch changes the build variable setting from in-process injection
>> to a pre-conf file.
>>
>> Thanks,
>> Alex
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>>
>>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 2047 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-08 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-16 12:38 [review-request] adamian/20141215-development Damian, Alexandru
2014-12-16 15:29 ` Michael Wood
2015-01-08 13:00 ` Damian, Alexandru
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.