Question on CE_DESC_FLAGS_META_DATA field.

Question on CE_DESC_FLAGS_META_DATA field.

[Ben Greear]

While poking in the CE code, I notice this below.

Shouldn't the CE_DESC_FLAGS_META_DATA_LSB be 2, and if not,
can someone explain why?

[greearb@ben-dt2 ath10k]$ grep CE_DESC_FLAGS_META_DATA *h
ce.h:#define CE_DESC_FLAGS_META_DATA_MASK 0xFFFC
ce.h:#define CE_DESC_FLAGS_META_DATA_LSB  3

and this from core.h:

#define MS(_v, _f) (((_v) & _f##_MASK) >> _f##_LSB)

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Question on CE_DESC_FLAGS_META_DATA field.

[Michal Kazior]

On 9 January 2015 at 19:06, Ben Greear <greearb@candelatech.com> wrote:
> While poking in the CE code, I notice this below.
>
> Shouldn't the CE_DESC_FLAGS_META_DATA_LSB be 2, and if not,
> can someone explain why?
>
> [greearb@ben-dt2 ath10k]$ grep CE_DESC_FLAGS_META_DATA *h
> ce.h:#define CE_DESC_FLAGS_META_DATA_MASK 0xFFFC
> ce.h:#define CE_DESC_FLAGS_META_DATA_LSB  3

Nice catch!

This shouldn't have been harmful though. Meta data part is used to
store htc endpoint ids which shouldn't overflow the mask even with
lsb=3 and as far as I know neither CE nor firmware cares what is
stored there.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Question on CE_DESC_FLAGS_META_DATA field.

[Ben Greear]

On 01/11/2015 11:42 PM, Michal Kazior wrote:
> On 9 January 2015 at 19:06, Ben Greear <greearb@candelatech.com> wrote:
>> While poking in the CE code, I notice this below.
>>
>> Shouldn't the CE_DESC_FLAGS_META_DATA_LSB be 2, and if not,
>> can someone explain why?
>>
>> [greearb@ben-dt2 ath10k]$ grep CE_DESC_FLAGS_META_DATA *h
>> ce.h:#define CE_DESC_FLAGS_META_DATA_MASK 0xFFFC
>> ce.h:#define CE_DESC_FLAGS_META_DATA_LSB  3
> 
> Nice catch!
> 
> This shouldn't have been harmful though. Meta data part is used to
> store htc endpoint ids which shouldn't overflow the mask even with
> lsb=3 and as far as I know neither CE nor firmware cares what is
> stored there.

Ok, I'll fix this in my tree and post a patch sometime soon.

Upstream 10.1 firmware does ignore the transfer_id, but I am
fixing that in my firmware to aid debugging (and fixing ath10k
driver to use it for debugging as well).

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k