All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Courbot <acourbot@nvidia.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	David Airlie <airlied@linux.ie>, Ben Skeggs <bskeggs@redhat.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/nouveau/nouveau_bo: Remove unused function
Date: Tue, 13 Jan 2015 11:01:10 +0900	[thread overview]
Message-ID: <54B47C66.1010805@nvidia.com> (raw)
In-Reply-To: <1421015495-24744-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

On 01/12/2015 07:31 AM, Rickard Strandqvist wrote:
> Remove the function nouveau_bo_rd16() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.

nouveau_bo_wr16() being presumably used (since it is not removed by this 
patch), it sounds safe to keep its read counterpart?

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	David Airlie <airlied@linux.ie>, Ben Skeggs <bskeggs@redhat.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@canonical.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/nouveau/nouveau_bo: Remove unused function
Date: Tue, 13 Jan 2015 11:01:10 +0900	[thread overview]
Message-ID: <54B47C66.1010805@nvidia.com> (raw)
In-Reply-To: <1421015495-24744-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

On 01/12/2015 07:31 AM, Rickard Strandqvist wrote:
> Remove the function nouveau_bo_rd16() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.

nouveau_bo_wr16() being presumably used (since it is not removed by this 
patch), it sounds safe to keep its read counterpart?


  reply	other threads:[~2015-01-13  2:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-11 22:31 [PATCH] drm/nouveau/nouveau_bo: Remove unused function Rickard Strandqvist
2015-01-13  2:01 ` Alexandre Courbot [this message]
2015-01-13  2:01   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B47C66.1010805@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.