All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Nishanth Menon" <nm@ti.com>,
	"Grazvydas Ignotas" <notasas@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"dt list" <devicetree@vger.kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Tony Lindgren" <tony@atomide.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org, "Rob Herring" <robh+dt@kernel.org>,
	"Jean Delvare" <jdelvare@suse.de>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Pali Rohar" <pali.rohar@gmail.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor
Date: Sun, 18 Jan 2015 14:18:24 -0800	[thread overview]
Message-ID: <54BC3130.4010401@roeck-us.net> (raw)
In-Reply-To: <20150118203346.GA29863@amd>

On 01/18/2015 12:33 PM, Pavel Machek wrote:

>>>> Pavel,
>>>>
>>>> can you look into the omap4 thermal driver to see if it can be used ?
>>>
>>> After some fixes... yes, it seems to be same hardware.
>>>
>> So this should be the way to go, but then we have others claim that
>> it should not be done because the OMAP3 sensors are too unreliable
>> to use for thermal decisions. Not really sure where that leaves us.
>> I am kind of opposed to have similar drivers for similar chips
>> in two different subsystems.
>>
>> Is it possible to add the patch below to the omap thermal driver
>> and not use it for thermal decisions ?
>
> Well... noone forces you to enable the driver, and I don't think it
> will do any thermal decisions on N900 as it is ... so we should be ok.
>
> Plus, it seems to work reasonably well (say +- 5 C), so situation does
> not seem to be as bad as TI claims.
>
> Nokia was actually using it in production.
>
Ok, I'll assume that omap3 support will be added to the omap thermal driver.

Thanks,
Guenter


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Nishanth Menon" <nm@ti.com>,
	"Grazvydas Ignotas" <notasas@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"dt list" <devicetree@vger.kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Tony Lindgren" <tony@atomide.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org, "Rob Herring" <robh+dt@kernel.org>,
	"Jean Delvare" <jdelvare@suse.de>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Pali Rohar" <pali.rohar@gmail.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [lm-sensors] [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor
Date: Sun, 18 Jan 2015 22:18:24 +0000	[thread overview]
Message-ID: <54BC3130.4010401@roeck-us.net> (raw)
In-Reply-To: <20150118203346.GA29863@amd>

On 01/18/2015 12:33 PM, Pavel Machek wrote:

>>>> Pavel,
>>>>
>>>> can you look into the omap4 thermal driver to see if it can be used ?
>>>
>>> After some fixes... yes, it seems to be same hardware.
>>>
>> So this should be the way to go, but then we have others claim that
>> it should not be done because the OMAP3 sensors are too unreliable
>> to use for thermal decisions. Not really sure where that leaves us.
>> I am kind of opposed to have similar drivers for similar chips
>> in two different subsystems.
>>
>> Is it possible to add the patch below to the omap thermal driver
>> and not use it for thermal decisions ?
>
> Well... noone forces you to enable the driver, and I don't think it
> will do any thermal decisions on N900 as it is ... so we should be ok.
>
> Plus, it seems to work reasonably well (say +- 5 C), so situation does
> not seem to be as bad as TI claims.
>
> Nokia was actually using it in production.
>
Ok, I'll assume that omap3 support will be added to the omap thermal driver.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor
Date: Sun, 18 Jan 2015 14:18:24 -0800	[thread overview]
Message-ID: <54BC3130.4010401@roeck-us.net> (raw)
In-Reply-To: <20150118203346.GA29863@amd>

On 01/18/2015 12:33 PM, Pavel Machek wrote:

>>>> Pavel,
>>>>
>>>> can you look into the omap4 thermal driver to see if it can be used ?
>>>
>>> After some fixes... yes, it seems to be same hardware.
>>>
>> So this should be the way to go, but then we have others claim that
>> it should not be done because the OMAP3 sensors are too unreliable
>> to use for thermal decisions. Not really sure where that leaves us.
>> I am kind of opposed to have similar drivers for similar chips
>> in two different subsystems.
>>
>> Is it possible to add the patch below to the omap thermal driver
>> and not use it for thermal decisions ?
>
> Well... noone forces you to enable the driver, and I don't think it
> will do any thermal decisions on N900 as it is ... so we should be ok.
>
> Plus, it seems to work reasonably well (say +- 5 C), so situation does
> not seem to be as bad as TI claims.
>
> Nokia was actually using it in production.
>
Ok, I'll assume that omap3 support will be added to the omap thermal driver.

Thanks,
Guenter

  reply	other threads:[~2015-01-18 22:18 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-26 10:29 [PATCH] add omap34xx temperature monitoring support Pavel Machek
2014-12-26 10:29 ` Pavel Machek
2014-12-26 10:29 ` [lm-sensors] " Pavel Machek
2014-12-26 12:34 ` [PATCH 0/3] OMAP3 temperature sensor Sebastian Reichel
2014-12-26 12:34   ` Sebastian Reichel
2014-12-26 12:34   ` Sebastian Reichel
2014-12-26 12:34   ` [lm-sensors] " Sebastian Reichel
2014-12-26 12:34   ` [PATCH 1/3] DT Binding for omap3 " Sebastian Reichel
2014-12-26 12:34     ` Sebastian Reichel
2014-12-26 12:34     ` [lm-sensors] " Sebastian Reichel
     [not found]     ` <1419597294-21487-2-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-12-26 17:19       ` Pavel Machek
2014-12-26 17:19         ` Pavel Machek
2014-12-26 17:19         ` Pavel Machek
2014-12-26 17:19         ` [lm-sensors] " Pavel Machek
2014-12-26 23:50         ` Sebastian Reichel
2014-12-26 23:50           ` Sebastian Reichel
2014-12-26 23:50           ` Sebastian Reichel
2014-12-26 23:50           ` [lm-sensors] " Sebastian Reichel
2014-12-27 19:09       ` Pavel Machek
2014-12-27 19:09         ` Pavel Machek
2014-12-27 19:09         ` Pavel Machek
2014-12-27 19:09         ` [lm-sensors] " Pavel Machek
2014-12-26 12:34   ` [PATCH 2/3] hwmon: Driver for OMAP3 " Sebastian Reichel
2014-12-26 12:34     ` Sebastian Reichel
2014-12-26 12:34     ` [lm-sensors] " Sebastian Reichel
2014-12-26 17:26     ` Pavel Machek
2014-12-26 17:26       ` Pavel Machek
2014-12-26 17:26       ` [lm-sensors] " Pavel Machek
2014-12-27 19:24     ` Pavel Machek
2014-12-27 19:24       ` Pavel Machek
2014-12-27 19:24       ` [lm-sensors] " Pavel Machek
2014-12-27 19:40     ` Pavel Machek
2014-12-27 19:40       ` Pavel Machek
2014-12-27 19:40       ` [lm-sensors] " Pavel Machek
2014-12-27 19:48     ` Pavel Machek
2014-12-27 19:48       ` Pavel Machek
2014-12-27 19:48       ` [lm-sensors] " Pavel Machek
     [not found]     ` <1419597294-21487-3-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-12-27 19:58       ` Pavel Machek
2014-12-27 19:58         ` Pavel Machek
2014-12-27 19:58         ` Pavel Machek
2014-12-27 19:58         ` [lm-sensors] " Pavel Machek
2014-12-27 22:35         ` Pavel Machek
2014-12-27 22:35           ` Pavel Machek
2014-12-27 22:35           ` [lm-sensors] " Pavel Machek
2014-12-28  8:24           ` Guenter Roeck
2014-12-28  8:24             ` Guenter Roeck
2014-12-28  8:24             ` [lm-sensors] " Guenter Roeck
2014-12-28 10:07             ` Sebastian Reichel
2014-12-28 10:07               ` Sebastian Reichel
2014-12-28 10:07               ` Sebastian Reichel
2014-12-28 10:07               ` [lm-sensors] " Sebastian Reichel
2014-12-29 17:52       ` Grazvydas Ignotas
2014-12-29 17:52         ` Grazvydas Ignotas
2014-12-29 17:52         ` Grazvydas Ignotas
2014-12-29 17:52         ` [lm-sensors] " Grazvydas Ignotas
2014-12-29 18:01         ` Nishanth Menon
2014-12-29 18:01           ` Nishanth Menon
2014-12-29 18:01           ` [lm-sensors] " Nishanth Menon
     [not found]           ` <CAGo_u6qO0ok+GBnm7SQtw6dJuwGN2OuP7CpKDEWawS3V2go4KA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-29 18:15             ` Pavel Machek
2014-12-29 18:15               ` Pavel Machek
2014-12-29 18:15               ` Pavel Machek
2014-12-29 18:15               ` [lm-sensors] " Pavel Machek
2014-12-29 19:04               ` Guenter Roeck
2014-12-29 19:04                 ` Guenter Roeck
2014-12-29 19:04                 ` Guenter Roeck
2014-12-29 19:04                 ` [lm-sensors] " Guenter Roeck
     [not found]                 ` <20141229190448.GA27124-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-12-30 22:46                   ` Pavel Machek
2014-12-30 22:46                     ` Pavel Machek
2014-12-30 22:46                     ` Pavel Machek
2014-12-30 22:46                     ` [lm-sensors] " Pavel Machek
2015-01-01  9:11                 ` Pavel Machek
2015-01-01  9:11                   ` Pavel Machek
2015-01-01  9:11                   ` [lm-sensors] " Pavel Machek
2015-01-03  9:18                 ` Pavel Machek
2015-01-03  9:18                   ` Pavel Machek
2015-01-03  9:18                   ` [lm-sensors] " Pavel Machek
2015-01-07 16:19                   ` Guenter Roeck
2015-01-07 16:19                     ` Guenter Roeck
2015-01-07 16:19                     ` [lm-sensors] " Guenter Roeck
2015-01-18 20:33                     ` Pavel Machek
2015-01-18 20:33                       ` Pavel Machek
2015-01-18 20:33                       ` [lm-sensors] " Pavel Machek
2015-01-18 22:18                       ` Guenter Roeck [this message]
2015-01-18 22:18                         ` Guenter Roeck
2015-01-18 22:18                         ` [lm-sensors] " Guenter Roeck
2014-12-29 20:35               ` Nishanth Menon
2014-12-29 20:35                 ` Nishanth Menon
2014-12-29 20:35                 ` Nishanth Menon
2014-12-29 20:35                 ` [lm-sensors] " Nishanth Menon
     [not found]                 ` <54A1BB2B.9060204-l0cyMroinI0@public.gmane.org>
2014-12-30 18:00                   ` Pavel Machek
2014-12-30 18:00                     ` Pavel Machek
2014-12-30 18:00                     ` Pavel Machek
2014-12-30 18:00                     ` [lm-sensors] " Pavel Machek
2014-12-27 23:26     ` Pavel Machek
2014-12-27 23:26       ` Pavel Machek
2014-12-27 23:26       ` [lm-sensors] " Pavel Machek
2014-12-26 12:34   ` [PATCH 3/3] ARM: dts: OMAP34xx/36xx: Add " Sebastian Reichel
2014-12-26 12:34     ` Sebastian Reichel
2014-12-26 12:34     ` [lm-sensors] " Sebastian Reichel
     [not found]     ` <1419597294-21487-4-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-12-27 19:09       ` Pavel Machek
2014-12-27 19:09         ` Pavel Machek
2014-12-27 19:09         ` Pavel Machek
2014-12-27 19:09         ` [lm-sensors] " Pavel Machek
2014-12-26 15:54 ` [PATCH] add omap34xx temperature monitoring support Tony Lindgren
2014-12-26 15:54   ` Tony Lindgren
2014-12-26 15:54   ` [lm-sensors] " Tony Lindgren
2014-12-26 16:17   ` Tony Lindgren
2014-12-26 16:17     ` Tony Lindgren
2014-12-26 16:17     ` [lm-sensors] " Tony Lindgren
2014-12-26 16:26     ` Pali Rohár
2014-12-26 16:26       ` Pali Rohár
2014-12-26 16:26       ` [lm-sensors] " Pali Rohár
2014-12-26 16:31       ` Tony Lindgren
2014-12-26 16:31         ` Tony Lindgren
2014-12-26 16:31         ` [lm-sensors] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BC3130.4010401@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=nm@ti.com \
    --cc=notasas@gmail.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.