All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <david.ahern@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Fri, 20 Mar 2015 16:49:29 -0600	[thread overview]
Message-ID: <550CA3F9.9040201@oracle.com> (raw)
In-Reply-To: <CA+55aFxoVPRuFJGuP_=0-NCiqx_NPeJBv+SAZqbAzeC9AhN+CA@mail.gmail.com>

On 3/20/15 3:17 PM, Linus Torvalds wrote:
> In other words, if I read that sparc asm right (and it is very likely
> that I do *not*), then "objp" is NULL, and that's why you crash.

That does appear to be why. I put a WARN_ON before 
clear_obj_pfmemalloc() if objpp[i] is NULL. I got 2 splats during an 
'allyesconfig' build and the system stayed up.

>
> That's odd, because we know that objp cannot be NULL in
> kmem_slab_free() (even if we allowed it, like with kfree(),
> remove_vma() cannot possibly have a NULL vma, since ti dereferences it
> multiple times).
>
> So I must be misreading this completely. Somebody with better sparc
> debugging mojo should double-check my logic. How would objp be NULL?

I'll add checks to higher layers and see if it reveals anything.

I did ask around and apparently this bug is hit only with the new M7 
processors. DaveM: that's why you are not hitting this.

David

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <david.ahern@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Fri, 20 Mar 2015 16:49:29 -0600	[thread overview]
Message-ID: <550CA3F9.9040201@oracle.com> (raw)
In-Reply-To: <CA+55aFxoVPRuFJGuP_=0-NCiqx_NPeJBv+SAZqbAzeC9AhN+CA@mail.gmail.com>

On 3/20/15 3:17 PM, Linus Torvalds wrote:
> In other words, if I read that sparc asm right (and it is very likely
> that I do *not*), then "objp" is NULL, and that's why you crash.

That does appear to be why. I put a WARN_ON before 
clear_obj_pfmemalloc() if objpp[i] is NULL. I got 2 splats during an 
'allyesconfig' build and the system stayed up.

>
> That's odd, because we know that objp cannot be NULL in
> kmem_slab_free() (even if we allowed it, like with kfree(),
> remove_vma() cannot possibly have a NULL vma, since ti dereferences it
> multiple times).
>
> So I must be misreading this completely. Somebody with better sparc
> debugging mojo should double-check my logic. How would objp be NULL?

I'll add checks to higher layers and see if it reveals anything.

I did ask around and apparently this bug is hit only with the new M7 
processors. DaveM: that's why you are not hitting this.

David


  reply	other threads:[~2015-03-20 22:49 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 15:07 4.0.0-rc4: panic in free_block David Ahern
2015-03-20 15:07 ` David Ahern
2015-03-20 16:48 ` Linus Torvalds
2015-03-20 16:48   ` Linus Torvalds
2015-03-20 16:48   ` Linus Torvalds
2015-03-20 16:53   ` David Ahern
2015-03-20 16:53     ` David Ahern
2015-03-20 16:53     ` David Ahern
2015-03-20 16:58     ` Linus Torvalds
2015-03-20 16:58       ` Linus Torvalds
2015-03-20 16:58       ` Linus Torvalds
2015-03-20 18:05       ` David Ahern
2015-03-20 18:05         ` David Ahern
2015-03-20 18:05         ` David Ahern
2015-03-20 18:53         ` Linus Torvalds
2015-03-20 18:53           ` Linus Torvalds
2015-03-20 18:53           ` Linus Torvalds
2015-03-20 19:04           ` David Ahern
2015-03-20 19:04             ` David Ahern
2015-03-20 19:04             ` David Ahern
2015-03-20 19:47         ` David Miller
2015-03-20 19:47           ` David Miller
2015-03-20 19:47           ` David Miller
2015-03-20 19:54           ` David Ahern
2015-03-20 19:54             ` David Ahern
2015-03-20 19:54             ` David Ahern
2015-03-20 20:19             ` David Miller
2015-03-20 20:19               ` David Miller
2015-03-20 20:19               ` David Miller
2015-03-20 19:42       ` David Miller
2015-03-20 19:42         ` David Miller
2015-03-20 19:42         ` David Miller
2015-03-20 20:01       ` Dave Hansen
2015-03-20 20:01         ` Dave Hansen
2015-03-20 20:01         ` Dave Hansen
2015-03-20 21:17 ` Linus Torvalds
2015-03-20 21:17   ` Linus Torvalds
2015-03-20 22:49   ` David Ahern [this message]
2015-03-20 22:49     ` David Ahern
2015-03-21  0:18     ` David Ahern
2015-03-21  0:18       ` David Ahern
2015-03-21  0:34       ` David Rientjes
2015-03-21  0:34         ` David Rientjes
2015-03-21  0:39         ` David Ahern
2015-03-21  0:39           ` David Ahern
2015-03-21  0:47       ` Linus Torvalds
2015-03-21  0:47         ` Linus Torvalds
2015-03-21 17:45         ` David Ahern
2015-03-21 17:45           ` David Ahern
2015-03-21 18:49           ` Linus Torvalds
2015-03-21 18:49             ` Linus Torvalds
2015-03-21 18:49             ` Linus Torvalds
2015-03-22 17:36             ` David Miller
2015-03-22 17:36               ` David Miller
2015-03-22 17:36               ` David Miller
2015-03-22 19:25               ` Bob Picco
2015-03-22 19:25                 ` Bob Picco
2015-03-22 19:25                 ` Bob Picco
2015-03-22 19:47               ` Linus Torvalds
2015-03-22 19:47                 ` Linus Torvalds
2015-03-22 19:47                 ` Linus Torvalds
2015-03-22 22:23                 ` David Miller
2015-03-22 22:23                   ` David Miller
2015-03-22 22:23                   ` David Miller
2015-03-22 23:35                   ` David Ahern
2015-03-22 23:35                     ` David Ahern
2015-03-22 23:35                     ` David Ahern
2015-03-22 23:54                     ` David Miller
2015-03-22 23:54                       ` David Miller
2015-03-22 23:54                       ` David Miller
2015-03-23  0:03                       ` David Ahern
2015-03-23  0:03                         ` David Ahern
2015-03-23  0:03                         ` David Ahern
2015-03-23  2:00                         ` David Miller
2015-03-23  2:00                           ` David Miller
2015-03-23  2:00                           ` David Miller
2015-03-23  2:19                           ` David Miller
2015-03-23  2:19                             ` David Miller
2015-03-23  2:19                             ` David Miller
2015-03-23 16:25                             ` David Miller
2015-03-23 16:25                               ` David Miller
2015-03-23 16:25                               ` David Miller
2015-03-23 16:51                               ` John Stoffel
2015-03-23 16:51                                 ` John Stoffel
2015-03-23 16:51                                 ` John Stoffel
2015-03-23 19:16                                 ` David Miller
2015-03-23 19:16                                   ` David Miller
2015-03-23 19:16                                   ` David Miller
2015-03-23 19:56                                   ` John Stoffel
2015-03-23 19:56                                     ` John Stoffel
2015-03-23 19:56                                     ` John Stoffel
2015-03-23 20:08                                     ` David Miller
2015-03-23 20:08                                       ` David Miller
2015-03-23 20:08                                       ` David Miller
2015-03-23 17:00                               ` Linus Torvalds
2015-03-23 17:00                                 ` Linus Torvalds
2015-03-23 17:00                                 ` Linus Torvalds
2015-03-23 19:08                                 ` David Miller
2015-03-23 19:08                                   ` David Miller
2015-03-23 19:08                                   ` David Miller
2015-03-23 19:47                                   ` Linus Torvalds
2015-03-23 19:47                                     ` Linus Torvalds
2015-03-23 19:47                                     ` Linus Torvalds
2015-03-23 19:52                                     ` David Miller
2015-03-23 19:52                                       ` David Miller
2015-03-23 19:52                                       ` David Miller
2015-03-23 17:34                               ` David Ahern
2015-03-23 17:34                                 ` David Ahern
2015-03-23 17:34                                 ` David Ahern
2015-03-23 19:35                                 ` David Miller
2015-03-23 19:35                                   ` David Miller
2015-03-23 19:35                                   ` David Miller
2015-03-23 19:58                                   ` David Ahern
2015-03-23 19:58                                     ` David Ahern
2015-03-23 19:58                                     ` David Ahern
2015-03-24  1:01                                   ` David Ahern
2015-03-24  1:01                                     ` David Ahern
2015-03-24  1:01                                     ` David Ahern
2015-03-24 14:57                               ` Bob Picco
2015-03-24 14:57                                 ` Bob Picco
2015-03-24 14:57                                 ` Bob Picco
2015-03-24 16:05                                 ` David Miller
2015-03-24 16:05                                   ` David Miller
2015-03-24 16:05                                   ` David Miller
2015-03-22 23:49                   ` Linus Torvalds
2015-03-22 23:49                     ` Linus Torvalds
2015-03-22 23:49                     ` Linus Torvalds
2015-03-22 23:57                     ` David Miller
2015-03-22 23:57                       ` David Miller
2015-03-22 23:57                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550CA3F9.9040201@oracle.com \
    --to=david.ahern@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.