All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <david.ahern@oracle.com>
To: David Miller <davem@davemloft.net>, torvalds@linux-foundation.org
Cc: sparclinux@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Bob Picco <bpicco@meloft.net>
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Sun, 22 Mar 2015 23:35:49 +0000	[thread overview]
Message-ID: <550F51D5.2010804@oracle.com> (raw)
In-Reply-To: <20150322.182311.109269221031797359.davem@davemloft.net>

On 3/22/15 4:23 PM, David Miller wrote:
>> I don't even know which version of memcpy ends up being used on M7.
>> Some of them do things like use VIS. I can follow some regular sparc
>> asm, there's no way I'm even *looking* at that. Is it really ok to use
>> VIS registers in random contexts?
>
> Yes, using VIS how we do is alright, and in fact I did an audit of
> this about 1 year ago.  This is another one of those "if this is
> wrong, so much stuff would break"
>
> The only thing funny some of these routines do is fetch 2 64-byte
> blocks of data ahead in the inner loops, but that should be fine
> right?
>
> On the M7 we'll use the Niagara-4 memcpy.
>
> Hmmm... I'll run this silly sparc kernel memmove through the glibc
> testsuite and see if it barfs.
>

I don't know if you caught Bob's message; he has a hack to bypass memcpy 
and memmove in mm/slab.c use a for loop to move entries. With the hack 
he is not seeing the problem.

This is the hack:

+static void move_entries(void *dest, void *src, int nr)
+{
+       unsigned long *dp = dest;
+       unsigned long *sp = src;
+
+       for (; nr; nr--, dp++, sp++)
+               *dp = *sp;
+}
+

and then replace the mempy and memmove calls in transfer_objects, 
cache_flusharray and drain_array to use move_entries.

I just put it on 4.0.0-rc4 and ditto -- problem goes away, so it clearly 
suggests the memcpy or memmove are the root cause.

David


WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <david.ahern@oracle.com>
To: David Miller <davem@davemloft.net>, torvalds@linux-foundation.org
Cc: sparclinux@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Bob Picco <bpicco@meloft.net>
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Sun, 22 Mar 2015 17:35:49 -0600	[thread overview]
Message-ID: <550F51D5.2010804@oracle.com> (raw)
In-Reply-To: <20150322.182311.109269221031797359.davem@davemloft.net>

On 3/22/15 4:23 PM, David Miller wrote:
>> I don't even know which version of memcpy ends up being used on M7.
>> Some of them do things like use VIS. I can follow some regular sparc
>> asm, there's no way I'm even *looking* at that. Is it really ok to use
>> VIS registers in random contexts?
>
> Yes, using VIS how we do is alright, and in fact I did an audit of
> this about 1 year ago.  This is another one of those "if this is
> wrong, so much stuff would break"
>
> The only thing funny some of these routines do is fetch 2 64-byte
> blocks of data ahead in the inner loops, but that should be fine
> right?
>
> On the M7 we'll use the Niagara-4 memcpy.
>
> Hmmm... I'll run this silly sparc kernel memmove through the glibc
> testsuite and see if it barfs.
>

I don't know if you caught Bob's message; he has a hack to bypass memcpy 
and memmove in mm/slab.c use a for loop to move entries. With the hack 
he is not seeing the problem.

This is the hack:

+static void move_entries(void *dest, void *src, int nr)
+{
+       unsigned long *dp = dest;
+       unsigned long *sp = src;
+
+       for (; nr; nr--, dp++, sp++)
+               *dp = *sp;
+}
+

and then replace the mempy and memmove calls in transfer_objects, 
cache_flusharray and drain_array to use move_entries.

I just put it on 4.0.0-rc4 and ditto -- problem goes away, so it clearly 
suggests the memcpy or memmove are the root cause.

David

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <david.ahern@oracle.com>
To: David Miller <davem@davemloft.net>, torvalds@linux-foundation.org
Cc: sparclinux@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Bob Picco <bpicco@meloft.net>
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Sun, 22 Mar 2015 17:35:49 -0600	[thread overview]
Message-ID: <550F51D5.2010804@oracle.com> (raw)
In-Reply-To: <20150322.182311.109269221031797359.davem@davemloft.net>

On 3/22/15 4:23 PM, David Miller wrote:
>> I don't even know which version of memcpy ends up being used on M7.
>> Some of them do things like use VIS. I can follow some regular sparc
>> asm, there's no way I'm even *looking* at that. Is it really ok to use
>> VIS registers in random contexts?
>
> Yes, using VIS how we do is alright, and in fact I did an audit of
> this about 1 year ago.  This is another one of those "if this is
> wrong, so much stuff would break"
>
> The only thing funny some of these routines do is fetch 2 64-byte
> blocks of data ahead in the inner loops, but that should be fine
> right?
>
> On the M7 we'll use the Niagara-4 memcpy.
>
> Hmmm... I'll run this silly sparc kernel memmove through the glibc
> testsuite and see if it barfs.
>

I don't know if you caught Bob's message; he has a hack to bypass memcpy 
and memmove in mm/slab.c use a for loop to move entries. With the hack 
he is not seeing the problem.

This is the hack:

+static void move_entries(void *dest, void *src, int nr)
+{
+       unsigned long *dp = dest;
+       unsigned long *sp = src;
+
+       for (; nr; nr--, dp++, sp++)
+               *dp = *sp;
+}
+

and then replace the mempy and memmove calls in transfer_objects, 
cache_flusharray and drain_array to use move_entries.

I just put it on 4.0.0-rc4 and ditto -- problem goes away, so it clearly 
suggests the memcpy or memmove are the root cause.

David


  reply	other threads:[~2015-03-22 23:35 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 15:07 4.0.0-rc4: panic in free_block David Ahern
2015-03-20 15:07 ` David Ahern
2015-03-20 16:48 ` Linus Torvalds
2015-03-20 16:48   ` Linus Torvalds
2015-03-20 16:48   ` Linus Torvalds
2015-03-20 16:53   ` David Ahern
2015-03-20 16:53     ` David Ahern
2015-03-20 16:53     ` David Ahern
2015-03-20 16:58     ` Linus Torvalds
2015-03-20 16:58       ` Linus Torvalds
2015-03-20 16:58       ` Linus Torvalds
2015-03-20 18:05       ` David Ahern
2015-03-20 18:05         ` David Ahern
2015-03-20 18:05         ` David Ahern
2015-03-20 18:53         ` Linus Torvalds
2015-03-20 18:53           ` Linus Torvalds
2015-03-20 18:53           ` Linus Torvalds
2015-03-20 19:04           ` David Ahern
2015-03-20 19:04             ` David Ahern
2015-03-20 19:04             ` David Ahern
2015-03-20 19:47         ` David Miller
2015-03-20 19:47           ` David Miller
2015-03-20 19:47           ` David Miller
2015-03-20 19:54           ` David Ahern
2015-03-20 19:54             ` David Ahern
2015-03-20 19:54             ` David Ahern
2015-03-20 20:19             ` David Miller
2015-03-20 20:19               ` David Miller
2015-03-20 20:19               ` David Miller
2015-03-20 19:42       ` David Miller
2015-03-20 19:42         ` David Miller
2015-03-20 19:42         ` David Miller
2015-03-20 20:01       ` Dave Hansen
2015-03-20 20:01         ` Dave Hansen
2015-03-20 20:01         ` Dave Hansen
2015-03-20 21:17 ` Linus Torvalds
2015-03-20 21:17   ` Linus Torvalds
2015-03-20 22:49   ` David Ahern
2015-03-20 22:49     ` David Ahern
2015-03-21  0:18     ` David Ahern
2015-03-21  0:18       ` David Ahern
2015-03-21  0:34       ` David Rientjes
2015-03-21  0:34         ` David Rientjes
2015-03-21  0:39         ` David Ahern
2015-03-21  0:39           ` David Ahern
2015-03-21  0:47       ` Linus Torvalds
2015-03-21  0:47         ` Linus Torvalds
2015-03-21 17:45         ` David Ahern
2015-03-21 17:45           ` David Ahern
2015-03-21 18:49           ` Linus Torvalds
2015-03-21 18:49             ` Linus Torvalds
2015-03-21 18:49             ` Linus Torvalds
2015-03-22 17:36             ` David Miller
2015-03-22 17:36               ` David Miller
2015-03-22 17:36               ` David Miller
2015-03-22 19:25               ` Bob Picco
2015-03-22 19:25                 ` Bob Picco
2015-03-22 19:25                 ` Bob Picco
2015-03-22 19:47               ` Linus Torvalds
2015-03-22 19:47                 ` Linus Torvalds
2015-03-22 19:47                 ` Linus Torvalds
2015-03-22 22:23                 ` David Miller
2015-03-22 22:23                   ` David Miller
2015-03-22 22:23                   ` David Miller
2015-03-22 23:35                   ` David Ahern [this message]
2015-03-22 23:35                     ` David Ahern
2015-03-22 23:35                     ` David Ahern
2015-03-22 23:54                     ` David Miller
2015-03-22 23:54                       ` David Miller
2015-03-22 23:54                       ` David Miller
2015-03-23  0:03                       ` David Ahern
2015-03-23  0:03                         ` David Ahern
2015-03-23  0:03                         ` David Ahern
2015-03-23  2:00                         ` David Miller
2015-03-23  2:00                           ` David Miller
2015-03-23  2:00                           ` David Miller
2015-03-23  2:19                           ` David Miller
2015-03-23  2:19                             ` David Miller
2015-03-23  2:19                             ` David Miller
2015-03-23 16:25                             ` David Miller
2015-03-23 16:25                               ` David Miller
2015-03-23 16:25                               ` David Miller
2015-03-23 16:51                               ` John Stoffel
2015-03-23 16:51                                 ` John Stoffel
2015-03-23 16:51                                 ` John Stoffel
2015-03-23 19:16                                 ` David Miller
2015-03-23 19:16                                   ` David Miller
2015-03-23 19:16                                   ` David Miller
2015-03-23 19:56                                   ` John Stoffel
2015-03-23 19:56                                     ` John Stoffel
2015-03-23 19:56                                     ` John Stoffel
2015-03-23 20:08                                     ` David Miller
2015-03-23 20:08                                       ` David Miller
2015-03-23 20:08                                       ` David Miller
2015-03-23 17:00                               ` Linus Torvalds
2015-03-23 17:00                                 ` Linus Torvalds
2015-03-23 17:00                                 ` Linus Torvalds
2015-03-23 19:08                                 ` David Miller
2015-03-23 19:08                                   ` David Miller
2015-03-23 19:08                                   ` David Miller
2015-03-23 19:47                                   ` Linus Torvalds
2015-03-23 19:47                                     ` Linus Torvalds
2015-03-23 19:47                                     ` Linus Torvalds
2015-03-23 19:52                                     ` David Miller
2015-03-23 19:52                                       ` David Miller
2015-03-23 19:52                                       ` David Miller
2015-03-23 17:34                               ` David Ahern
2015-03-23 17:34                                 ` David Ahern
2015-03-23 17:34                                 ` David Ahern
2015-03-23 19:35                                 ` David Miller
2015-03-23 19:35                                   ` David Miller
2015-03-23 19:35                                   ` David Miller
2015-03-23 19:58                                   ` David Ahern
2015-03-23 19:58                                     ` David Ahern
2015-03-23 19:58                                     ` David Ahern
2015-03-24  1:01                                   ` David Ahern
2015-03-24  1:01                                     ` David Ahern
2015-03-24  1:01                                     ` David Ahern
2015-03-24 14:57                               ` Bob Picco
2015-03-24 14:57                                 ` Bob Picco
2015-03-24 14:57                                 ` Bob Picco
2015-03-24 16:05                                 ` David Miller
2015-03-24 16:05                                   ` David Miller
2015-03-24 16:05                                   ` David Miller
2015-03-22 23:49                   ` Linus Torvalds
2015-03-22 23:49                     ` Linus Torvalds
2015-03-22 23:49                     ` Linus Torvalds
2015-03-22 23:57                     ` David Miller
2015-03-22 23:57                       ` David Miller
2015-03-22 23:57                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550F51D5.2010804@oracle.com \
    --to=david.ahern@oracle.com \
    --cc=bpicco@meloft.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.