All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <david.ahern@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Sat, 21 Mar 2015 11:45:07 -0600	[thread overview]
Message-ID: <550DAE23.7030000@oracle.com> (raw)
In-Reply-To: <CA+55aFwyuVWHMq_oc_hfwWcu6RaPGSifXD9-adX2_TOa-L+PHA@mail.gmail.com>

On 3/20/15 6:47 PM, Linus Torvalds wrote:
>
>> Here's another data point: If I disable NUMA I don't see the problem.
>> Performance drops, but no NULL pointer splats which would have been panics.
>
> So the NUMA case triggers the per-node "n->shared" logic, which
> *should* be protected by "n->list_lock". Maybe there is some bug there
> - but since that code seems to do ok on x86-64 (and apparently older
> sparc too), I really would look at arch-specific issues first.

You raise a lot of valid questions and something to look into. But if 
the root cause were such a fundamental issue (CPU memory ordering, 
compiler bug, etc) why would it only occur on this one code path -- free 
with SLAB and NUMA -- and so consistently?

Continuing to poke around, but open to any suggestions. I have enabled 
every DEBUG I can find in the memory code and nothing is popping out. In 
terms of races wouldn't all the DEBUG checks affect timing? Yet, I am 
still seeing the same stack traces due to the same root cause.

David

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <david.ahern@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 4.0.0-rc4: panic in free_block
Date: Sat, 21 Mar 2015 11:45:07 -0600	[thread overview]
Message-ID: <550DAE23.7030000@oracle.com> (raw)
In-Reply-To: <CA+55aFwyuVWHMq_oc_hfwWcu6RaPGSifXD9-adX2_TOa-L+PHA@mail.gmail.com>

On 3/20/15 6:47 PM, Linus Torvalds wrote:
>
>> Here's another data point: If I disable NUMA I don't see the problem.
>> Performance drops, but no NULL pointer splats which would have been panics.
>
> So the NUMA case triggers the per-node "n->shared" logic, which
> *should* be protected by "n->list_lock". Maybe there is some bug there
> - but since that code seems to do ok on x86-64 (and apparently older
> sparc too), I really would look at arch-specific issues first.

You raise a lot of valid questions and something to look into. But if 
the root cause were such a fundamental issue (CPU memory ordering, 
compiler bug, etc) why would it only occur on this one code path -- free 
with SLAB and NUMA -- and so consistently?

Continuing to poke around, but open to any suggestions. I have enabled 
every DEBUG I can find in the memory code and nothing is popping out. In 
terms of races wouldn't all the DEBUG checks affect timing? Yet, I am 
still seeing the same stack traces due to the same root cause.

David

  reply	other threads:[~2015-03-21 17:45 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 15:07 4.0.0-rc4: panic in free_block David Ahern
2015-03-20 15:07 ` David Ahern
2015-03-20 16:48 ` Linus Torvalds
2015-03-20 16:48   ` Linus Torvalds
2015-03-20 16:48   ` Linus Torvalds
2015-03-20 16:53   ` David Ahern
2015-03-20 16:53     ` David Ahern
2015-03-20 16:53     ` David Ahern
2015-03-20 16:58     ` Linus Torvalds
2015-03-20 16:58       ` Linus Torvalds
2015-03-20 16:58       ` Linus Torvalds
2015-03-20 18:05       ` David Ahern
2015-03-20 18:05         ` David Ahern
2015-03-20 18:05         ` David Ahern
2015-03-20 18:53         ` Linus Torvalds
2015-03-20 18:53           ` Linus Torvalds
2015-03-20 18:53           ` Linus Torvalds
2015-03-20 19:04           ` David Ahern
2015-03-20 19:04             ` David Ahern
2015-03-20 19:04             ` David Ahern
2015-03-20 19:47         ` David Miller
2015-03-20 19:47           ` David Miller
2015-03-20 19:47           ` David Miller
2015-03-20 19:54           ` David Ahern
2015-03-20 19:54             ` David Ahern
2015-03-20 19:54             ` David Ahern
2015-03-20 20:19             ` David Miller
2015-03-20 20:19               ` David Miller
2015-03-20 20:19               ` David Miller
2015-03-20 19:42       ` David Miller
2015-03-20 19:42         ` David Miller
2015-03-20 19:42         ` David Miller
2015-03-20 20:01       ` Dave Hansen
2015-03-20 20:01         ` Dave Hansen
2015-03-20 20:01         ` Dave Hansen
2015-03-20 21:17 ` Linus Torvalds
2015-03-20 21:17   ` Linus Torvalds
2015-03-20 22:49   ` David Ahern
2015-03-20 22:49     ` David Ahern
2015-03-21  0:18     ` David Ahern
2015-03-21  0:18       ` David Ahern
2015-03-21  0:34       ` David Rientjes
2015-03-21  0:34         ` David Rientjes
2015-03-21  0:39         ` David Ahern
2015-03-21  0:39           ` David Ahern
2015-03-21  0:47       ` Linus Torvalds
2015-03-21  0:47         ` Linus Torvalds
2015-03-21 17:45         ` David Ahern [this message]
2015-03-21 17:45           ` David Ahern
2015-03-21 18:49           ` Linus Torvalds
2015-03-21 18:49             ` Linus Torvalds
2015-03-21 18:49             ` Linus Torvalds
2015-03-22 17:36             ` David Miller
2015-03-22 17:36               ` David Miller
2015-03-22 17:36               ` David Miller
2015-03-22 19:25               ` Bob Picco
2015-03-22 19:25                 ` Bob Picco
2015-03-22 19:25                 ` Bob Picco
2015-03-22 19:47               ` Linus Torvalds
2015-03-22 19:47                 ` Linus Torvalds
2015-03-22 19:47                 ` Linus Torvalds
2015-03-22 22:23                 ` David Miller
2015-03-22 22:23                   ` David Miller
2015-03-22 22:23                   ` David Miller
2015-03-22 23:35                   ` David Ahern
2015-03-22 23:35                     ` David Ahern
2015-03-22 23:35                     ` David Ahern
2015-03-22 23:54                     ` David Miller
2015-03-22 23:54                       ` David Miller
2015-03-22 23:54                       ` David Miller
2015-03-23  0:03                       ` David Ahern
2015-03-23  0:03                         ` David Ahern
2015-03-23  0:03                         ` David Ahern
2015-03-23  2:00                         ` David Miller
2015-03-23  2:00                           ` David Miller
2015-03-23  2:00                           ` David Miller
2015-03-23  2:19                           ` David Miller
2015-03-23  2:19                             ` David Miller
2015-03-23  2:19                             ` David Miller
2015-03-23 16:25                             ` David Miller
2015-03-23 16:25                               ` David Miller
2015-03-23 16:25                               ` David Miller
2015-03-23 16:51                               ` John Stoffel
2015-03-23 16:51                                 ` John Stoffel
2015-03-23 16:51                                 ` John Stoffel
2015-03-23 19:16                                 ` David Miller
2015-03-23 19:16                                   ` David Miller
2015-03-23 19:16                                   ` David Miller
2015-03-23 19:56                                   ` John Stoffel
2015-03-23 19:56                                     ` John Stoffel
2015-03-23 19:56                                     ` John Stoffel
2015-03-23 20:08                                     ` David Miller
2015-03-23 20:08                                       ` David Miller
2015-03-23 20:08                                       ` David Miller
2015-03-23 17:00                               ` Linus Torvalds
2015-03-23 17:00                                 ` Linus Torvalds
2015-03-23 17:00                                 ` Linus Torvalds
2015-03-23 19:08                                 ` David Miller
2015-03-23 19:08                                   ` David Miller
2015-03-23 19:08                                   ` David Miller
2015-03-23 19:47                                   ` Linus Torvalds
2015-03-23 19:47                                     ` Linus Torvalds
2015-03-23 19:47                                     ` Linus Torvalds
2015-03-23 19:52                                     ` David Miller
2015-03-23 19:52                                       ` David Miller
2015-03-23 19:52                                       ` David Miller
2015-03-23 17:34                               ` David Ahern
2015-03-23 17:34                                 ` David Ahern
2015-03-23 17:34                                 ` David Ahern
2015-03-23 19:35                                 ` David Miller
2015-03-23 19:35                                   ` David Miller
2015-03-23 19:35                                   ` David Miller
2015-03-23 19:58                                   ` David Ahern
2015-03-23 19:58                                     ` David Ahern
2015-03-23 19:58                                     ` David Ahern
2015-03-24  1:01                                   ` David Ahern
2015-03-24  1:01                                     ` David Ahern
2015-03-24  1:01                                     ` David Ahern
2015-03-24 14:57                               ` Bob Picco
2015-03-24 14:57                                 ` Bob Picco
2015-03-24 14:57                                 ` Bob Picco
2015-03-24 16:05                                 ` David Miller
2015-03-24 16:05                                   ` David Miller
2015-03-24 16:05                                   ` David Miller
2015-03-22 23:49                   ` Linus Torvalds
2015-03-22 23:49                     ` Linus Torvalds
2015-03-22 23:49                     ` Linus Torvalds
2015-03-22 23:57                     ` David Miller
2015-03-22 23:57                       ` David Miller
2015-03-22 23:57                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550DAE23.7030000@oracle.com \
    --to=david.ahern@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.