* [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
@ 2015-04-17 17:23 Vinod Koul
2015-04-17 17:23 ` [PATCH 2/2] ASoC: intel " Vinod Koul
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Vinod Koul @ 2015-04-17 17:23 UTC (permalink / raw)
To: alsa-devel; +Cc: liam.r.girdwood, tiwai, broonie, Vinod Koul
we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
this define instead of numeric value
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
include/uapi/sound/asound.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
index 46145a5277fe..a45be6bdcf5b 100644
--- a/include/uapi/sound/asound.h
+++ b/include/uapi/sound/asound.h
@@ -864,7 +864,7 @@ struct snd_ctl_elem_id {
snd_ctl_elem_iface_t iface; /* interface identifier */
unsigned int device; /* device/client number */
unsigned int subdevice; /* subdevice (substream) number */
- unsigned char name[44]; /* ASCII name of item */
+ unsigned char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; /* ASCII name of item */
unsigned int index; /* index of item */
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/2] ASoC: intel - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-17 17:23 [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN Vinod Koul
@ 2015-04-17 17:23 ` Vinod Koul
2015-04-18 7:03 ` Takashi Iwai
2015-04-18 11:59 ` Mark Brown
2015-04-18 7:02 ` [PATCH 1/2] ALSA: asound.h " Takashi Iwai
2015-04-19 4:55 ` Takashi Sakamoto
2 siblings, 2 replies; 9+ messages in thread
From: Vinod Koul @ 2015-04-17 17:23 UTC (permalink / raw)
To: alsa-devel; +Cc: liam.r.girdwood, tiwai, broonie, Vinod Koul
we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
this define instead of numeric value
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/intel/atom/sst-atom-controls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst-atom-controls.h b/sound/soc/intel/atom/sst-atom-controls.h
index daecc58f28af..c55f76a535b3 100644
--- a/sound/soc/intel/atom/sst-atom-controls.h
+++ b/sound/soc/intel/atom/sst-atom-controls.h
@@ -695,7 +695,7 @@ struct sst_gain_mixer_control {
u16 module_id;
u16 pipe_id;
u16 task_id;
- char pname[44];
+ char pname[SNDRV_CTL_ELEM_ID_NAME_MAXLEN];
struct snd_soc_dapm_widget *w;
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] ASoC: intel - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-17 17:23 ` [PATCH 2/2] ASoC: intel " Vinod Koul
@ 2015-04-18 7:03 ` Takashi Iwai
2015-04-18 11:59 ` Mark Brown
1 sibling, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2015-04-18 7:03 UTC (permalink / raw)
To: Vinod Koul; +Cc: liam.r.girdwood, alsa-devel, broonie
At Fri, 17 Apr 2015 22:53:33 +0530,
Vinod Koul wrote:
>
> we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
> this define instead of numeric value
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
I leave this to Mark.
thanks,
Takashi
> ---
> sound/soc/intel/atom/sst-atom-controls.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst-atom-controls.h b/sound/soc/intel/atom/sst-atom-controls.h
> index daecc58f28af..c55f76a535b3 100644
> --- a/sound/soc/intel/atom/sst-atom-controls.h
> +++ b/sound/soc/intel/atom/sst-atom-controls.h
> @@ -695,7 +695,7 @@ struct sst_gain_mixer_control {
> u16 module_id;
> u16 pipe_id;
> u16 task_id;
> - char pname[44];
> + char pname[SNDRV_CTL_ELEM_ID_NAME_MAXLEN];
> struct snd_soc_dapm_widget *w;
> };
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] ASoC: intel - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-17 17:23 ` [PATCH 2/2] ASoC: intel " Vinod Koul
2015-04-18 7:03 ` Takashi Iwai
@ 2015-04-18 11:59 ` Mark Brown
1 sibling, 0 replies; 9+ messages in thread
From: Mark Brown @ 2015-04-18 11:59 UTC (permalink / raw)
To: Vinod Koul; +Cc: liam.r.girdwood, tiwai, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 194 bytes --]
On Fri, Apr 17, 2015 at 10:53:33PM +0530, Vinod Koul wrote:
> we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
> this define instead of numeric value
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-17 17:23 [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN Vinod Koul
2015-04-17 17:23 ` [PATCH 2/2] ASoC: intel " Vinod Koul
@ 2015-04-18 7:02 ` Takashi Iwai
2015-04-19 4:55 ` Takashi Sakamoto
2 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2015-04-18 7:02 UTC (permalink / raw)
To: Vinod Koul; +Cc: liam.r.girdwood, alsa-devel, broonie
At Fri, 17 Apr 2015 22:53:32 +0530,
Vinod Koul wrote:
>
> we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
> this define instead of numeric value
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Applied, thanks.
Takashi
> ---
> include/uapi/sound/asound.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index 46145a5277fe..a45be6bdcf5b 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -864,7 +864,7 @@ struct snd_ctl_elem_id {
> snd_ctl_elem_iface_t iface; /* interface identifier */
> unsigned int device; /* device/client number */
> unsigned int subdevice; /* subdevice (substream) number */
> - unsigned char name[44]; /* ASCII name of item */
> + unsigned char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; /* ASCII name of item */
> unsigned int index; /* index of item */
> };
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-17 17:23 [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN Vinod Koul
2015-04-17 17:23 ` [PATCH 2/2] ASoC: intel " Vinod Koul
2015-04-18 7:02 ` [PATCH 1/2] ALSA: asound.h " Takashi Iwai
@ 2015-04-19 4:55 ` Takashi Sakamoto
2015-04-21 10:52 ` Takashi Iwai
2 siblings, 1 reply; 9+ messages in thread
From: Takashi Sakamoto @ 2015-04-19 4:55 UTC (permalink / raw)
To: Vinod Koul, alsa-devel; +Cc: liam.r.girdwood, tiwai, broonie
On Apr 18 2015 02:23, Vinod Koul wrote:
> we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
> this define instead of numeric value
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> include/uapi/sound/asound.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index 46145a5277fe..a45be6bdcf5b 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -864,7 +864,7 @@ struct snd_ctl_elem_id {
> snd_ctl_elem_iface_t iface; /* interface identifier */
> unsigned int device; /* device/client number */
> unsigned int subdevice; /* subdevice (substream) number */
> - unsigned char name[44]; /* ASCII name of item */
> + unsigned char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; /* ASCII name of item */
> unsigned int index; /* index of item */
> };
I think it better to post the same patch to alsa-lib when you add some
changes to ALSA uapi headers because alsa-lib should also have the same
headers.
# I also realized that recent timestamping improvements are not still
# included in alsa-lib header.
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-19 4:55 ` Takashi Sakamoto
@ 2015-04-21 10:52 ` Takashi Iwai
2015-04-21 14:46 ` Pierre-Louis Bossart
0 siblings, 1 reply; 9+ messages in thread
From: Takashi Iwai @ 2015-04-21 10:52 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: Vinod Koul, liam.r.girdwood, alsa-devel, broonie,
Pierre-Louis Bossart
At Sun, 19 Apr 2015 13:55:46 +0900,
Takashi Sakamoto wrote:
>
> On Apr 18 2015 02:23, Vinod Koul wrote:
> > we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
> > this define instead of numeric value
> >
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> > include/uapi/sound/asound.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> > index 46145a5277fe..a45be6bdcf5b 100644
> > --- a/include/uapi/sound/asound.h
> > +++ b/include/uapi/sound/asound.h
> > @@ -864,7 +864,7 @@ struct snd_ctl_elem_id {
> > snd_ctl_elem_iface_t iface; /* interface identifier */
> > unsigned int device; /* device/client number */
> > unsigned int subdevice; /* subdevice (substream) number */
> > - unsigned char name[44]; /* ASCII name of item */
> > + unsigned char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; /* ASCII name of item */
> > unsigned int index; /* index of item */
> > };
>
> I think it better to post the same patch to alsa-lib when you add some
> changes to ALSA uapi headers because alsa-lib should also have the same
> headers.
Right. I copied the file and updated alsa-lib side now.
> # I also realized that recent timestamping improvements are not still
> # included in alsa-lib header.
Yeah, that stuff seems forgotten.
Pierre, could you respin your patches for review?
thanks,
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-21 10:52 ` Takashi Iwai
@ 2015-04-21 14:46 ` Pierre-Louis Bossart
2015-04-21 14:49 ` Takashi Iwai
0 siblings, 1 reply; 9+ messages in thread
From: Pierre-Louis Bossart @ 2015-04-21 14:46 UTC (permalink / raw)
To: Takashi Iwai, Takashi Sakamoto
Cc: Vinod Koul, liam.r.girdwood, alsa-devel, broonie
>> # I also realized that recent timestamping improvements are not still
>> # included in alsa-lib header.
>
> Yeah, that stuff seems forgotten.
>
> Pierre, could you respin your patches for review?
will do later this week. alsa-lib only, right?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
2015-04-21 14:46 ` Pierre-Louis Bossart
@ 2015-04-21 14:49 ` Takashi Iwai
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2015-04-21 14:49 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Vinod Koul, liam.r.girdwood, alsa-devel, broonie,
Takashi Sakamoto
At Tue, 21 Apr 2015 07:46:48 -0700,
Pierre-Louis Bossart wrote:
>
>
> >> # I also realized that recent timestamping improvements are not still
> >> # included in alsa-lib header.
> >
> > Yeah, that stuff seems forgotten.
> >
> > Pierre, could you respin your patches for review?
>
> will do later this week. alsa-lib only, right?
Yes, the kernel part has been already merged.
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-04-21 14:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-17 17:23 [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN Vinod Koul
2015-04-17 17:23 ` [PATCH 2/2] ASoC: intel " Vinod Koul
2015-04-18 7:03 ` Takashi Iwai
2015-04-18 11:59 ` Mark Brown
2015-04-18 7:02 ` [PATCH 1/2] ALSA: asound.h " Takashi Iwai
2015-04-19 4:55 ` Takashi Sakamoto
2015-04-21 10:52 ` Takashi Iwai
2015-04-21 14:46 ` Pierre-Louis Bossart
2015-04-21 14:49 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.