From: Dave Hansen <dave.hansen@linux.intel.com>
To: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
tony.luck@intel.com, bp@alien8.de, jiang.liu@linux.intel.com,
yinghai@kernel.org
Cc: x86@kernel.org, dvlasenk@redhat.com, JBeulich@suse.com,
slaoub@gmail.com, luto@amacapital.net, oleg@redhat.com,
rostedt@goodmis.org, rusty@rustcorp.com.au, prarit@redhat.com,
linux@rasmusvillemoes.dk, jroedel@suse.de,
andriy.shevchenko@linux.intel.com, macro@linux-mips.org,
wangnan0@huawei.com, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 1/4] x86/mce: Define 'SUCCOR' cpuid bit
Date: Fri, 01 May 2015 08:09:40 -0700 [thread overview]
Message-ID: <55439734.1070709@linux.intel.com> (raw)
In-Reply-To: <1430405365-4473-2-git-send-email-Aravind.Gopalakrishnan@amd.com>
On 04/30/2015 07:49 AM, Aravind Gopalakrishnan wrote:
> @@ -1640,6 +1640,7 @@ static void __mcheck_cpu_init_vendor(struct cpuinfo_x86 *c)
> case X86_VENDOR_AMD:
> mce_amd_feature_init(c);
> mce_flags.overflow_recov = cpuid_ebx(0x80000007) & 0x1;
> + mce_flags.succor = (cpuid_ebx(0x80000007) & 0x2) ? 1 : 0;
> break;
> default:
> break;
Is there a reason to add the cpuid detection like this instead of adding
an X86_FEATURE_ for it and using cpu_has() and friends? Doing that
would also let you see the bit in /proc/cpuinfo.
next prev parent reply other threads:[~2015-05-01 15:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 14:49 [PATCH 0/4] Enable deferred error interrupts Aravind Gopalakrishnan
2015-04-30 14:49 ` [PATCH 1/4] x86/mce: Define 'SUCCOR' cpuid bit Aravind Gopalakrishnan
2015-05-01 10:25 ` Borislav Petkov
2015-05-01 14:54 ` Aravind Gopalakrishnan
2015-05-03 9:01 ` Borislav Petkov
2015-05-01 15:09 ` Dave Hansen [this message]
2015-05-01 16:20 ` Borislav Petkov
2015-04-30 14:49 ` [PATCH 2/4] x86/mce/amd: Introduce deferred error interrupt handler Aravind Gopalakrishnan
2015-04-30 20:41 ` Andy Lutomirski
2015-05-01 4:16 ` Aravind Gopalakrishnan
2015-05-01 9:36 ` Borislav Petkov
2015-05-01 14:50 ` Aravind Gopalakrishnan
2015-05-03 9:22 ` Borislav Petkov
2015-05-04 15:29 ` Aravind Gopalakrishnan
2015-05-04 15:46 ` Borislav Petkov
2015-05-04 17:08 ` Aravind Gopalakrishnan
2015-05-04 18:46 ` Borislav Petkov
2015-05-04 19:06 ` Aravind Gopalakrishnan
2015-05-04 19:14 ` Borislav Petkov
2015-05-05 18:39 ` Aravind Gopalakrishnan
2015-05-05 20:28 ` Luck, Tony
2015-05-05 20:33 ` Aravind Gopalakrishnan
2015-04-30 14:49 ` [PATCH 3/4] x86, irq: Cleanup ordering of vector numbers Aravind Gopalakrishnan
2015-04-30 14:49 ` [PATCH 4/4] x86/mce/amd: Rename setup_APIC_mce Aravind Gopalakrishnan
2015-05-01 7:18 ` [PATCH 0/4] Enable deferred error interrupts Ingo Molnar
2015-05-01 14:50 ` Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55439734.1070709@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=JBeulich@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=jroedel@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=macro@linux-mips.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=prarit@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=slaoub@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wangnan0@huawei.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.