Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem.

Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem.

[Andrei Borzenkov]

Could someone explain why this message is output here? It is absolutely
not what condition checks for

    if (ctx.container
        && grub_strcmp (ctx.container->partmap->name, "msdos") == 0
        && ctx.dest_partmap
        && (ctx.container->msdostype == GRUB_PC_PARTITION_TYPE_NETBSD
            || ctx.container->msdostype == GRUB_PC_PARTITION_TYPE_OPENBSD))
      {
        grub_util_warn ("%s", _("Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem.  This is not supported yet."));
        goto unable_to_embed;
      }

Condition checks whether we are installing on a netbsd or openbsd
partition with nested partition label. At this point we have really no
idea whether any filesystem is present (we check for it later). So
neither "multiple partition labels" nor "filesystem" appear to have
anything to do with this check.

Also it actually skips further sanity check for reserved sector in
nested partition label and jumps directly to embedding.

So it sounds like both error message is misleading and code is out of
place (it probably should be moved after reserved sector check).

Comments?

Re: Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem.

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1783 bytes --]

On 03.05.2015 10:21, Andrei Borzenkov wrote:
> Could someone explain why this message is output here? It is absolutely
> not what condition checks for
> 
>     if (ctx.container
>         && grub_strcmp (ctx.container->partmap->name, "msdos") == 0
>         && ctx.dest_partmap
>         && (ctx.container->msdostype == GRUB_PC_PARTITION_TYPE_NETBSD
>             || ctx.container->msdostype == GRUB_PC_PARTITION_TYPE_OPENBSD))
>       {
>         grub_util_warn ("%s", _("Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem.  This is not supported yet."));
>         goto unable_to_embed;
>       }
> 
> Condition checks whether we are installing on a netbsd or openbsd
> partition with nested partition label. At this point we have really no
> idea whether any filesystem is present (we check for it later). So
> neither "multiple partition labels" nor "filesystem" appear to have
> anything to do with this check.
> 
> Also it actually skips further sanity check for reserved sector in
> nested partition label and jumps directly to embedding.
> 
> So it sounds like both error message is misleading and code is out of
> place (it probably should be moved after reserved sector check).
> 
> Comments?
> 
It's just bad message. We need this special check because net- and
openbsd labels have metadata in the partition and we have no code
currently to avoid this metadata even if filesystem there could support
embedding. So perhaps something like
"Embedding into partitions with OpenBSD or NetBSD metadata is not
supported yet"
?
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

Re: Attempting to install GRUB to a disk with multiple partition labels or both partition label and filesystem.

[Sebastian Pipping]

Hi,


I think you may be looking for this commit:


$ git show -s 014b6806
commit 014b68068d4136812f2e3dc16c986351e6fb2779
Author: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Date:   Fri Jan 7 13:27:34 2011 +0100

        * util/grub-setup.c (setup): Handle NetBSD and OpenBSD disklabels.
        Reported and tested by: Grégoire Sutre.


That's where the code seems to originate from.

It doesn't answer your question yet, though.

Best,



Sebastian