All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner A33 DTSI
Date: Sun, 10 May 2015 11:54:33 +0200	[thread overview]
Message-ID: <554F2AD9.3030005@redhat.com> (raw)
In-Reply-To: <CAEzqOZv034sn-LVcYqrXWukdvcdm=BbVo7gMiYAy-dQG=mpQTw@mail.gmail.com>

Hi,

On 10-05-15 11:33, Vishnu Patekar wrote:
> Hi,
>
> On Sun, May 10, 2015 at 2:23 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>>
>> On 10-05-15 08:46, Vishnu Patekar wrote:
>>>
>>> this is based on common sun8i.dtsi patch.
>>> sun8i-a23.dtsi and sun8i-a33.dtsi are same, A33 specific features
>>> e.g. clocks can be added in future.
>>>
>>> Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com>
>>
>>
>> This seems to only contain stuff which can be shared with the a23 dts,
>> why is this not all in the common sun8i.dtsi ?
> Allwinner H3 is also sun8i, I've referred the referred the H3 dtsi
> patch sent by Jens Kuske.
> I've added common parts bet a23 and h3 in sun8i.dtsi.

Ah, I see, ok that works for me.

Regards,

Hans


>
> same note added in common sun8i PATCH 4, which I'm going to resend
> after your comment.
>
>>
>> Regards,
>>
>> Hans
>>
>>
>>> ---
>>>    arch/arm/boot/dts/sun8i-a33.dtsi | 217
>>> +++++++++++++++++++++++++++++++++++++++
>>>    1 file changed, 217 insertions(+)
>>>    create mode 100644 arch/arm/boot/dts/sun8i-a33.dtsi
>>>
>>> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi
>>> b/arch/arm/boot/dts/sun8i-a33.dtsi
>>> new file mode 100644
>>> index 0000000..32489fc
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi
>>> @@ -0,0 +1,217 @@
>>> +/*
>>> + * Copyright 2014 Chen-Yu Tsai
>>> + *
>>> + * Chen-Yu Tsai <wens@csie.org>
>>> + *
>>> + * This file is dual-licensed: you can use it either under the terms
>>> + * of the GPL or the X11 license, at your option. Note that this dual
>>> + * licensing only applies to this file, and not this project as a
>>> + * whole.
>>> + *
>>> + *  a) This file is free software; you can redistribute it and/or
>>> + *     modify it under the terms of the GNU General Public License as
>>> + *     published by the Free Software Foundation; either version 2 of the
>>> + *     License, or (at your option) any later version.
>>> + *
>>> + *     This file is distributed in the hope that it will be useful,
>>> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + *     GNU General Public License for more details.
>>> + *
>>> + *
>>> + * Or, alternatively,
>>> + *
>>> + *  b) Permission is hereby granted, free of charge, to any person
>>> + *     obtaining a copy of this software and associated documentation
>>> + *     files (the "Software"), to deal in the Software without
>>> + *     restriction, including without limitation the rights to use,
>>> + *     copy, modify, merge, publish, distribute, sublicense, and/or
>>> + *     sell copies of the Software, and to permit persons to whom the
>>> + *     Software is furnished to do so, subject to the following
>>> + *     conditions:
>>> + *
>>> + *     The above copyright notice and this permission notice shall be
>>> + *     included in all copies or substantial portions of the Software.
>>> + *
>>> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>>> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>>> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>>> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>>> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>>> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>>> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>>> + *     OTHER DEALINGS IN THE SOFTWARE.
>>> + */
>>> +
>>> +#include "sun8i.dtsi"
>>> +
>>> +/ {
>>> +       cpus {
>>> +               enable-method = "allwinner,sun8i";
>>> +               #address-cells = <1>;
>>> +               #size-cells = <0>;
>>> +
>>> +               cpu at 0 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <0>;
>>> +               };
>>> +
>>> +               cpu at 1 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <1>;
>>> +               };
>>> +
>>> +               cpu at 2 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <2>;
>>> +               };
>>> +
>>> +               cpu at 3 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <3>;
>>> +               };
>>> +       };
>>> +
>>> +       memory {
>>> +               reg = <0x40000000 0x80000000>;
>>> +       };
>>> +
>>> +       clocks {
>>> +               /* dummy clock until actually implemented */
>>> +               pll5: pll5_clk {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "fixed-clock";
>>> +                       clock-frequency = <0>;
>>> +                       clock-output-names = "pll5";
>>> +               };
>>> +
>>> +               axi: axi_clk at 01c20050 {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun8i-a23-axi-clk";
>>> +                       reg = <0x01c20050 0x4>;
>>> +                       clocks = <&cpu>;
>>> +                       clock-output-names = "axi";
>>> +               };
>>> +
>>> +               ahb1_gates: clk at 01c20060 {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-ahb1-gates-clk";
>>> +                       reg = <0x01c20060 0x8>;
>>> +                       clocks = <&ahb1>;
>>> +                       clock-output-names = "ahb1_mipidsi", "ahb1_dma",
>>> +                                       "ahb1_mmc0", "ahb1_mmc1",
>>> "ahb1_mmc2",
>>> +                                       "ahb1_nand", "ahb1_sdram",
>>> +                                       "ahb1_hstimer", "ahb1_spi0",
>>> +                                       "ahb1_spi1", "ahb1_otg",
>>> "ahb1_ehci",
>>> +                                       "ahb1_ohci", "ahb1_ve",
>>> "ahb1_lcd",
>>> +                                       "ahb1_csi", "ahb1_be",  "ahb1_fe",
>>> +                                       "ahb1_gpu", "ahb1_spinlock",
>>> +                                       "ahb1_drc";
>>> +               };
>>> +
>>> +               apb1_gates: clk at 01c20068 {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-apb1-gates-clk";
>>> +                       reg = <0x01c20068 0x4>;
>>> +                       clocks = <&apb1>;
>>> +                       clock-output-names = "apb1_codec", "apb1_pio",
>>> +                                       "apb1_daudio0", "apb1_daudio1";
>>> +               };
>>> +
>>> +               apb2: clk at 01c20058 {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun4i-a10-apb1-clk";
>>> +                       reg = <0x01c20058 0x4>;
>>> +                       clocks = <&osc32k>, <&osc24M>, <&pll6 0>, <&pll6
>>> 0>;
>>> +                       clock-output-names = "apb2";
>>> +               };
>>> +
>>> +               apb2_gates: clk at 01c2006c {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-apb2-gates-clk";
>>> +                       reg = <0x01c2006c 0x4>;
>>> +                       clocks = <&apb2>;
>>> +                       clock-output-names = "apb2_i2c0", "apb2_i2c1",
>>> +                                       "apb2_i2c2", "apb2_uart0",
>>> +                                       "apb2_uart1", "apb2_uart2",
>>> +                                       "apb2_uart3", "apb2_uart4";
>>> +               };
>>> +
>>> +               mbus_clk: clk at 01c2015c {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun8i-a23-mbus-clk";
>>> +                       reg = <0x01c2015c 0x4>;
>>> +                       clocks = <&osc24M>, <&pll6 1>, <&pll5>;
>>> +                       clock-output-names = "mbus";
>>> +               };
>>> +       };
>>> +
>>> +       soc at 01c00000 {
>>> +               dma: dma-controller at 01c02000 {
>>> +                       compatible = "allwinner,sun8i-a23-dma";
>>> +                       reg = <0x01c02000 0x1000>;
>>> +                       interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       clocks = <&ahb1_gates 6>;
>>> +                       resets = <&ahb1_rst 6>;
>>> +                       #dma-cells = <1>;
>>> +               };
>>> +
>>> +               pio: pinctrl at 01c20800 {
>>> +                       compatible = "allwinner,sun8i-a33-pinctrl";
>>> +                       interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>>> +
>>> +                       uart0_pins_a: uart0 at 0 {
>>> +                               allwinner,pins = "PF2", "PF4";
>>> +                               allwinner,function = "uart0";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c0_pins_a: i2c0 at 0 {
>>> +                               allwinner,pins = "PH2", "PH3";
>>> +                               allwinner,function = "i2c0";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c1_pins_a: i2c1 at 0 {
>>> +                               allwinner,pins = "PH4", "PH5";
>>> +                               allwinner,function = "i2c1";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c2_pins_a: i2c2 at 0 {
>>> +                               allwinner,pins = "PE12", "PE13";
>>> +                               allwinner,function = "i2c2";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +               };
>>> +
>>> +               lradc: lradc at 01c22800 {
>>> +                       compatible = "allwinner,sun4i-a10-lradc-keys";
>>> +                       reg = <0x01c22800 0x100>;
>>> +                       interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       status = "disabled";
>>> +               };
>>> +
>>> +               uart4: serial at 01c29000 {
>>> +                       compatible = "snps,dw-apb-uart";
>>> +                       reg = <0x01c29000 0x400>;
>>> +                       interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       reg-shift = <2>;
>>> +                       reg-io-width = <4>;
>>> +                       clocks = <&apb2_gates 20>;
>>> +                       resets = <&apb2_rst 20>;
>>> +                       dmas = <&dma 10>, <&dma 10>;
>>> +                       dma-names = "rx", "tx";
>>> +                       status = "disabled";
>>> +               };
>>> +       };
>>> +};
>>>
>>

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Vishnu Patekar
	<vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org"
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
	<linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner A33 DTSI
Date: Sun, 10 May 2015 11:54:33 +0200	[thread overview]
Message-ID: <554F2AD9.3030005@redhat.com> (raw)
In-Reply-To: <CAEzqOZv034sn-LVcYqrXWukdvcdm=BbVo7gMiYAy-dQG=mpQTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi,

On 10-05-15 11:33, Vishnu Patekar wrote:
> Hi,
>
> On Sun, May 10, 2015 at 2:23 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> Hi,
>>
>> On 10-05-15 08:46, Vishnu Patekar wrote:
>>>
>>> this is based on common sun8i.dtsi patch.
>>> sun8i-a23.dtsi and sun8i-a33.dtsi are same, A33 specific features
>>> e.g. clocks can be added in future.
>>>
>>> Signed-off-by: VishnuPatekar <vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>>
>> This seems to only contain stuff which can be shared with the a23 dts,
>> why is this not all in the common sun8i.dtsi ?
> Allwinner H3 is also sun8i, I've referred the referred the H3 dtsi
> patch sent by Jens Kuske.
> I've added common parts bet a23 and h3 in sun8i.dtsi.

Ah, I see, ok that works for me.

Regards,

Hans


>
> same note added in common sun8i PATCH 4, which I'm going to resend
> after your comment.
>
>>
>> Regards,
>>
>> Hans
>>
>>
>>> ---
>>>    arch/arm/boot/dts/sun8i-a33.dtsi | 217
>>> +++++++++++++++++++++++++++++++++++++++
>>>    1 file changed, 217 insertions(+)
>>>    create mode 100644 arch/arm/boot/dts/sun8i-a33.dtsi
>>>
>>> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi
>>> b/arch/arm/boot/dts/sun8i-a33.dtsi
>>> new file mode 100644
>>> index 0000000..32489fc
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi
>>> @@ -0,0 +1,217 @@
>>> +/*
>>> + * Copyright 2014 Chen-Yu Tsai
>>> + *
>>> + * Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
>>> + *
>>> + * This file is dual-licensed: you can use it either under the terms
>>> + * of the GPL or the X11 license, at your option. Note that this dual
>>> + * licensing only applies to this file, and not this project as a
>>> + * whole.
>>> + *
>>> + *  a) This file is free software; you can redistribute it and/or
>>> + *     modify it under the terms of the GNU General Public License as
>>> + *     published by the Free Software Foundation; either version 2 of the
>>> + *     License, or (at your option) any later version.
>>> + *
>>> + *     This file is distributed in the hope that it will be useful,
>>> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + *     GNU General Public License for more details.
>>> + *
>>> + *
>>> + * Or, alternatively,
>>> + *
>>> + *  b) Permission is hereby granted, free of charge, to any person
>>> + *     obtaining a copy of this software and associated documentation
>>> + *     files (the "Software"), to deal in the Software without
>>> + *     restriction, including without limitation the rights to use,
>>> + *     copy, modify, merge, publish, distribute, sublicense, and/or
>>> + *     sell copies of the Software, and to permit persons to whom the
>>> + *     Software is furnished to do so, subject to the following
>>> + *     conditions:
>>> + *
>>> + *     The above copyright notice and this permission notice shall be
>>> + *     included in all copies or substantial portions of the Software.
>>> + *
>>> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>>> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>>> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>>> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>>> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>>> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>>> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>>> + *     OTHER DEALINGS IN THE SOFTWARE.
>>> + */
>>> +
>>> +#include "sun8i.dtsi"
>>> +
>>> +/ {
>>> +       cpus {
>>> +               enable-method = "allwinner,sun8i";
>>> +               #address-cells = <1>;
>>> +               #size-cells = <0>;
>>> +
>>> +               cpu@0 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <0>;
>>> +               };
>>> +
>>> +               cpu@1 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <1>;
>>> +               };
>>> +
>>> +               cpu@2 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <2>;
>>> +               };
>>> +
>>> +               cpu@3 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <3>;
>>> +               };
>>> +       };
>>> +
>>> +       memory {
>>> +               reg = <0x40000000 0x80000000>;
>>> +       };
>>> +
>>> +       clocks {
>>> +               /* dummy clock until actually implemented */
>>> +               pll5: pll5_clk {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "fixed-clock";
>>> +                       clock-frequency = <0>;
>>> +                       clock-output-names = "pll5";
>>> +               };
>>> +
>>> +               axi: axi_clk@01c20050 {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun8i-a23-axi-clk";
>>> +                       reg = <0x01c20050 0x4>;
>>> +                       clocks = <&cpu>;
>>> +                       clock-output-names = "axi";
>>> +               };
>>> +
>>> +               ahb1_gates: clk@01c20060 {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-ahb1-gates-clk";
>>> +                       reg = <0x01c20060 0x8>;
>>> +                       clocks = <&ahb1>;
>>> +                       clock-output-names = "ahb1_mipidsi", "ahb1_dma",
>>> +                                       "ahb1_mmc0", "ahb1_mmc1",
>>> "ahb1_mmc2",
>>> +                                       "ahb1_nand", "ahb1_sdram",
>>> +                                       "ahb1_hstimer", "ahb1_spi0",
>>> +                                       "ahb1_spi1", "ahb1_otg",
>>> "ahb1_ehci",
>>> +                                       "ahb1_ohci", "ahb1_ve",
>>> "ahb1_lcd",
>>> +                                       "ahb1_csi", "ahb1_be",  "ahb1_fe",
>>> +                                       "ahb1_gpu", "ahb1_spinlock",
>>> +                                       "ahb1_drc";
>>> +               };
>>> +
>>> +               apb1_gates: clk@01c20068 {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-apb1-gates-clk";
>>> +                       reg = <0x01c20068 0x4>;
>>> +                       clocks = <&apb1>;
>>> +                       clock-output-names = "apb1_codec", "apb1_pio",
>>> +                                       "apb1_daudio0", "apb1_daudio1";
>>> +               };
>>> +
>>> +               apb2: clk@01c20058 {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun4i-a10-apb1-clk";
>>> +                       reg = <0x01c20058 0x4>;
>>> +                       clocks = <&osc32k>, <&osc24M>, <&pll6 0>, <&pll6
>>> 0>;
>>> +                       clock-output-names = "apb2";
>>> +               };
>>> +
>>> +               apb2_gates: clk@01c2006c {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-apb2-gates-clk";
>>> +                       reg = <0x01c2006c 0x4>;
>>> +                       clocks = <&apb2>;
>>> +                       clock-output-names = "apb2_i2c0", "apb2_i2c1",
>>> +                                       "apb2_i2c2", "apb2_uart0",
>>> +                                       "apb2_uart1", "apb2_uart2",
>>> +                                       "apb2_uart3", "apb2_uart4";
>>> +               };
>>> +
>>> +               mbus_clk: clk@01c2015c {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun8i-a23-mbus-clk";
>>> +                       reg = <0x01c2015c 0x4>;
>>> +                       clocks = <&osc24M>, <&pll6 1>, <&pll5>;
>>> +                       clock-output-names = "mbus";
>>> +               };
>>> +       };
>>> +
>>> +       soc@01c00000 {
>>> +               dma: dma-controller@01c02000 {
>>> +                       compatible = "allwinner,sun8i-a23-dma";
>>> +                       reg = <0x01c02000 0x1000>;
>>> +                       interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       clocks = <&ahb1_gates 6>;
>>> +                       resets = <&ahb1_rst 6>;
>>> +                       #dma-cells = <1>;
>>> +               };
>>> +
>>> +               pio: pinctrl@01c20800 {
>>> +                       compatible = "allwinner,sun8i-a33-pinctrl";
>>> +                       interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>>> +
>>> +                       uart0_pins_a: uart0@0 {
>>> +                               allwinner,pins = "PF2", "PF4";
>>> +                               allwinner,function = "uart0";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c0_pins_a: i2c0@0 {
>>> +                               allwinner,pins = "PH2", "PH3";
>>> +                               allwinner,function = "i2c0";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c1_pins_a: i2c1@0 {
>>> +                               allwinner,pins = "PH4", "PH5";
>>> +                               allwinner,function = "i2c1";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c2_pins_a: i2c2@0 {
>>> +                               allwinner,pins = "PE12", "PE13";
>>> +                               allwinner,function = "i2c2";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +               };
>>> +
>>> +               lradc: lradc@01c22800 {
>>> +                       compatible = "allwinner,sun4i-a10-lradc-keys";
>>> +                       reg = <0x01c22800 0x100>;
>>> +                       interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       status = "disabled";
>>> +               };
>>> +
>>> +               uart4: serial@01c29000 {
>>> +                       compatible = "snps,dw-apb-uart";
>>> +                       reg = <0x01c29000 0x400>;
>>> +                       interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       reg-shift = <2>;
>>> +                       reg-io-width = <4>;
>>> +                       clocks = <&apb2_gates 20>;
>>> +                       resets = <&apb2_rst 20>;
>>> +                       dmas = <&dma 10>, <&dma 10>;
>>> +                       dma-names = "rx", "tx";
>>> +                       status = "disabled";
>>> +               };
>>> +       };
>>> +};
>>>
>>

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Vishnu Patekar <vishnupatekar0510@gmail.com>
Cc: "maxime.ripard@free-electrons.com"
	<maxime.ripard@free-electrons.com>,
	emilio@elopez.com.ar, Linus Walleij <linus.walleij@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>, Jens Kuske <jenskuske@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner A33 DTSI
Date: Sun, 10 May 2015 11:54:33 +0200	[thread overview]
Message-ID: <554F2AD9.3030005@redhat.com> (raw)
In-Reply-To: <CAEzqOZv034sn-LVcYqrXWukdvcdm=BbVo7gMiYAy-dQG=mpQTw@mail.gmail.com>

Hi,

On 10-05-15 11:33, Vishnu Patekar wrote:
> Hi,
>
> On Sun, May 10, 2015 at 2:23 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>>
>> On 10-05-15 08:46, Vishnu Patekar wrote:
>>>
>>> this is based on common sun8i.dtsi patch.
>>> sun8i-a23.dtsi and sun8i-a33.dtsi are same, A33 specific features
>>> e.g. clocks can be added in future.
>>>
>>> Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com>
>>
>>
>> This seems to only contain stuff which can be shared with the a23 dts,
>> why is this not all in the common sun8i.dtsi ?
> Allwinner H3 is also sun8i, I've referred the referred the H3 dtsi
> patch sent by Jens Kuske.
> I've added common parts bet a23 and h3 in sun8i.dtsi.

Ah, I see, ok that works for me.

Regards,

Hans


>
> same note added in common sun8i PATCH 4, which I'm going to resend
> after your comment.
>
>>
>> Regards,
>>
>> Hans
>>
>>
>>> ---
>>>    arch/arm/boot/dts/sun8i-a33.dtsi | 217
>>> +++++++++++++++++++++++++++++++++++++++
>>>    1 file changed, 217 insertions(+)
>>>    create mode 100644 arch/arm/boot/dts/sun8i-a33.dtsi
>>>
>>> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi
>>> b/arch/arm/boot/dts/sun8i-a33.dtsi
>>> new file mode 100644
>>> index 0000000..32489fc
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi
>>> @@ -0,0 +1,217 @@
>>> +/*
>>> + * Copyright 2014 Chen-Yu Tsai
>>> + *
>>> + * Chen-Yu Tsai <wens@csie.org>
>>> + *
>>> + * This file is dual-licensed: you can use it either under the terms
>>> + * of the GPL or the X11 license, at your option. Note that this dual
>>> + * licensing only applies to this file, and not this project as a
>>> + * whole.
>>> + *
>>> + *  a) This file is free software; you can redistribute it and/or
>>> + *     modify it under the terms of the GNU General Public License as
>>> + *     published by the Free Software Foundation; either version 2 of the
>>> + *     License, or (at your option) any later version.
>>> + *
>>> + *     This file is distributed in the hope that it will be useful,
>>> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + *     GNU General Public License for more details.
>>> + *
>>> + *
>>> + * Or, alternatively,
>>> + *
>>> + *  b) Permission is hereby granted, free of charge, to any person
>>> + *     obtaining a copy of this software and associated documentation
>>> + *     files (the "Software"), to deal in the Software without
>>> + *     restriction, including without limitation the rights to use,
>>> + *     copy, modify, merge, publish, distribute, sublicense, and/or
>>> + *     sell copies of the Software, and to permit persons to whom the
>>> + *     Software is furnished to do so, subject to the following
>>> + *     conditions:
>>> + *
>>> + *     The above copyright notice and this permission notice shall be
>>> + *     included in all copies or substantial portions of the Software.
>>> + *
>>> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>>> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>>> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>>> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>>> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>>> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>>> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>>> + *     OTHER DEALINGS IN THE SOFTWARE.
>>> + */
>>> +
>>> +#include "sun8i.dtsi"
>>> +
>>> +/ {
>>> +       cpus {
>>> +               enable-method = "allwinner,sun8i";
>>> +               #address-cells = <1>;
>>> +               #size-cells = <0>;
>>> +
>>> +               cpu@0 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <0>;
>>> +               };
>>> +
>>> +               cpu@1 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <1>;
>>> +               };
>>> +
>>> +               cpu@2 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <2>;
>>> +               };
>>> +
>>> +               cpu@3 {
>>> +                       compatible = "arm,cortex-a7";
>>> +                       device_type = "cpu";
>>> +                       reg = <3>;
>>> +               };
>>> +       };
>>> +
>>> +       memory {
>>> +               reg = <0x40000000 0x80000000>;
>>> +       };
>>> +
>>> +       clocks {
>>> +               /* dummy clock until actually implemented */
>>> +               pll5: pll5_clk {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "fixed-clock";
>>> +                       clock-frequency = <0>;
>>> +                       clock-output-names = "pll5";
>>> +               };
>>> +
>>> +               axi: axi_clk@01c20050 {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun8i-a23-axi-clk";
>>> +                       reg = <0x01c20050 0x4>;
>>> +                       clocks = <&cpu>;
>>> +                       clock-output-names = "axi";
>>> +               };
>>> +
>>> +               ahb1_gates: clk@01c20060 {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-ahb1-gates-clk";
>>> +                       reg = <0x01c20060 0x8>;
>>> +                       clocks = <&ahb1>;
>>> +                       clock-output-names = "ahb1_mipidsi", "ahb1_dma",
>>> +                                       "ahb1_mmc0", "ahb1_mmc1",
>>> "ahb1_mmc2",
>>> +                                       "ahb1_nand", "ahb1_sdram",
>>> +                                       "ahb1_hstimer", "ahb1_spi0",
>>> +                                       "ahb1_spi1", "ahb1_otg",
>>> "ahb1_ehci",
>>> +                                       "ahb1_ohci", "ahb1_ve",
>>> "ahb1_lcd",
>>> +                                       "ahb1_csi", "ahb1_be",  "ahb1_fe",
>>> +                                       "ahb1_gpu", "ahb1_spinlock",
>>> +                                       "ahb1_drc";
>>> +               };
>>> +
>>> +               apb1_gates: clk@01c20068 {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-apb1-gates-clk";
>>> +                       reg = <0x01c20068 0x4>;
>>> +                       clocks = <&apb1>;
>>> +                       clock-output-names = "apb1_codec", "apb1_pio",
>>> +                                       "apb1_daudio0", "apb1_daudio1";
>>> +               };
>>> +
>>> +               apb2: clk@01c20058 {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun4i-a10-apb1-clk";
>>> +                       reg = <0x01c20058 0x4>;
>>> +                       clocks = <&osc32k>, <&osc24M>, <&pll6 0>, <&pll6
>>> 0>;
>>> +                       clock-output-names = "apb2";
>>> +               };
>>> +
>>> +               apb2_gates: clk@01c2006c {
>>> +                       #clock-cells = <1>;
>>> +                       compatible = "allwinner,sun8i-a23-apb2-gates-clk";
>>> +                       reg = <0x01c2006c 0x4>;
>>> +                       clocks = <&apb2>;
>>> +                       clock-output-names = "apb2_i2c0", "apb2_i2c1",
>>> +                                       "apb2_i2c2", "apb2_uart0",
>>> +                                       "apb2_uart1", "apb2_uart2",
>>> +                                       "apb2_uart3", "apb2_uart4";
>>> +               };
>>> +
>>> +               mbus_clk: clk@01c2015c {
>>> +                       #clock-cells = <0>;
>>> +                       compatible = "allwinner,sun8i-a23-mbus-clk";
>>> +                       reg = <0x01c2015c 0x4>;
>>> +                       clocks = <&osc24M>, <&pll6 1>, <&pll5>;
>>> +                       clock-output-names = "mbus";
>>> +               };
>>> +       };
>>> +
>>> +       soc@01c00000 {
>>> +               dma: dma-controller@01c02000 {
>>> +                       compatible = "allwinner,sun8i-a23-dma";
>>> +                       reg = <0x01c02000 0x1000>;
>>> +                       interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       clocks = <&ahb1_gates 6>;
>>> +                       resets = <&ahb1_rst 6>;
>>> +                       #dma-cells = <1>;
>>> +               };
>>> +
>>> +               pio: pinctrl@01c20800 {
>>> +                       compatible = "allwinner,sun8i-a33-pinctrl";
>>> +                       interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
>>> +                                    <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>>> +
>>> +                       uart0_pins_a: uart0@0 {
>>> +                               allwinner,pins = "PF2", "PF4";
>>> +                               allwinner,function = "uart0";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c0_pins_a: i2c0@0 {
>>> +                               allwinner,pins = "PH2", "PH3";
>>> +                               allwinner,function = "i2c0";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c1_pins_a: i2c1@0 {
>>> +                               allwinner,pins = "PH4", "PH5";
>>> +                               allwinner,function = "i2c1";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +
>>> +                       i2c2_pins_a: i2c2@0 {
>>> +                               allwinner,pins = "PE12", "PE13";
>>> +                               allwinner,function = "i2c2";
>>> +                               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> +                               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> +                       };
>>> +               };
>>> +
>>> +               lradc: lradc@01c22800 {
>>> +                       compatible = "allwinner,sun4i-a10-lradc-keys";
>>> +                       reg = <0x01c22800 0x100>;
>>> +                       interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       status = "disabled";
>>> +               };
>>> +
>>> +               uart4: serial@01c29000 {
>>> +                       compatible = "snps,dw-apb-uart";
>>> +                       reg = <0x01c29000 0x400>;
>>> +                       interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>>> +                       reg-shift = <2>;
>>> +                       reg-io-width = <4>;
>>> +                       clocks = <&apb2_gates 20>;
>>> +                       resets = <&apb2_rst 20>;
>>> +                       dmas = <&dma 10>, <&dma 10>;
>>> +                       dma-names = "rx", "tx";
>>> +                       status = "disabled";
>>> +               };
>>> +       };
>>> +};
>>>
>>

  reply	other threads:[~2015-05-10  9:54 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-10  6:46 [PATCH 0/6] Introduce Allwinner A33 support Vishnu Patekar
2015-05-10  6:46 ` Vishnu Patekar
2015-05-10  6:46 ` Vishnu Patekar
2015-05-10  6:46 ` [PATCH 1/6] ARM: sunxi: Add Machine support for A33 Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  8:49   ` Hans de Goede
2015-05-10  8:49     ` Hans de Goede
2015-05-10  8:49     ` Hans de Goede
2015-05-10 10:33   ` Maxime Ripard
2015-05-10 10:33     ` Maxime Ripard
2015-05-10 10:33     ` Maxime Ripard
2015-05-11  8:52     ` Vishnu Patekar
2015-05-11  8:52       ` Vishnu Patekar
2015-05-11  8:52       ` Vishnu Patekar
2015-05-10  6:46 ` [PATCH 2/6] pinctrl: sunxi: add allwinner A33 PIO controller support Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  8:50   ` Hans de Goede
2015-05-10  8:50     ` Hans de Goede
2015-05-10  8:50     ` Hans de Goede
2015-05-10  9:00     ` Chen-Yu Tsai
2015-05-10  9:00       ` Chen-Yu Tsai
2015-05-10  9:00       ` Chen-Yu Tsai
2015-05-10  9:10       ` Hans de Goede
2015-05-10  9:10         ` Hans de Goede
2015-05-10  9:10         ` Hans de Goede
2015-05-10 10:34   ` Maxime Ripard
2015-05-10 10:34     ` Maxime Ripard
2015-05-10 10:34     ` Maxime Ripard
2015-05-11  7:22   ` Paul Bolle
2015-05-11  7:22     ` Paul Bolle
2015-05-11  7:22     ` Paul Bolle
2015-05-10  6:46 ` [PATCH 3/6] clk: sunxi: Add A33 clock for compilation Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10 10:17   ` Maxime Ripard
2015-05-10 10:17     ` Maxime Ripard
2015-05-10 10:17     ` Maxime Ripard
2015-05-11  8:53     ` Vishnu Patekar
2015-05-11  8:53       ` Vishnu Patekar
2015-05-11  8:53       ` Vishnu Patekar
2015-07-17  8:57       ` Chen-Yu Tsai
2015-07-17  8:57         ` Chen-Yu Tsai
2015-07-17  8:57         ` Chen-Yu Tsai
2015-07-17  9:09         ` Maxime Ripard
2015-07-17  9:09           ` Maxime Ripard
2015-07-17  9:09           ` Maxime Ripard
2015-07-17  9:13           ` Chen-Yu Tsai
2015-07-17  9:13             ` Chen-Yu Tsai
2015-07-17  9:13             ` Chen-Yu Tsai
2015-05-10  6:46 ` [PATCH 4/6] ARM: dts: sunxi: add common sun8i dtsi Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  8:52   ` Hans de Goede
2015-05-10  8:52     ` Hans de Goede
2015-05-10  8:52     ` Hans de Goede
2015-05-10 10:41   ` Maxime Ripard
2015-05-10 10:41     ` Maxime Ripard
2015-05-10 10:41     ` Maxime Ripard
2015-05-11 11:18     ` Vishnu Patekar
2015-05-11 11:18       ` Vishnu Patekar
2015-05-11 11:18       ` Vishnu Patekar
2015-05-10  6:46 ` [PATCH 5/6] ARM: dts: sunxi: Add Allwinner A33 DTSI Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  8:53   ` Hans de Goede
2015-05-10  8:53     ` Hans de Goede
2015-05-10  8:53     ` Hans de Goede
2015-05-10  9:33     ` Vishnu Patekar
2015-05-10  9:33       ` Vishnu Patekar
2015-05-10  9:33       ` Vishnu Patekar
2015-05-10  9:54       ` Hans de Goede [this message]
2015-05-10  9:54         ` Hans de Goede
2015-05-10  9:54         ` Hans de Goede
2015-05-10 10:43   ` Maxime Ripard
2015-05-10 10:43     ` Maxime Ripard
2015-05-10 10:43     ` Maxime Ripard
2015-05-10  6:46 ` [PATCH 6/6] ARM: dts: sun8i: Add ET-Q8 A33 support Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  6:46   ` Vishnu Patekar
2015-05-10  8:54   ` Hans de Goede
2015-05-10  8:54     ` Hans de Goede
2015-05-10  8:54     ` Hans de Goede
     [not found]     ` <CAEzqOZuS4m8kDhG0RpLRGBXbnFXLPKJB8D78_Dc02vRkfwvTUA@mail.gmail.com>
2015-05-11  8:24       ` Hans de Goede
2015-05-11  8:27         ` Hans de Goede
2015-05-11 11:15           ` Vishnu Patekar
2015-05-11 11:16             ` Hans de Goede
2015-05-10 10:47   ` Maxime Ripard
2015-05-10 10:47     ` Maxime Ripard
2015-05-10 10:47     ` Maxime Ripard
2015-05-12 11:37 ` [PATCH 0/6] Introduce Allwinner " Linus Walleij
2015-05-12 11:37   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554F2AD9.3030005@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.