All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Rafael Wysocki <rjw@rjwysocki.net>,
	rob.herring@linaro.org, arnd.bergmann@linaro.org,
	mike.turquette@linaro.org, sboyd@codeaurora.org,
	linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	grant.likely@linaro.org, olof@lixom.net, Sudeep.Holla@arm.com,
	devicetree@vger.kernel.org, viswanath.puttagunta@linaro.org,
	l.stach@pengutronix.de, thomas.petazzoni@free-electrons.com,
	linux-arm-kernel@lists.infradead.org, ta.omasab@gmail.com,
	kesavan.abhilash@gmail.com, khilman@linaro.org,
	santosh.shilimkar@oracle.com
Subject: Re: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings
Date: Wed, 13 May 2015 11:34:13 -0500	[thread overview]
Message-ID: <55537D05.4080009@ti.com> (raw)
In-Reply-To: <20150513162127.GA2761@sirena.org.uk>

On 05/13/2015 11:21 AM, Mark Brown wrote:
> On Wed, May 13, 2015 at 11:14:07AM -0500, Nishanth Menon wrote:
> 
>> To illustrate: What does it mean for a driver using regulator API?
>> Attempt X <-> (X+Y), if that fails (example PMIC SMPS max < X), try
>> (X-Y)<->(X)? If yes, then we do expect (X-Y)<->(X+Y) should be stable
>> for all operating conditions for the device, correct? If this is is
>> not stable at (X-Y), then we have a wrong specification for the device
>> for claiming X +/- Y is a valid range for the device.
> 
> We have an explicit regulator API call for setting by tolerance which
> tries to get as close as possible to the target voltage (currently the
> implementation is very cheap and nasty but ideally it'll get improved).
> 

Thanks - I think the original implementation was triggered by the old
"voltage-tolerance" mess, so wont be too surprised.

With respect to the property itself, I still am not completely
convinced that having typ actually helps. but having it does not hurt
either, since min could be == typ in SoC description if desired.

So, since I dont strongly feel either way here to reject things
completely, and supposedly, it does help some other SoC vendors(which
I am not convinced how), will leave the discussion alone for the moment.

-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings
Date: Wed, 13 May 2015 11:34:13 -0500	[thread overview]
Message-ID: <55537D05.4080009@ti.com> (raw)
In-Reply-To: <20150513162127.GA2761@sirena.org.uk>

On 05/13/2015 11:21 AM, Mark Brown wrote:
> On Wed, May 13, 2015 at 11:14:07AM -0500, Nishanth Menon wrote:
> 
>> To illustrate: What does it mean for a driver using regulator API?
>> Attempt X <-> (X+Y), if that fails (example PMIC SMPS max < X), try
>> (X-Y)<->(X)? If yes, then we do expect (X-Y)<->(X+Y) should be stable
>> for all operating conditions for the device, correct? If this is is
>> not stable at (X-Y), then we have a wrong specification for the device
>> for claiming X +/- Y is a valid range for the device.
> 
> We have an explicit regulator API call for setting by tolerance which
> tries to get as close as possible to the target voltage (currently the
> implementation is very cheap and nasty but ideally it'll get improved).
> 

Thanks - I think the original implementation was triggered by the old
"voltage-tolerance" mess, so wont be too surprised.

With respect to the property itself, I still am not completely
convinced that having typ actually helps. but having it does not hurt
either, since min could be == typ in SoC description if desired.

So, since I dont strongly feel either way here to reject things
completely, and supposedly, it does help some other SoC vendors(which
I am not convinced how), will leave the discussion alone for the moment.

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2015-05-13 16:35 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 12:07 [PATCH V4 0/3] OPP: Introduce OPP (V2) bindings Viresh Kumar
2015-04-30 12:07 ` Viresh Kumar
     [not found] ` <cover.1430394884.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-04-30 12:07   ` [PATCH V4 1/3] OPP: Redefine bindings to overcome shortcomings Viresh Kumar
2015-04-30 12:07     ` Viresh Kumar
     [not found]     ` <d225e73f183e01fa0b71e4b9248b6a19a3f7d697.1430394884.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-04 12:12       ` Mark Brown
2015-05-04 12:12         ` Mark Brown
2015-05-05 10:48         ` Viresh Kumar
2015-05-05 10:48           ` Viresh Kumar
2015-05-05 10:57           ` Mark Brown
2015-05-05 10:57             ` Mark Brown
     [not found]             ` <20150505105714.GA22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-05 11:43               ` Viresh Kumar
2015-05-05 11:43                 ` Viresh Kumar
2015-05-05 17:12                 ` Mark Brown
2015-05-05 17:12                   ` Mark Brown
2015-05-06  6:53                   ` Viresh Kumar
2015-05-06  6:53                     ` Viresh Kumar
2015-05-07  5:52                     ` Stephen Boyd
2015-05-07  5:52                       ` Stephen Boyd
2015-05-07 11:02                       ` Mark Brown
2015-05-07 11:02                         ` Mark Brown
2015-05-07 21:18                         ` Stephen Boyd
2015-05-07 21:18                           ` Stephen Boyd
2015-05-07 22:18                           ` Mark Brown
2015-05-07 22:18                             ` Mark Brown
     [not found]                             ` <20150507221842.GW22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-08  6:47                               ` Viresh Kumar
2015-05-08  6:47                                 ` Viresh Kumar
2015-05-08 10:58                                 ` Mark Brown
2015-05-08 10:58                                   ` Mark Brown
2015-05-08 11:01                                   ` Viresh Kumar
2015-05-08 11:01                                     ` Viresh Kumar
2015-05-11  1:07                                 ` Nishanth Menon
2015-05-11  1:07                                   ` Nishanth Menon
2015-05-12  5:20                                   ` Viresh Kumar
2015-05-12  5:20                                     ` Viresh Kumar
2015-05-12 19:01                                     ` Michael Turquette
2015-05-12 19:01                                       ` Michael Turquette
2015-05-12 19:14                                       ` Nishanth Menon
2015-05-12 19:14                                         ` Nishanth Menon
2015-05-12 19:41                                         ` Mark Brown
2015-05-12 19:41                                           ` Mark Brown
2015-05-12 19:57                                           ` Nishanth Menon
2015-05-12 19:57                                             ` Nishanth Menon
2015-05-13 11:54                                             ` Mark Brown
2015-05-13 11:54                                               ` Mark Brown
     [not found]                                               ` <20150513115422.GQ3066-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-13 14:24                                                 ` Nishanth Menon
2015-05-13 14:24                                                   ` Nishanth Menon
2015-05-13 15:07                                                   ` Mark Brown
2015-05-13 15:07                                                     ` Mark Brown
2015-05-13 15:43                                                     ` Nishanth Menon
2015-05-13 15:43                                                       ` Nishanth Menon
2015-05-07 12:13                       ` Viresh Kumar
2015-05-07 12:13                         ` Viresh Kumar
2015-05-07 21:30                         ` Stephen Boyd
2015-05-07 21:30                           ` Stephen Boyd
2015-05-08  6:49                           ` Viresh Kumar
2015-05-08  6:49                             ` Viresh Kumar
2015-05-11  1:02       ` Nishanth Menon
2015-05-11  1:02         ` Nishanth Menon
2015-05-12  5:16         ` Viresh Kumar
2015-05-12  5:16           ` Viresh Kumar
2015-05-12 16:04           ` Nishanth Menon
2015-05-12 16:04             ` Nishanth Menon
2015-05-13  5:05             ` Viresh Kumar
2015-05-13  5:05               ` Viresh Kumar
2015-05-13 15:00               ` Nishanth Menon
2015-05-13 15:00                 ` Nishanth Menon
2015-05-13 15:16                 ` Mark Brown
2015-05-13 15:16                   ` Mark Brown
2015-05-13 16:14                   ` Nishanth Menon
2015-05-13 16:14                     ` Nishanth Menon
2015-05-13 16:21                     ` Mark Brown
2015-05-13 16:21                       ` Mark Brown
2015-05-13 16:34                       ` Nishanth Menon [this message]
2015-05-13 16:34                         ` Nishanth Menon
2015-05-12 16:19     ` Felipe Balbi
2015-05-12 16:19       ` Felipe Balbi
2015-05-13  4:45       ` Viresh Kumar
2015-05-13  4:45         ` Viresh Kumar
2015-05-12 21:42     ` Michael Turquette
2015-05-12 21:42       ` Michael Turquette
2015-05-13  8:55       ` Viresh Kumar
2015-05-13  8:55         ` Viresh Kumar
2015-05-13 11:03         ` Mark Brown
2015-05-13 11:03           ` Mark Brown
2015-05-14  0:32           ` Michael Turquette
2015-05-14  0:32             ` Michael Turquette
     [not found]             ` <CAKohpokeKtcJdrBcPZBBPR2zfJgpvuM_=wRaX5q1Uto2qx1oHQ@mail.gmail.com>
2015-05-15 14:15               ` Viresh Kumar
2015-05-15 14:15                 ` Viresh Kumar
2015-05-15 15:43                 ` Nishanth Menon
2015-05-15 15:43                   ` Nishanth Menon
2015-05-15 17:27             ` Rob Herring
2015-05-15 17:27               ` Rob Herring
2015-05-21  6:02         ` Nishanth Menon
2015-05-21  6:02           ` Nishanth Menon
2015-05-22 14:04           ` Viresh Kumar
2015-05-22 14:04             ` Viresh Kumar
2015-05-22 16:04             ` Rob Herring
2015-05-22 16:04               ` Rob Herring
2015-05-22 17:42               ` Nishanth Menon
2015-05-22 17:42                 ` Nishanth Menon
2015-05-26  5:25                 ` Viresh Kumar
2015-05-26  5:25                   ` Viresh Kumar
2015-05-20  0:51     ` Stephen Boyd
2015-05-20  0:51       ` Stephen Boyd
2015-05-20  2:07       ` Viresh Kumar
2015-05-20  2:07         ` Viresh Kumar
2015-05-20 19:39         ` Stephen Boyd
2015-05-20 19:39           ` Stephen Boyd
2015-05-21  4:33           ` Viresh Kumar
2015-05-21  4:33             ` Viresh Kumar
2015-05-25 11:59             ` Viresh Kumar
2015-05-25 11:59               ` Viresh Kumar
2015-04-30 12:08 ` [PATCH V4 2/3] OPP: Allow multiple OPP tables to be passed via DT Viresh Kumar
2015-04-30 12:08   ` Viresh Kumar
2015-05-12 16:09   ` Nishanth Menon
2015-05-12 16:09     ` Nishanth Menon
2015-05-13  4:41     ` Viresh Kumar
2015-05-13  4:41       ` Viresh Kumar
2015-05-20  0:52   ` Stephen Boyd
2015-05-20  0:52     ` Stephen Boyd
2015-04-30 12:08 ` [PATCH V4 3/3] OPP: Add 'opp-next' in operating-points-v2 bindings Viresh Kumar
2015-04-30 12:08   ` Viresh Kumar
2015-05-12 21:47   ` Michael Turquette
2015-05-12 21:47     ` Michael Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55537D05.4080009@ti.com \
    --to=nm@ti.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=arnd.bergmann@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=kesavan.abhilash@gmail.com \
    --cc=khilman@linaro.org \
    --cc=l.stach@pengutronix.de \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mike.turquette@linaro.org \
    --cc=olof@lixom.net \
    --cc=rjw@rjwysocki.net \
    --cc=rob.herring@linaro.org \
    --cc=santosh.shilimkar@oracle.com \
    --cc=sboyd@codeaurora.org \
    --cc=ta.omasab@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=viresh.kumar@linaro.org \
    --cc=viswanath.puttagunta@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.