* [review-request] adamian/20150515_fix_table_header - REST refactoring @ 2015-06-03 13:15 Damian, Alexandru 2015-06-03 13:59 ` Michael Wood 0 siblings, 1 reply; 6+ messages in thread From: Damian, Alexandru @ 2015-06-03 13:15 UTC (permalink / raw) To: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 613 bytes --] Hi, I've progressed a bit with the REST refactoring, I've tackled the ToasterTables. Thanks to good quality of the existing code , changing the layout of the URL was straightforward. adamian/20150515_fix_table_header This reduces the number of entry points for the URL, removes the ugly hardcoding of XHR_ table urls in tables.py, and makes sure the APIs are both human- and machine-readable. I'll continue with refactoring to remove the xhr_datatypeahead and similar URL endpoints which should not have existed in the first place. Cheers, Alex -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 1646 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] adamian/20150515_fix_table_header - REST refactoring 2015-06-03 13:15 [review-request] adamian/20150515_fix_table_header - REST refactoring Damian, Alexandru @ 2015-06-03 13:59 ` Michael Wood 2015-06-03 14:35 ` Damian, Alexandru 0 siblings, 1 reply; 6+ messages in thread From: Michael Wood @ 2015-06-03 13:59 UTC (permalink / raw) To: Damian, Alexandru, toaster@yoctoproject.org 8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4 Looks good to me. Yeah that's a good idea to make ToasterTable inherit from TemplateView rather than have it in between. Thanks, Michael On 03/06/15 14:15, Damian, Alexandru wrote: > Hi, > > I've progressed a bit with the REST refactoring, I've tackled the > ToasterTables. Thanks to good quality of the existing code , changing > the layout of the URL was straightforward. > > adamian/20150515_fix_table_header > > This reduces the number of entry points for the URL, removes the ugly > hardcoding of XHR_ table urls in tables.py, and makes sure the APIs > are both human- and machine-readable. > > I'll continue with refactoring to remove the xhr_datatypeahead and > similar URL endpoints which should not have existed in the first place. > > Cheers, > Alex > > -- > Alex Damian > Yocto Project > SSG / OTC > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] adamian/20150515_fix_table_header - REST refactoring 2015-06-03 13:59 ` Michael Wood @ 2015-06-03 14:35 ` Damian, Alexandru 2015-06-04 9:25 ` Barros Pena, Belen 0 siblings, 1 reply; 6+ messages in thread From: Damian, Alexandru @ 2015-06-03 14:35 UTC (permalink / raw) To: Michael Wood; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 1910 bytes --] Thanks - I'm pushing new patches to bring more parts of the system in conformance - just removed xhr_project(info|edit) in favor of JSON-based "project" page. I will update on this thread when I tackled the bugs highlighted on the other thread, and when the new functionality is ready to merge from my POV. Alex On Wed, Jun 3, 2015 at 2:59 PM, Michael Wood <michael.g.wood@intel.com> wrote: > > 8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4 > > Looks good to me. > > Yeah that's a good idea to make ToasterTable inherit from TemplateView > rather than have it in between. > > Thanks, > > Michael > > > > On 03/06/15 14:15, Damian, Alexandru wrote: > >> Hi, >> >> I've progressed a bit with the REST refactoring, I've tackled the >> ToasterTables. Thanks to good quality of the existing code , changing the >> layout of the URL was straightforward. >> >> adamian/20150515_fix_table_header >> >> This reduces the number of entry points for the URL, removes the ugly >> hardcoding of XHR_ table urls in tables.py, and makes sure the APIs are >> both human- and machine-readable. >> >> I'll continue with refactoring to remove the xhr_datatypeahead and >> similar URL endpoints which should not have existed in the first place. >> >> Cheers, >> Alex >> >> -- >> Alex Damian >> Yocto Project >> SSG / OTC >> >> >> > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 3047 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] adamian/20150515_fix_table_header - REST refactoring 2015-06-03 14:35 ` Damian, Alexandru @ 2015-06-04 9:25 ` Barros Pena, Belen 2015-06-08 17:43 ` Damian, Alexandru 0 siblings, 1 reply; 6+ messages in thread From: Barros Pena, Belen @ 2015-06-04 9:25 UTC (permalink / raw) To: Damian, Alexandru, Wood, Michael G; +Cc: toaster@yoctoproject.org Hi Alex, I've had a quick look at this branch. Table headings are back :) but found a couple of things: * the layer dependencies check is not working. When I add a layer with dependencies, I am not prompted to add them. * the autocomplete functionality is not working. I always get the same suggestions independently of what I type * the new build button in pages belonging to a project shows the recipe text field and build buttons disabled, even though there is a project selected. * trying to change the project release throws the following error: Release matching query does not exist. Traceback (most recent call last): File "/home/yocto/master/bitbake/lib/toaster/toastergui/views.py", line 2393, in xhr_datatypeahead lv = prj.compatible_layerversions(release = Release.objects.get(pk=request.GET.get('search', None))).filter(layer__name = i.layercommit.layer.name) File "/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py", line 151, in get return self.get_queryset().get(*args, **kwargs) File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", line 307, in get self.model._meta.object_name) DoesNotExist: Release matching query does not exist. The rest seems to be working ok, as far as I can see. Thanks! On 03/06/2015 15:35, "Damian, Alexandru" <alexandru.damian@intel.com> wrote: >Thanks - > > >I'm pushing new patches to bring more parts of the system in conformance >- just removed xhr_project(info|edit) in favor of JSON-based "project" >page. > > >I will update on this thread when I tackled the bugs highlighted on the >other thread, and when the new functionality is ready to merge from my >POV. > > >Alex > > >On Wed, Jun 3, 2015 at 2:59 PM, Michael Wood ><michael.g.wood@intel.com> wrote: > > >8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4 > >Looks good to me. > >Yeah that's a good idea to make ToasterTable inherit from TemplateView >rather than have it in between. > >Thanks, > >Michael > > > >On 03/06/15 14:15, Damian, Alexandru wrote: > >Hi, > >I've progressed a bit with the REST refactoring, I've tackled the >ToasterTables. Thanks to good quality of the existing code , changing the >layout of the URL was straightforward. > >adamian/20150515_fix_table_header > >This reduces the number of entry points for the URL, removes the ugly >hardcoding of XHR_ table urls in tables.py, and makes sure the APIs are >both human- and machine-readable. > >I'll continue with refactoring to remove the xhr_datatypeahead and >similar URL endpoints which should not have existed in the first place. > >Cheers, >Alex > >-- >Alex Damian >Yocto Project >SSG / OTC > > > > > > > >--------------------------------------------------------------------- >Intel Corporation (UK) Limited >Registered No. 1134945 (England) >Registered Office: Pipers Way, Swindon SN3 1RJ >VAT No: 860 2173 47 > >This e-mail and any attachments may contain confidential material for >the sole use of the intended recipient(s). Any review or distribution >by others is strictly prohibited. If you are not the intended >recipient, please contact the sender and delete all copies. > > > > > > > > >-- >Alex Damian >Yocto Project > >SSG / OTC > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] adamian/20150515_fix_table_header - REST refactoring 2015-06-04 9:25 ` Barros Pena, Belen @ 2015-06-08 17:43 ` Damian, Alexandru 2015-06-08 17:44 ` Damian, Alexandru 0 siblings, 1 reply; 6+ messages in thread From: Damian, Alexandru @ 2015-06-08 17:43 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 3784 bytes --] Hi, I think I'm done with the URL refactoring - the patchset is here On Thu, Jun 4, 2015 at 10:25 AM, Barros Pena, Belen < belen.barros.pena@intel.com> wrote: > Hi Alex, > > I've had a quick look at this branch. Table headings are back :) but found > a couple of things: > > * the layer dependencies check is not working. When I add a layer with > dependencies, I am not prompted to add them. > * the autocomplete functionality is not working. I always get the same > suggestions independently of what I type > * the new build button in pages belonging to a project shows the recipe > text field and build buttons disabled, even though there is a project > selected. > * trying to change the project release throws the following error: > > Release matching query does not exist. > Traceback (most recent call last): > File "/home/yocto/master/bitbake/lib/toaster/toastergui/views.py", > line 2393, in xhr_datatypeahead > lv = prj.compatible_layerversions(release = > Release.objects.get(pk=request.GET.get('search', > None))).filter(layer__name = i.layercommit.layer.name) > File > "/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py", > line 151, in get > return self.get_queryset().get(*args, **kwargs) > File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", > line 307, in get > self.model._meta.object_name) > DoesNotExist: Release matching query does not exist. > > The rest seems to be working ok, as far as I can see. > > > Thanks! > > On 03/06/2015 15:35, "Damian, Alexandru" <alexandru.damian@intel.com> > wrote: > > >Thanks - > > > > > >I'm pushing new patches to bring more parts of the system in conformance > >- just removed xhr_project(info|edit) in favor of JSON-based "project" > >page. > > > > > >I will update on this thread when I tackled the bugs highlighted on the > >other thread, and when the new functionality is ready to merge from my > >POV. > > > > > >Alex > > > > > >On Wed, Jun 3, 2015 at 2:59 PM, Michael Wood > ><michael.g.wood@intel.com> wrote: > > > > > >8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4 > > > >Looks good to me. > > > >Yeah that's a good idea to make ToasterTable inherit from TemplateView > >rather than have it in between. > > > >Thanks, > > > >Michael > > > > > > > >On 03/06/15 14:15, Damian, Alexandru wrote: > > > >Hi, > > > >I've progressed a bit with the REST refactoring, I've tackled the > >ToasterTables. Thanks to good quality of the existing code , changing the > >layout of the URL was straightforward. > > > >adamian/20150515_fix_table_header > > > >This reduces the number of entry points for the URL, removes the ugly > >hardcoding of XHR_ table urls in tables.py, and makes sure the APIs are > >both human- and machine-readable. > > > >I'll continue with refactoring to remove the xhr_datatypeahead and > >similar URL endpoints which should not have existed in the first place. > > > >Cheers, > >Alex > > > >-- > >Alex Damian > >Yocto Project > >SSG / OTC > > > > > > > > > > > > > > > >--------------------------------------------------------------------- > >Intel Corporation (UK) Limited > >Registered No. 1134945 (England) > >Registered Office: Pipers Way, Swindon SN3 1RJ > >VAT No: 860 2173 47 > > > >This e-mail and any attachments may contain confidential material for > >the sole use of the intended recipient(s). Any review or distribution > >by others is strictly prohibited. If you are not the intended > >recipient, please contact the sender and delete all copies. > > > > > > > > > > > > > > > > > >-- > >Alex Damian > >Yocto Project > > > >SSG / OTC > > > > > > > > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 5320 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request] adamian/20150515_fix_table_header - REST refactoring 2015-06-08 17:43 ` Damian, Alexandru @ 2015-06-08 17:44 ` Damian, Alexandru 0 siblings, 0 replies; 6+ messages in thread From: Damian, Alexandru @ 2015-06-08 17:44 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 4208 bytes --] Sent too soon - adamian/20150603_remove_xhr_review2 Can you guys please review ? If ok, I'm going to submit. Alex On Mon, Jun 8, 2015 at 6:43 PM, Damian, Alexandru < alexandru.damian@intel.com> wrote: > Hi, > > I think I'm done with the URL refactoring - the patchset is here > > > On Thu, Jun 4, 2015 at 10:25 AM, Barros Pena, Belen < > belen.barros.pena@intel.com> wrote: > >> Hi Alex, >> >> I've had a quick look at this branch. Table headings are back :) but found >> a couple of things: >> >> * the layer dependencies check is not working. When I add a layer with >> dependencies, I am not prompted to add them. >> * the autocomplete functionality is not working. I always get the same >> suggestions independently of what I type >> * the new build button in pages belonging to a project shows the recipe >> text field and build buttons disabled, even though there is a project >> selected. >> * trying to change the project release throws the following error: >> >> Release matching query does not exist. >> Traceback (most recent call last): >> File "/home/yocto/master/bitbake/lib/toaster/toastergui/views.py", >> line 2393, in xhr_datatypeahead >> lv = prj.compatible_layerversions(release = >> Release.objects.get(pk=request.GET.get('search', >> None))).filter(layer__name = i.layercommit.layer.name) >> File >> "/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py", >> line 151, in get >> return self.get_queryset().get(*args, **kwargs) >> File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py", >> line 307, in get >> self.model._meta.object_name) >> DoesNotExist: Release matching query does not exist. >> >> The rest seems to be working ok, as far as I can see. >> >> >> Thanks! >> >> On 03/06/2015 15:35, "Damian, Alexandru" <alexandru.damian@intel.com> >> wrote: >> >> >Thanks - >> > >> > >> >I'm pushing new patches to bring more parts of the system in conformance >> >- just removed xhr_project(info|edit) in favor of JSON-based "project" >> >page. >> > >> > >> >I will update on this thread when I tackled the bugs highlighted on the >> >other thread, and when the new functionality is ready to merge from my >> >POV. >> > >> > >> >Alex >> > >> > >> >On Wed, Jun 3, 2015 at 2:59 PM, Michael Wood >> ><michael.g.wood@intel.com> wrote: >> > >> > >> >8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4 >> > >> >Looks good to me. >> > >> >Yeah that's a good idea to make ToasterTable inherit from TemplateView >> >rather than have it in between. >> > >> >Thanks, >> > >> >Michael >> > >> > >> > >> >On 03/06/15 14:15, Damian, Alexandru wrote: >> > >> >Hi, >> > >> >I've progressed a bit with the REST refactoring, I've tackled the >> >ToasterTables. Thanks to good quality of the existing code , changing the >> >layout of the URL was straightforward. >> > >> >adamian/20150515_fix_table_header >> > >> >This reduces the number of entry points for the URL, removes the ugly >> >hardcoding of XHR_ table urls in tables.py, and makes sure the APIs are >> >both human- and machine-readable. >> > >> >I'll continue with refactoring to remove the xhr_datatypeahead and >> >similar URL endpoints which should not have existed in the first place. >> > >> >Cheers, >> >Alex >> > >> >-- >> >Alex Damian >> >Yocto Project >> >SSG / OTC >> > >> > >> > >> > >> > >> > >> > >> >--------------------------------------------------------------------- >> >Intel Corporation (UK) Limited >> >Registered No. 1134945 (England) >> >Registered Office: Pipers Way, Swindon SN3 1RJ >> >VAT No: 860 2173 47 >> > >> >This e-mail and any attachments may contain confidential material for >> >the sole use of the intended recipient(s). Any review or distribution >> >by others is strictly prohibited. If you are not the intended >> >recipient, please contact the sender and delete all copies. >> > >> > >> > >> > >> > >> > >> > >> > >> >-- >> >Alex Damian >> >Yocto Project >> > >> >SSG / OTC >> > >> > >> > >> >> > > > -- > Alex Damian > Yocto Project > SSG / OTC > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 6680 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-08 17:44 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-06-03 13:15 [review-request] adamian/20150515_fix_table_header - REST refactoring Damian, Alexandru 2015-06-03 13:59 ` Michael Wood 2015-06-03 14:35 ` Damian, Alexandru 2015-06-04 9:25 ` Barros Pena, Belen 2015-06-08 17:43 ` Damian, Alexandru 2015-06-08 17:44 ` Damian, Alexandru
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.