Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1

From: "Heiko Stübner" <heiko@sntech.de>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
	Chaoyi Chen <chaoyi.chen@rock-chips.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1
Date: Mon, 09 Nov 2026 14:26:44 +0100	[thread overview]
Message-ID: <5573124.44csPzL39Z@diego> (raw)
In-Reply-To: <b60b7079-b7b6-4d83-8167-2e4fc6021aae@rock-chips.com>

Am Montag, 9. November 2026, 02:31:35 Mitteleuropäische Normalzeit schrieb Chaoyi Chen:
> Hi Sebastian,
> On 11/9/2026 3:42 AM, Sebastian Reichel wrote:
> > Hello Chaoyi,
> > 
> > On Sun, Nov 08, 2026 at 11:15:09AM +0800, Chaoyi Chen wrote:
> >> Hi Sebastian,
> >>
> >> On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> >>> The RK3588 EVB1 comes with a W552793DBA-V10 Touchscreen/Display
> >>> combination. It contains a Wanchanglong W552793BAA panel and a
> >>> Goodix GT1158 touchscreen. This adds the DT description of it.
> >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >>> ---
> >>>  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 90 ++++++++++++++++++++++++
> >>>  1 file changed, 90 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> >>> index 6a95a8bb6fb8..327ca13b60f0 100644
> >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> >>> @@ -204,6 +204,15 @@ vcc12v_dcin: regulator-vcc12v-dcin {
> >>>  		regulator-max-microvolt = <12000000>;
> >>>  	};
> >>>  
> >>
> >> I seem unable to apply the patch to the latest linux-next tree.
> >>
> >> So I tried to resolve the conflict manually, but the actual
> >> test screen did not display. I will look into this further.
> > 
> > Strange. The base of this series was Heiko's for-next tree from
> > Friday. No RK3588 EVB1 patches landed since then:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=cabb6811c38a46337d5f4252b4dc390f9296856c
> > 
> > If your board uses the original Rockchip bootloader, which shows a
> > Rockchip logo on the panel, you also need Cristian's latest YUV420
> > patches that reset VOP2 at probe time avoiding some issues with the
> > pre-initialized panel as a side effect. Those were recently applied
> > by Heiko to the DRM tree, so testing on linux-next is indeed
> > sensible.
> > 
> 
> Hmm, the newest linux-next tag which I used is next-20261105, and Heiko's 
> tree last updated date is1106. I'll give it a try on Heiko's tree.
> 
> And I'm using mainline U-Boot, which obtained from the latest nightly build:
> https://gitlab.collabora.com/hardware-enablement/rockchip-3588/debian-image-recipes.
> 
> The backlight working correctly, and the DCS command has been sent, but nothing display.
> Perhaps I should look elsewhere.

I would assume it could be the SPLL (again).

I.e. a recent u-boot change broke the SPL-based forced clock init and Jonas
fixed that in [0]. Had the black display again recently too.

And it seems it hasn't been merged yet.

Heiko

[0] https://lore.kernel.org/u-boot/20260804002643.2308515-3-jonas@kwiboo.se/