Re: [PATCH 2/5] arm64: dts: rockchip: Enable NPU on RK3588 EVB1

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>
Cc: Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 2/5] arm64: dts: rockchip: Enable NPU on RK3588 EVB1
Date: Sun, 8 Nov 2026 20:29:15 +0100	[thread overview]
Message-ID: <avDLdgR6gXOrEmNN@venus> (raw)
In-Reply-To: <f5edf258-4b6d-416a-9b27-efa47be8d91a@rock-chips.com>

[-- Attachment #1.1: Type: text/plain, Size: 2108 bytes --]

Hi,

On Sun, Nov 08, 2026 at 10:03:05AM +0800, Chaoyi Chen wrote:
> On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> > Also enable the NPU on the RK3588 EVB1, which is very similar to
> > the QuartzPro64.
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> 
> I remember there was already a similar patch before?
> Maybe I got something wrong.

TBH I haven't checked before sending this, but did now and there
doesn't seem to be anything:

https://lore.kernel.org/all/?q=file=arch%2Farm64%2Fboot%2Fdts%2Frockchip%2Frk3588-evb1-v10.dts

Greetings,

-- Sebastian

> 
> Reviewed-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> >  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 34 ++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > index 87e624d1e094..6476d9e3be6f 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > @@ -578,6 +578,10 @@ &pd_gpu {
> >  	domain-supply = <&vdd_gpu_s0>;
> >  };
> >  
> > +&pd_npu {
> > +	domain-supply = <&vdd_npu_s0>;
> > +};
> > +
> >  &pd_rkvdec0 {
> >  	domain-supply = <&vdd_vdenc_s0>;
> >  };
> > @@ -703,6 +707,36 @@ &pwm2 {
> >  	status = "okay";
> >  };
> >  
> > +&rknn_core_0 {
> > +	npu-supply = <&vdd_npu_s0>;
> > +	sram-supply = <&vdd_npu_mem_s0>;
> > +	status = "okay";
> > +};
> > +
> > +&rknn_core_1 {
> > +	npu-supply = <&vdd_npu_s0>;
> > +	sram-supply = <&vdd_npu_mem_s0>;
> > +	status = "okay";
> > +};
> > +
> > +&rknn_core_2 {
> > +	npu-supply = <&vdd_npu_s0>;
> > +	sram-supply = <&vdd_npu_mem_s0>;
> > +	status = "okay";
> > +};
> > +
> > +&rknn_mmu_0 {
> > +	status = "okay";
> > +};
> > +
> > +&rknn_mmu_1 {
> > +	status = "okay";
> > +};
> > +
> > +&rknn_mmu_2 {
> > +	status = "okay";
> > +};
> > +
> >  &saradc {
> >  	vref-supply = <&vcc_1v8_s0>;
> >  	status = "okay";
> > 
> 
> -- 
> Best, 
> Chaoyi
> 
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip