Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>
Cc: Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1
Date: Sun, 8 Nov 2026 20:42:32 +0100	[thread overview]
Message-ID: <avDN3pPY5Qwt9B1p@venus> (raw)
In-Reply-To: <f066ac3f-1720-479b-a2e9-198a96d03dd6@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]

Hello Chaoyi,

On Sun, Nov 08, 2026 at 11:15:09AM +0800, Chaoyi Chen wrote:
> Hi Sebastian,
> 
> On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> > The RK3588 EVB1 comes with a W552793DBA-V10 Touchscreen/Display
> > combination. It contains a Wanchanglong W552793BAA panel and a
> > Goodix GT1158 touchscreen. This adds the DT description of it.
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 90 ++++++++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > index 6a95a8bb6fb8..327ca13b60f0 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > @@ -204,6 +204,15 @@ vcc12v_dcin: regulator-vcc12v-dcin {
> >  		regulator-max-microvolt = <12000000>;
> >  	};
> >  
> 
> I seem unable to apply the patch to the latest linux-next tree.
> 
> So I tried to resolve the conflict manually, but the actual
> test screen did not display. I will look into this further.

Strange. The base of this series was Heiko's for-next tree from
Friday. No RK3588 EVB1 patches landed since then:

https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=cabb6811c38a46337d5f4252b4dc390f9296856c

If your board uses the original Rockchip bootloader, which shows a
Rockchip logo on the panel, you also need Cristian's latest YUV420
patches that reset VOP2 at probe time avoiding some issues with the
pre-initialized panel as a side effect. Those were recently applied
by Heiko to the DRM tree, so testing on linux-next is indeed
sensible.

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]