xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Fabio Fantoni]

I saw that config/Paths.mk contains:
XEN_DUMP_DIR             := /var/lib/xen/dump

But build fails with:
> xl_cmdimpl.c: In function âhandle_domain_deathâ:
> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in 
> this function)
> xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported 
> only once for each function it appears in
> xl_cmdimpl.c:2330:46: error: expected â)â before string constant

With a fast look in code I not found the right cause.


Thanks for any reply and sorry for my bad english.

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Wei Liu]

On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
> I saw that config/Paths.mk contains:
> XEN_DUMP_DIR             := /var/lib/xen/dump
> 
> But build fails with:
> >xl_cmdimpl.c: In function âhandle_domain_deathâ:
> >xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
> >function)
> >xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
> >once for each function it appears in
> >xl_cmdimpl.c:2330:46: error: expected â)â before string constant
> 
> With a fast look in code I not found the right cause.
> 
> 
> Thanks for any reply and sorry for my bad english.

Our testing system doesn't complain about this.

Maybe you have some stale files lying around? Try make distclean then
make again?

Wei.

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Fabio Fantoni]

Il 08/06/2015 13:28, Wei Liu ha scritto:
> On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
>> I saw that config/Paths.mk contains:
>> XEN_DUMP_DIR             := /var/lib/xen/dump
>>
>> But build fails with:
>>> xl_cmdimpl.c: In function âhandle_domain_deathâ:
>>> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
>>> function)
>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
>>> once for each function it appears in
>>> xl_cmdimpl.c:2330:46: error: expected â)â before string constant
>> With a fast look in code I not found the right cause.
>>
>>
>> Thanks for any reply and sorry for my bad english.
> Our testing system doesn't complain about this.
>
> Maybe you have some stale files lying around? Try make distclean then
> make again?
>
> Wei.

Thanks for your reply.

I add some my patches not related: 
https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already tested 
for at least some days.

I tried another clean build without my patches (git reset --hard ... git 
clean -f -d -x) but still fails.

I did this operations:
./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional 
--disable-rombios --with-system-seabios=/usr/share/seabios/bios-256k.bin 
--with-extra-qemuu-configure-args="--enable-spice --enable-usb-redir" 
--disable-blktap2 --enable-ovmf --with-system-ovmf=/usr/share/ovmf/OVMF.fd
make debball

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Wei Liu]

On Mon, Jun 08, 2015 at 02:36:09PM +0200, Fabio Fantoni wrote:
> Il 08/06/2015 13:28, Wei Liu ha scritto:
> >On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
> >>I saw that config/Paths.mk contains:
> >>XEN_DUMP_DIR             := /var/lib/xen/dump
> >>
> >>But build fails with:
> >>>xl_cmdimpl.c: In function âhandle_domain_deathâ:
> >>>xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
> >>>function)
> >>>xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
> >>>once for each function it appears in
> >>>xl_cmdimpl.c:2330:46: error: expected â)â before string constant
> >>With a fast look in code I not found the right cause.
> >>
> >>
> >>Thanks for any reply and sorry for my bad english.
> >Our testing system doesn't complain about this.
> >
> >Maybe you have some stale files lying around? Try make distclean then
> >make again?
> >
> >Wei.
> 
> Thanks for your reply.
> 
> I add some my patches not related:
> https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already tested for
> at least some days.
> 
> I tried another clean build without my patches (git reset --hard ... git
> clean -f -d -x) but still fails.
> 
> I did this operations:
> ./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional
> --disable-rombios --with-system-seabios=/usr/share/seabios/bios-256k.bin
> --with-extra-qemuu-configure-args="--enable-spice --enable-usb-redir"
> --disable-blktap2 --enable-ovmf --with-system-ovmf=/usr/share/ovmf/OVMF.fd
> make debball

Have you checked if libxl/_paths.h is generated?

I don't think I spot anything suspicious in commit log and your build
rune.

Wei.

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Fabio Fantoni]

Il 08/06/2015 15:30, Wei Liu ha scritto:
> On Mon, Jun 08, 2015 at 02:36:09PM +0200, Fabio Fantoni wrote:
>> Il 08/06/2015 13:28, Wei Liu ha scritto:
>>> On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
>>>> I saw that config/Paths.mk contains:
>>>> XEN_DUMP_DIR             := /var/lib/xen/dump
>>>>
>>>> But build fails with:
>>>>> xl_cmdimpl.c: In function âhandle_domain_deathâ:
>>>>> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
>>>>> function)
>>>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
>>>>> once for each function it appears in
>>>>> xl_cmdimpl.c:2330:46: error: expected â)â before string constant
>>>> With a fast look in code I not found the right cause.
>>>>
>>>>
>>>> Thanks for any reply and sorry for my bad english.
>>> Our testing system doesn't complain about this.
>>>
>>> Maybe you have some stale files lying around? Try make distclean then
>>> make again?
>>>
>>> Wei.
>> Thanks for your reply.
>>
>> I add some my patches not related:
>> https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already tested for
>> at least some days.
>>
>> I tried another clean build without my patches (git reset --hard ... git
>> clean -f -d -x) but still fails.
>>
>> I did this operations:
>> ./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional
>> --disable-rombios --with-system-seabios=/usr/share/seabios/bios-256k.bin
>> --with-extra-qemuu-configure-args="--enable-spice --enable-usb-redir"
>> --disable-blktap2 --enable-ovmf --with-system-ovmf=/usr/share/ovmf/OVMF.fd
>> make debball
> Have you checked if libxl/_paths.h is generated?
>
> I don't think I spot anything suspicious in commit log and your build
> rune.
>
> Wei.

I checked tools/libxl/_paths.h, generated with many lines but 
XEN_DUMP_DIR is missed.
> #define SBINDIR ""
> #define BINDIR ""
> #define LIBEXEC "/usr/lib/xen"
> #define LIBEXEC_BIN "/usr/lib/xen/bin"
> #define LIBDIR ""
> #define SHAREDIR "/usr/share"
> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
> #define XEN_CONFIG_DIR "/etc/xen"
> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
> #define XEN_LOCK_DIR "/var/lock"
> #define XEN_RUN_DIR "/var/run/xen"
> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
config/Paths.mk instead contain it correctly.
I checked the commit 
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bf36d0792032a0245e4a17a64c8b9eb9e056f282 
but not add something about libxl/_paths.h and in it there aren't all 
path present in config.
I suppose that something is missed or there inexpected case that cause 
partial libxl/_paths.h generation (seems more probable the first case).

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Andrew Cooper]

On 08/06/15 14:49, Fabio Fantoni wrote:
> Il 08/06/2015 15:30, Wei Liu ha scritto:
>> On Mon, Jun 08, 2015 at 02:36:09PM +0200, Fabio Fantoni wrote:
>>> Il 08/06/2015 13:28, Wei Liu ha scritto:
>>>> On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
>>>>> I saw that config/Paths.mk contains:
>>>>> XEN_DUMP_DIR             := /var/lib/xen/dump
>>>>>
>>>>> But build fails with:
>>>>>> xl_cmdimpl.c: In function âhandle_domain_deathâ:
>>>>>> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use
>>>>>> in this
>>>>>> function)
>>>>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is
>>>>>> reported only
>>>>>> once for each function it appears in
>>>>>> xl_cmdimpl.c:2330:46: error: expected â)â before string constant
>>>>> With a fast look in code I not found the right cause.
>>>>>
>>>>>
>>>>> Thanks for any reply and sorry for my bad english.
>>>> Our testing system doesn't complain about this.
>>>>
>>>> Maybe you have some stale files lying around? Try make distclean then
>>>> make again?
>>>>
>>>> Wei.
>>> Thanks for your reply.
>>>
>>> I add some my patches not related:
>>> https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already
>>> tested for
>>> at least some days.
>>>
>>> I tried another clean build without my patches (git reset --hard ...
>>> git
>>> clean -f -d -x) but still fails.
>>>
>>> I did this operations:
>>> ./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional
>>> --disable-rombios
>>> --with-system-seabios=/usr/share/seabios/bios-256k.bin
>>> --with-extra-qemuu-configure-args="--enable-spice --enable-usb-redir"
>>> --disable-blktap2 --enable-ovmf
>>> --with-system-ovmf=/usr/share/ovmf/OVMF.fd
>>> make debball
>> Have you checked if libxl/_paths.h is generated?
>>
>> I don't think I spot anything suspicious in commit log and your build
>> rune.
>>
>> Wei.
>
> I checked tools/libxl/_paths.h, generated with many lines but
> XEN_DUMP_DIR is missed.
>> #define SBINDIR ""
>> #define BINDIR ""
>> #define LIBEXEC "/usr/lib/xen"
>> #define LIBEXEC_BIN "/usr/lib/xen/bin"
>> #define LIBDIR ""
>> #define SHAREDIR "/usr/share"
>> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
>> #define XEN_CONFIG_DIR "/etc/xen"
>> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
>> #define XEN_LOCK_DIR "/var/lock"
>> #define XEN_RUN_DIR "/var/run/xen"
>> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
> config/Paths.mk instead contain it correctly.
> I checked the commit
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bf36d0792032a0245e4a17a64c8b9eb9e056f282
> but not add something about libxl/_paths.h and in it there aren't all
> path present in config.
> I suppose that something is missed or there inexpected case that cause
> partial libxl/_paths.h generation (seems more probable the first case).

On staging, you generally have to re-./configure and `make clean` regularly.

In particular, there was
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bf36d0792032a0245e4a17a64c8b9eb9e056f282
recently which altered XEN_DUMP_DIR handling.

~Andrew

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Wei Liu]

On Mon, Jun 08, 2015 at 03:49:24PM +0200, Fabio Fantoni wrote:
> Il 08/06/2015 15:30, Wei Liu ha scritto:
> >On Mon, Jun 08, 2015 at 02:36:09PM +0200, Fabio Fantoni wrote:
> >>Il 08/06/2015 13:28, Wei Liu ha scritto:
> >>>On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
> >>>>I saw that config/Paths.mk contains:
> >>>>XEN_DUMP_DIR             := /var/lib/xen/dump
> >>>>
> >>>>But build fails with:
> >>>>>xl_cmdimpl.c: In function âhandle_domain_deathâ:
> >>>>>xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
> >>>>>function)
> >>>>>xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
> >>>>>once for each function it appears in
> >>>>>xl_cmdimpl.c:2330:46: error: expected â)â before string constant
> >>>>With a fast look in code I not found the right cause.
> >>>>
> >>>>
> >>>>Thanks for any reply and sorry for my bad english.
> >>>Our testing system doesn't complain about this.
> >>>
> >>>Maybe you have some stale files lying around? Try make distclean then
> >>>make again?
> >>>
> >>>Wei.
> >>Thanks for your reply.
> >>
> >>I add some my patches not related:
> >>https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already tested for
> >>at least some days.
> >>
> >>I tried another clean build without my patches (git reset --hard ... git
> >>clean -f -d -x) but still fails.
> >>
> >>I did this operations:
> >>./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional
> >>--disable-rombios --with-system-seabios=/usr/share/seabios/bios-256k.bin
> >>--with-extra-qemuu-configure-args="--enable-spice --enable-usb-redir"
> >>--disable-blktap2 --enable-ovmf --with-system-ovmf=/usr/share/ovmf/OVMF.fd
> >>make debball
> >Have you checked if libxl/_paths.h is generated?
> >
> >I don't think I spot anything suspicious in commit log and your build
> >rune.
> >
> >Wei.
> 
> I checked tools/libxl/_paths.h, generated with many lines but XEN_DUMP_DIR
> is missed.
> >#define SBINDIR ""
> >#define BINDIR ""
> >#define LIBEXEC "/usr/lib/xen"
> >#define LIBEXEC_BIN "/usr/lib/xen/bin"
> >#define LIBDIR ""
> >#define SHAREDIR "/usr/share"
> >#define XENFIRMWAREDIR "/usr/lib/xen/boot"
> >#define XEN_CONFIG_DIR "/etc/xen"
> >#define XEN_SCRIPT_DIR "/etc/xen/scripts"
> >#define XEN_LOCK_DIR "/var/lock"
> >#define XEN_RUN_DIR "/var/run/xen"
> >#define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
> config/Paths.mk instead contain it correctly.
> I checked the commit http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bf36d0792032a0245e4a17a64c8b9eb9e056f282
> but not add something about libxl/_paths.h and in it there aren't all path
> present in config.
> I suppose that something is missed or there inexpected case that cause
> partial libxl/_paths.h generation (seems more probable the first case).

I just tried and it worked. This is the rune I used (run in top level
directory):

./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional --disable-rombios --disable-blktpa2 --enable-ovmf

I don't have customised built seabios and ovmf so I omitted those.

The commit I use is ecdae1cfaa7f6123decaa1b9d7205c3ff726b941.

Could you verify you see the same error with the exact rune and commit I
used?

Wei.

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Fabio Fantoni]

Il 08/06/2015 15:56, Wei Liu ha scritto:
> On Mon, Jun 08, 2015 at 03:49:24PM +0200, Fabio Fantoni wrote:
>> Il 08/06/2015 15:30, Wei Liu ha scritto:
>>> On Mon, Jun 08, 2015 at 02:36:09PM +0200, Fabio Fantoni wrote:
>>>> Il 08/06/2015 13:28, Wei Liu ha scritto:
>>>>> On Mon, Jun 08, 2015 at 01:25:05PM +0200, Fabio Fantoni wrote:
>>>>>> I saw that config/Paths.mk contains:
>>>>>> XEN_DUMP_DIR             := /var/lib/xen/dump
>>>>>>
>>>>>> But build fails with:
>>>>>>> xl_cmdimpl.c: In function âhandle_domain_deathâ:
>>>>>>> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
>>>>>>> function)
>>>>>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
>>>>>>> once for each function it appears in
>>>>>>> xl_cmdimpl.c:2330:46: error: expected â)â before string constant
>>>>>> With a fast look in code I not found the right cause.
>>>>>>
>>>>>>
>>>>>> Thanks for any reply and sorry for my bad english.
>>>>> Our testing system doesn't complain about this.
>>>>>
>>>>> Maybe you have some stale files lying around? Try make distclean then
>>>>> make again?
>>>>>
>>>>> Wei.
>>>> Thanks for your reply.
>>>>
>>>> I add some my patches not related:
>>>> https://github.com/Fantu/Xen/tree/rebase/m2r-staging all already tested for
>>>> at least some days.
>>>>
>>>> I tried another clean build without my patches (git reset --hard ... git
>>>> clean -f -d -x) but still fails.
>>>>
>>>> I did this operations:
>>>> ./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional
>>>> --disable-rombios --with-system-seabios=/usr/share/seabios/bios-256k.bin
>>>> --with-extra-qemuu-configure-args="--enable-spice --enable-usb-redir"
>>>> --disable-blktap2 --enable-ovmf --with-system-ovmf=/usr/share/ovmf/OVMF.fd
>>>> make debball
>>> Have you checked if libxl/_paths.h is generated?
>>>
>>> I don't think I spot anything suspicious in commit log and your build
>>> rune.
>>>
>>> Wei.
>> I checked tools/libxl/_paths.h, generated with many lines but XEN_DUMP_DIR
>> is missed.
>>> #define SBINDIR ""
>>> #define BINDIR ""
>>> #define LIBEXEC "/usr/lib/xen"
>>> #define LIBEXEC_BIN "/usr/lib/xen/bin"
>>> #define LIBDIR ""
>>> #define SHAREDIR "/usr/share"
>>> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
>>> #define XEN_CONFIG_DIR "/etc/xen"
>>> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
>>> #define XEN_LOCK_DIR "/var/lock"
>>> #define XEN_RUN_DIR "/var/run/xen"
>>> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
>> config/Paths.mk instead contain it correctly.
>> I checked the commit http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bf36d0792032a0245e4a17a64c8b9eb9e056f282
>> but not add something about libxl/_paths.h and in it there aren't all path
>> present in config.
>> I suppose that something is missed or there inexpected case that cause
>> partial libxl/_paths.h generation (seems more probable the first case).
> I just tried and it worked. This is the rune I used (run in top level
> directory):
>
> ./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional --disable-rombios --disable-blktpa2 --enable-ovmf
>
> I don't have customised built seabios and ovmf so I omitted those.
>
> The commit I use is ecdae1cfaa7f6123decaa1b9d7205c3ff726b941.
>
> Could you verify you see the same error with the exact rune and commit I
> used?
>
> Wei.

I tried changing the configure options (the your above with blktap2 type 
fix) works.
I'll try to found what exactly cause the inexpected case.

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Wei Liu]

On Mon, Jun 08, 2015 at 04:44:05PM +0200, Fabio Fantoni wrote:
[...]
> >>config/Paths.mk instead contain it correctly.
> >>I checked the commit http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=bf36d0792032a0245e4a17a64c8b9eb9e056f282
> >>but not add something about libxl/_paths.h and in it there aren't all path
> >>present in config.
> >>I suppose that something is missed or there inexpected case that cause
> >>partial libxl/_paths.h generation (seems more probable the first case).
> >I just tried and it worked. This is the rune I used (run in top level
> >directory):
> >
> >./configure --prefix=/usr --disable-blktap1 --disable-qemu-traditional --disable-rombios --disable-blktpa2 --enable-ovmf
> >
> >I don't have customised built seabios and ovmf so I omitted those.
> >
> >The commit I use is ecdae1cfaa7f6123decaa1b9d7205c3ff726b941.
> >
> >Could you verify you see the same error with the exact rune and commit I
> >used?
> >
> >Wei.
> 
> I tried changing the configure options (the your above with blktap2 type
> fix) works.

Sorry about the typo.

Looks like there are only a few suspicious options left. It should be
easy to figure out which one causes your problem.

> I'll try to found what exactly cause the inexpected case.

Let me know the issue so that I can fix it for you. Of course if you
want to write a patch yourself it is also fine. :-)

Wei.

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Olaf Hering]

On Mon, Jun 08, Fabio Fantoni wrote:

> I saw that config/Paths.mk contains:
> XEN_DUMP_DIR             := /var/lib/xen/dump
> 
> But build fails with:
> >xl_cmdimpl.c: In function âhandle_domain_deathâ:
> >xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
> >function)
> >xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
> >once for each function it appears in
> >xl_cmdimpl.c:2330:46: error: expected â)â before string constant
> 
> With a fast look in code I not found the right cause.

The logic in the Makefile is supposed to regenerate _paths.h if anything
within that file changes. Appearently that logic does not work properly.

As suggested a 'make clean' or 'rm tools/*/_*.h' should work around such
bug.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Fabio Fantoni]

Il 09/06/2015 09:02, Olaf Hering ha scritto:
> On Mon, Jun 08, Fabio Fantoni wrote:
>
>> I saw that config/Paths.mk contains:
>> XEN_DUMP_DIR             := /var/lib/xen/dump
>>
>> But build fails with:
>>> xl_cmdimpl.c: In function âhandle_domain_deathâ:
>>> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this
>>> function)
>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported only
>>> once for each function it appears in
>>> xl_cmdimpl.c:2330:46: error: expected â)â before string constant
>> With a fast look in code I not found the right cause.
> The logic in the Makefile is supposed to regenerate _paths.h if anything
> within that file changes. Appearently that logic does not work properly.
>
> As suggested a 'make clean' or 'rm tools/*/_*.h' should work around such
> bug.
>
> Olaf

'make clean' or 'rm tools/*/_*.h' as workaround didn't works, problem 
still happen.

I already use git reset --hard and git git clean -f -d -x before any 
test that clean all except other git repos (seabios, ovmf and qemu).

I missed to tell I use also a change I did for workaround in Config.mk:
PYTHON_PREFIX_ARG ?= --prefix="$(prefix)" to PYTHON_PREFIX_ARG ?=

Probably it in combination with one or more ./configure options that 
have a regression.

I'm testing with this: 
https://github.com/Fantu/Xen/commits/rebase/m2r-staging and was working 
until https://github.com/Fantu/Xen/commits/rebase/m2r-next
Is simply a rebase and only the first patch had a conflict for this 
commit: 7f5f57b466b026d19cacfe7fc5771895d05a053b

The regression should be between upstream commit 
f48218fd2d35e274ef58caee889aecd6610c8cb6 and 
ecdae1cfaa7f6123decaa1b9d7205c3ff726b941


Without problem tools/libxl/_paths.h is correctly generated:
> #define sbindir "/usr/sbin"
> #define bindir "/usr/bin"
> #define LIBEXEC "/usr/lib/xen"
> #define LIBEXEC_BIN "/usr/lib/xen/bin"
> #define libdir "/usr/lib"
> #define SHAREDIR "/usr/share"
> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
> #define XEN_CONFIG_DIR "/etc/xen"
> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
> #define XEN_LOCK_DIR "/var/lock"
> #define XEN_RUN_DIR "/var/run/xen"
> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
> #define XEN_DUMP_DIR "/var/lib/xen/dump"

With the problem instead:
> #define SBINDIR ""
> #define BINDIR ""
> #define LIBEXEC "/usr/lib/xen"
> #define LIBEXEC_BIN "/usr/lib/xen/bin"
> #define LIBDIR ""
> #define SHAREDIR "/usr/share"
> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
> #define XEN_CONFIG_DIR "/etc/xen"
> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
> #define XEN_LOCK_DIR "/var/lock"
> #define XEN_RUN_DIR "/var/run/xen"
> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"

I'm still trying various combinations but I have a problem to found the 
exactly parameters that cause the problem, some restult are 
strange...I'm going crazy :(

During testing I had also this:
> ovmf.c: In function âovmf_loadâ:
> ovmf.c:100:21: error: âovmfâ undeclared (first use in this function)
> ovmf.c:100:21: note: each undeclared identifier is reported only once 
> for each function it appears in
> ovmf.c: At top level:
> ovmf.c:154:14: error: âovmfâ undeclared here (not in a function)
Probably because I tried before with build ovmf and after with prebuild 
from system that cause an inexpected case.




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

[Fabio Fantoni]

Il 09/06/2015 12:54, Fabio Fantoni ha scritto:
> Il 09/06/2015 09:02, Olaf Hering ha scritto:
>> On Mon, Jun 08, Fabio Fantoni wrote:
>>
>>> I saw that config/Paths.mk contains:
>>> XEN_DUMP_DIR             := /var/lib/xen/dump
>>>
>>> But build fails with:
>>>> xl_cmdimpl.c: In function âhandle_domain_deathâ:
>>>> xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use 
>>>> in this
>>>> function)
>>>> xl_cmdimpl.c:2330:33: note: each undeclared identifier is reported 
>>>> only
>>>> once for each function it appears in
>>>> xl_cmdimpl.c:2330:46: error: expected â)â before string constant
>>> With a fast look in code I not found the right cause.
>> The logic in the Makefile is supposed to regenerate _paths.h if anything
>> within that file changes. Appearently that logic does not work properly.
>>
>> As suggested a 'make clean' or 'rm tools/*/_*.h' should work around such
>> bug.
>>
>> Olaf
>
> 'make clean' or 'rm tools/*/_*.h' as workaround didn't works, problem 
> still happen.
>
> I already use git reset --hard and git git clean -f -d -x before any 
> test that clean all except other git repos (seabios, ovmf and qemu).
>
> I missed to tell I use also a change I did for workaround in Config.mk:
> PYTHON_PREFIX_ARG ?= --prefix="$(prefix)" to PYTHON_PREFIX_ARG ?=
>
> Probably it in combination with one or more ./configure options that 
> have a regression.
>
> I'm testing with this: 
> https://github.com/Fantu/Xen/commits/rebase/m2r-staging and was 
> working until https://github.com/Fantu/Xen/commits/rebase/m2r-next
> Is simply a rebase and only the first patch had a conflict for this 
> commit: 7f5f57b466b026d19cacfe7fc5771895d05a053b

Problem found, I not saw other Config.mk changes during conflict on 
rebase, I'm stupid, sorry.

>
> The regression should be between upstream commit 
> f48218fd2d35e274ef58caee889aecd6610c8cb6 and 
> ecdae1cfaa7f6123decaa1b9d7205c3ff726b941
>
>
> Without problem tools/libxl/_paths.h is correctly generated:
>> #define sbindir "/usr/sbin"
>> #define bindir "/usr/bin"
>> #define LIBEXEC "/usr/lib/xen"
>> #define LIBEXEC_BIN "/usr/lib/xen/bin"
>> #define libdir "/usr/lib"
>> #define SHAREDIR "/usr/share"
>> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
>> #define XEN_CONFIG_DIR "/etc/xen"
>> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
>> #define XEN_LOCK_DIR "/var/lock"
>> #define XEN_RUN_DIR "/var/run/xen"
>> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
>> #define XEN_DUMP_DIR "/var/lib/xen/dump"
>
> With the problem instead:
>> #define SBINDIR ""
>> #define BINDIR ""
>> #define LIBEXEC "/usr/lib/xen"
>> #define LIBEXEC_BIN "/usr/lib/xen/bin"
>> #define LIBDIR ""
>> #define SHAREDIR "/usr/share"
>> #define XENFIRMWAREDIR "/usr/lib/xen/boot"
>> #define XEN_CONFIG_DIR "/etc/xen"
>> #define XEN_SCRIPT_DIR "/etc/xen/scripts"
>> #define XEN_LOCK_DIR "/var/lock"
>> #define XEN_RUN_DIR "/var/run/xen"
>> #define XEN_PAGING_DIR "/var/lib/xen/xenpaging"
>
> I'm still trying various combinations but I have a problem to found 
> the exactly parameters that cause the problem, some restult are 
> strange...I'm going crazy :(
>
> During testing I had also this:
>> ovmf.c: In function âovmf_loadâ:
>> ovmf.c:100:21: error: âovmfâ undeclared (first use in this function)
>> ovmf.c:100:21: note: each undeclared identifier is reported only once 
>> for each function it appears in
>> ovmf.c: At top level:
>> ovmf.c:154:14: error: âovmfâ undeclared here (not in a function)
> Probably because I tried before with build ovmf and after with 
> prebuild from system that cause an inexpected case

This and probably another (that I not remember exactly) are the only 
upstream minor problems caused by rare unexpected case.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel