From: Ben Greear <greearb@candelatech.com>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Michal Kazior <michal.kazior@tieto.com>,
ath10k <ath10k@lists.infradead.org>
Subject: Re: Question on beacon-miss offloading.
Date: Fri, 12 Jun 2015 08:22:13 -0700 [thread overview]
Message-ID: <557AF925.4000609@candelatech.com> (raw)
In-Reply-To: <CABPxzYK6LWZW1JWoBBTs_QPWtupU17Pr7w3J-H6=QD1Xd5uLrg@mail.gmail.com>
On 06/12/2015 07:10 AM, Krishna Chaitanya wrote:
> On Fri, Jun 12, 2015 at 6:59 PM, Ben Greear <greearb@candelatech.com> wrote:
>>
>>
>> On 06/11/2015 11:03 PM, Michal Kazior wrote:
>>>
>>> On 12 June 2015 at 01:38, Ben Greear <greearb@candelatech.com> wrote:
>>>>
>>>> On 06/11/2015 02:07 PM, Ben Greear wrote:
>>>>>
>>>>> In my ath10k CT firmware, I am disabling the beacon-miss offloading
>>>>> to save space and because it will not work with lots of virtual
>>>>> stations.
>>>>>
>>>>> But, it must be that I need some way to tell the stack that this
>>>>> feature is not enabled, because when suddenly kill my AP, then
>>>>> the ath10k station connected to it shows endless 'beacon loss' events
>>>>> in 'iw events' output, but it never actually loses connection.
>>>>>
>>>>> Stock firmware works fine, so probably I just need to disable
>>>>> some feature flag when registering the ath10k hardware
>>>>> when using CT firmware.
>>>>>
>>>>> With stock firmware, I see a quick dissassociation due to inactivity.
>>>>>
>>>>> I am having poor luck finding how a driver tells the stack
>>>>> it has beacon miss offload or not, so, does anyone know how
>>>>> this is controlled?
>>>>
>>>>
>>>> I still am not sure why stock firmware works, but it appears
>>>> the reason mine is failing is that the ACK status for mgt frames
>>>> is always set to TRUE since the ath10k wmi-mgt-tx API is so
>>>> lame. So, mac80211 does a probe, ath10k lies and says it was
>>>> acked, and mac80211 then things all is well for another few
>>>> seconds.
>>>
>>>
>>> mac80211 shouldn't do a Probe Req to an AP on beacon loss because
>>> ath10k advertises it supports tx-status report. Hence mac80211 should
>>> use NullFunc frames which shouldn't go through wmi-mgmt-tx but htt
>>> tx-frm.
>>>
>>> But then again: NullFunc status reporting via htt tx-frm was broken on
>>> 10.1 if memory serves right. I believe it was fixed in 10.2 or 10.2.4.
>>>
>>> This problem has been effectively obscured on stock 10.1 by the
>>> offloaded beacon miss.
>>
>>
>> For what it's worth, I looked at the 4.0.4 ath10k yesterday, and it appears
>> it
>> ignores the message that the 10.1 firmware sends when beacon loss happens
>> anyway. Maybe I misread the firmware code..it's a pile of indirection.
>>
>> Do you know how the firmware is supposed to signal beacon loss to
>> the host (from the host's perspective).
>
> Normally driver would advertise IEEE80211_HW_CONNECTION_MONITOR
> to disable mac80211 from tracking connection. and driver should call
> ieee80211_beacon_loss up on receiving beacon loss event from FW
> which triggers disconnection in mac80211.
I do not see any calls to beacon_loss() in the ath10k driver,
so probably that firmware feature is not just fully wired up
to the driver. Just as well since that firmware feature is
disabled in my (-diet variant) firmware entirely.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
ath10k <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Question on beacon-miss offloading.
Date: Fri, 12 Jun 2015 08:22:13 -0700 [thread overview]
Message-ID: <557AF925.4000609@candelatech.com> (raw)
In-Reply-To: <CABPxzYK6LWZW1JWoBBTs_QPWtupU17Pr7w3J-H6=QD1Xd5uLrg@mail.gmail.com>
On 06/12/2015 07:10 AM, Krishna Chaitanya wrote:
> On Fri, Jun 12, 2015 at 6:59 PM, Ben Greear <greearb@candelatech.com> wrote:
>>
>>
>> On 06/11/2015 11:03 PM, Michal Kazior wrote:
>>>
>>> On 12 June 2015 at 01:38, Ben Greear <greearb@candelatech.com> wrote:
>>>>
>>>> On 06/11/2015 02:07 PM, Ben Greear wrote:
>>>>>
>>>>> In my ath10k CT firmware, I am disabling the beacon-miss offloading
>>>>> to save space and because it will not work with lots of virtual
>>>>> stations.
>>>>>
>>>>> But, it must be that I need some way to tell the stack that this
>>>>> feature is not enabled, because when suddenly kill my AP, then
>>>>> the ath10k station connected to it shows endless 'beacon loss' events
>>>>> in 'iw events' output, but it never actually loses connection.
>>>>>
>>>>> Stock firmware works fine, so probably I just need to disable
>>>>> some feature flag when registering the ath10k hardware
>>>>> when using CT firmware.
>>>>>
>>>>> With stock firmware, I see a quick dissassociation due to inactivity.
>>>>>
>>>>> I am having poor luck finding how a driver tells the stack
>>>>> it has beacon miss offload or not, so, does anyone know how
>>>>> this is controlled?
>>>>
>>>>
>>>> I still am not sure why stock firmware works, but it appears
>>>> the reason mine is failing is that the ACK status for mgt frames
>>>> is always set to TRUE since the ath10k wmi-mgt-tx API is so
>>>> lame. So, mac80211 does a probe, ath10k lies and says it was
>>>> acked, and mac80211 then things all is well for another few
>>>> seconds.
>>>
>>>
>>> mac80211 shouldn't do a Probe Req to an AP on beacon loss because
>>> ath10k advertises it supports tx-status report. Hence mac80211 should
>>> use NullFunc frames which shouldn't go through wmi-mgmt-tx but htt
>>> tx-frm.
>>>
>>> But then again: NullFunc status reporting via htt tx-frm was broken on
>>> 10.1 if memory serves right. I believe it was fixed in 10.2 or 10.2.4.
>>>
>>> This problem has been effectively obscured on stock 10.1 by the
>>> offloaded beacon miss.
>>
>>
>> For what it's worth, I looked at the 4.0.4 ath10k yesterday, and it appears
>> it
>> ignores the message that the 10.1 firmware sends when beacon loss happens
>> anyway. Maybe I misread the firmware code..it's a pile of indirection.
>>
>> Do you know how the firmware is supposed to signal beacon loss to
>> the host (from the host's perspective).
>
> Normally driver would advertise IEEE80211_HW_CONNECTION_MONITOR
> to disable mac80211 from tracking connection. and driver should call
> ieee80211_beacon_loss up on receiving beacon loss event from FW
> which triggers disconnection in mac80211.
I do not see any calls to beacon_loss() in the ath10k driver,
so probably that firmware feature is not just fully wired up
to the driver. Just as well since that firmware feature is
disabled in my (-diet variant) firmware entirely.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2015-06-12 15:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 21:07 Question on beacon-miss offloading Ben Greear
2015-06-11 21:07 ` Ben Greear
2015-06-11 23:38 ` Ben Greear
2015-06-11 23:38 ` Ben Greear
2015-06-12 6:03 ` Michal Kazior
2015-06-12 6:03 ` Michal Kazior
2015-06-12 13:29 ` Ben Greear
2015-06-12 13:29 ` Ben Greear
2015-06-12 14:10 ` Krishna Chaitanya
2015-06-12 14:10 ` Krishna Chaitanya
2015-06-12 15:22 ` Ben Greear [this message]
2015-06-12 15:22 ` Ben Greear
2015-06-12 15:37 ` Ben Greear
2015-06-12 15:37 ` Ben Greear
2015-06-15 5:36 ` Michal Kazior
2015-06-15 5:36 ` Michal Kazior
2015-06-15 15:35 ` Ben Greear
2015-06-15 15:35 ` Ben Greear
2015-06-15 19:45 ` Ben Greear
2015-06-15 19:45 ` Ben Greear
2015-06-16 5:29 ` Michal Kazior
2015-06-16 5:29 ` Michal Kazior
2015-06-16 21:55 ` Ben Greear
2015-06-16 21:55 ` Ben Greear
2015-06-16 23:06 ` Ben Greear
2015-06-16 23:06 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557AF925.4000609@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.