All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Stephane Grosjean <s.grosjean@peak-system.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	tom_usenet@optusnet.com.au
Subject: Re: [BULK]Re: [PATCH] can: fix loss of frames due to wrong assumption in raw_rcv
Date: Mon, 29 Jun 2015 18:13:48 +0200	[thread overview]
Message-ID: <55916EBC.2010807@hartkopp.net> (raw)
In-Reply-To: <840510251.4781629.1435224977567.JavaMail.open-xchange@patina.store>

Hi Stephane,

On 25.06.2015 11:36, Oliver Hartkopp wrote:
>> Stephane Grosjean <s.grosjean@peak-system.com>

 >> (..)
>> tells that he's facing some loss of frames with the PEAK-System PCAN-USB
>> adapter, in case of "relatively"  high bus load... He's running two
>> Kernels (3.19 and the last 4.1 patched with this recent "fix"). At the
>> moment, he says he always notes some frame leakage, especially when he
>> (for example) "resizes windows on his desktop"...
>
> The patch
>
> http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit?id=36c01245eb8046c16eee6431e7dbfbb302635fa8
>
> especially adds
>
>     __net_timestamp(skb);
>
> after dev_alloc_skb().
>
> So you need to add this in pcan_netdev_rx() in pcan_netdev.c analogue to the
> patch above, e.g. directly after the successful dev_alloc_skb().
>
> Can you check, if this fixes the issue with the (patched) 4.1 kernel?

Any feedback?

Today I checked for frame loss with kernel 4.0.6 + all relevant patches and 
had no frame loss with a PCAN USB pro at 100% bus load.

Regards,
Oliver

  reply	other threads:[~2015-06-29 16:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-20 17:21 [PATCH] can: fix loss of frames due to wrong assumption in raw_rcv Manfred Schlaegl
2015-06-20 22:42 ` Oliver Hartkopp
2015-06-20 22:42   ` Oliver Hartkopp
2015-06-22  9:48   ` Manfred Schlaegl
2015-06-22  9:48     ` Manfred Schlaegl
2015-06-22 10:24     ` Oliver Hartkopp
2015-06-22 10:24       ` Oliver Hartkopp
     [not found]       ` <5588E6FB.5040903@optusnet.com.au>
2015-06-23  8:01         ` Oliver Hartkopp
2015-06-24  2:13           ` Tom Evans
2015-06-24 19:56             ` Oliver Hartkopp
2015-06-25  8:32               ` [BULK]Re: " Stephane Grosjean
2015-06-25  9:36                 ` Oliver Hartkopp
2015-06-29 16:13                   ` Oliver Hartkopp [this message]
2015-07-04 16:54                     ` Oliver Hartkopp
2015-07-05  1:18                       ` Tom Evans
2015-07-05 18:21                         ` Oliver Hartkopp
2015-07-06  5:44                           ` Oliver Hartkopp
2015-07-06  6:50                             ` Tom Evans
2015-07-06 17:09                               ` Oliver Hartkopp
2015-07-06  7:58                       ` [BULK]Re: " Stephane Grosjean
2015-07-06 17:14                         ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55916EBC.2010807@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=s.grosjean@peak-system.com \
    --cc=tom_usenet@optusnet.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.