From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()
Date: Tue, 7 Jul 2015 17:10:32 +0300 [thread overview]
Message-ID: <559BDDD8.1060902@cogentembedded.com> (raw)
In-Reply-To: <1436277773-14274-5-git-send-email-r.baldyga@samsung.com>
Hello.
On 7/7/2015 5:02 PM, Robert Baldyga wrote:
> Should use usb_ep_set_maxpacket_limit instead of setting
> maxpacket value manually.
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 4178d96..f50bf5d 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -3203,7 +3203,8 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc)
> ep->ep.name = gp_ep_name[i];
> ep->ep.ops = &nbu2ss_ep_ops;
>
> - ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE);
> + usb_ep_set_maxpacket_limit(&ep->ep,
> + (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE));
Inner () not needed.
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Robert Baldyga <r.baldyga@samsung.com>,
gregkh@linuxfoundation.org, balbi@ti.com
Cc: devel@driverdev.osuosl.org, hamohammed.sa@gmail.com,
chris@rorvick.com, tapaswenipathak@gmail.com,
linux-usb@vger.kernel.org, nicolas.ferre@atmel.com,
hgujulan@visteon.com, mina86@mina86.com,
linux-kernel@vger.kernel.org, vinc94@gmail.com,
roberta.dobrescu@gmail.com, andrzej.p@samsung.com,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()
Date: Tue, 7 Jul 2015 17:10:32 +0300 [thread overview]
Message-ID: <559BDDD8.1060902@cogentembedded.com> (raw)
In-Reply-To: <1436277773-14274-5-git-send-email-r.baldyga@samsung.com>
Hello.
On 7/7/2015 5:02 PM, Robert Baldyga wrote:
> Should use usb_ep_set_maxpacket_limit instead of setting
> maxpacket value manually.
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 4178d96..f50bf5d 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -3203,7 +3203,8 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc)
> ep->ep.name = gp_ep_name[i];
> ep->ep.ops = &nbu2ss_ep_ops;
>
> - ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE);
> + usb_ep_set_maxpacket_limit(&ep->ep,
> + (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE));
Inner () not needed.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-07-07 14:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 14:02 [PATCH 0/5] usb: gadget: miscellaneous fixes Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:02 ` [PATCH 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:53 ` Dan Carpenter
2015-07-07 14:53 ` Dan Carpenter
2015-07-07 16:00 ` Robert Baldyga
2015-07-07 16:00 ` Robert Baldyga
2015-07-08 7:55 ` Dan Carpenter
2015-07-08 7:55 ` Dan Carpenter
2015-07-07 14:02 ` [PATCH 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:02 ` [PATCH 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit() Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 15:01 ` Dan Carpenter
2015-07-07 15:01 ` Dan Carpenter
2015-07-07 16:24 ` Robert Baldyga
2015-07-07 16:24 ` Robert Baldyga
2015-07-07 14:02 ` [PATCH 4/5] staging: emxx_udc: " Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:10 ` Sergei Shtylyov [this message]
2015-07-07 14:10 ` Sergei Shtylyov
2015-07-07 15:03 ` Dan Carpenter
2015-07-07 15:03 ` Dan Carpenter
2015-07-07 14:02 ` [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-08 8:20 ` Nicolas Ferre
2015-07-08 8:20 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559BDDD8.1060902@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.