From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check
Date: Wed, 8 Jul 2015 10:20:26 +0200 [thread overview]
Message-ID: <559CDD4A.2000609@atmel.com> (raw)
In-Reply-To: <1436277773-14274-6-git-send-email-r.baldyga@samsung.com>
Le 07/07/2015 16:02, Robert Baldyga a ?crit :
> Add missing return value check. In case of error print debug message
> and return error code.
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Yes, it's indeed missing:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, bye.
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 4095cce0..37d414e 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
> ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc");
>
> ret = of_property_read_string(pp, "name", &name);
> + if (ret) {
> + dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
> + goto err;
> + }
> ep->ep.name = name;
>
> ep->ep_regs = udc->regs + USBA_EPT_BASE(i);
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Robert Baldyga <r.baldyga@samsung.com>,
<gregkh@linuxfoundation.org>, <balbi@ti.com>
Cc: <vinc94@gmail.com>, <hamohammed.sa@gmail.com>,
<tapaswenipathak@gmail.com>, <roberta.dobrescu@gmail.com>,
<hgujulan@visteon.com>, <chris@rorvick.com>, <mina86@mina86.com>,
<andrzej.p@samsung.com>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<m.szyprowski@samsung.com>
Subject: Re: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check
Date: Wed, 8 Jul 2015 10:20:26 +0200 [thread overview]
Message-ID: <559CDD4A.2000609@atmel.com> (raw)
In-Reply-To: <1436277773-14274-6-git-send-email-r.baldyga@samsung.com>
Le 07/07/2015 16:02, Robert Baldyga a écrit :
> Add missing return value check. In case of error print debug message
> and return error code.
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Yes, it's indeed missing:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, bye.
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 4095cce0..37d414e 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
> ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc");
>
> ret = of_property_read_string(pp, "name", &name);
> + if (ret) {
> + dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
> + goto err;
> + }
> ep->ep.name = name;
>
> ep->ep_regs = udc->regs + USBA_EPT_BASE(i);
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-07-08 8:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 14:02 [PATCH 0/5] usb: gadget: miscellaneous fixes Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:02 ` [PATCH 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:53 ` Dan Carpenter
2015-07-07 14:53 ` Dan Carpenter
2015-07-07 16:00 ` Robert Baldyga
2015-07-07 16:00 ` Robert Baldyga
2015-07-08 7:55 ` Dan Carpenter
2015-07-08 7:55 ` Dan Carpenter
2015-07-07 14:02 ` [PATCH 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:02 ` [PATCH 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit() Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 15:01 ` Dan Carpenter
2015-07-07 15:01 ` Dan Carpenter
2015-07-07 16:24 ` Robert Baldyga
2015-07-07 16:24 ` Robert Baldyga
2015-07-07 14:02 ` [PATCH 4/5] staging: emxx_udc: " Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-07 14:10 ` Sergei Shtylyov
2015-07-07 14:10 ` Sergei Shtylyov
2015-07-07 15:03 ` Dan Carpenter
2015-07-07 15:03 ` Dan Carpenter
2015-07-07 14:02 ` [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check Robert Baldyga
2015-07-07 14:02 ` Robert Baldyga
2015-07-08 8:20 ` Nicolas Ferre [this message]
2015-07-08 8:20 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559CDD4A.2000609@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.