All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] power: bq27x00_battery: Add manufacturer property
Date: Thu, 23 Jul 2015 10:55:43 -0500	[thread overview]
Message-ID: <55B10E7F.8010106@ti.com> (raw)
In-Reply-To: <1437601920-13045-2-git-send-email-afd@ti.com>

On 07/22/2015 04:51 PM, Andrew F. Davis wrote:
> Add the manufacturer property to the bq27x00 driver.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  drivers/power/bq27x00_battery.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index b6b9837..2257bd4 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -41,6 +41,8 @@
>  
>  #define DRIVER_VERSION			"1.2.0"
>  
> +#define BQ27XXX_MANUFACTURER	"Texas Instruments"
> +
>  #define BQ27x00_REG_TEMP		0x06
>  #define BQ27x00_REG_VOLT		0x08
>  #define BQ27x00_REG_AI			0x14
> @@ -142,6 +144,7 @@ static enum power_supply_property bq27x00_battery_props[] = {
>  	POWER_SUPPLY_PROP_ENERGY_NOW,
>  	POWER_SUPPLY_PROP_POWER_AVG,
>  	POWER_SUPPLY_PROP_HEALTH,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static enum power_supply_property bq27425_battery_props[] = {
> @@ -156,6 +159,7 @@ static enum power_supply_property bq27425_battery_props[] = {
>  	POWER_SUPPLY_PROP_CHARGE_FULL,
>  	POWER_SUPPLY_PROP_CHARGE_NOW,
>  	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static enum power_supply_property bq27742_battery_props[] = {
> @@ -174,6 +178,7 @@ static enum power_supply_property bq27742_battery_props[] = {
>  	POWER_SUPPLY_PROP_CYCLE_COUNT,
>  	POWER_SUPPLY_PROP_POWER_AVG,
>  	POWER_SUPPLY_PROP_HEALTH,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static enum power_supply_property bq27510_battery_props[] = {
> @@ -192,6 +197,7 @@ static enum power_supply_property bq27510_battery_props[] = {
>  	POWER_SUPPLY_PROP_CYCLE_COUNT,
>  	POWER_SUPPLY_PROP_POWER_AVG,
>  	POWER_SUPPLY_PROP_HEALTH,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static unsigned int poll_interval = 360;
> @@ -749,6 +755,9 @@ static int bq27x00_battery_get_property(struct power_supply *psy,
>  	case POWER_SUPPLY_PROP_HEALTH:
>  		ret = bq27x00_simple_value(di->cache.health, val);
>  		break;
> +	case POWER_SUPPLY_PROP_MANUFACTURER:
> +		val->strval = BQ27XXX_MANUFACTURER;
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
Acked-by: Dan Murphy <dmurphy@ti.com>

-- 
------------------
Dan Murphy


WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] power: bq27x00_battery: Add manufacturer property
Date: Thu, 23 Jul 2015 10:55:43 -0500	[thread overview]
Message-ID: <55B10E7F.8010106@ti.com> (raw)
In-Reply-To: <1437601920-13045-2-git-send-email-afd@ti.com>

On 07/22/2015 04:51 PM, Andrew F. Davis wrote:
> Add the manufacturer property to the bq27x00 driver.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  drivers/power/bq27x00_battery.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index b6b9837..2257bd4 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -41,6 +41,8 @@
>  
>  #define DRIVER_VERSION			"1.2.0"
>  
> +#define BQ27XXX_MANUFACTURER	"Texas Instruments"
> +
>  #define BQ27x00_REG_TEMP		0x06
>  #define BQ27x00_REG_VOLT		0x08
>  #define BQ27x00_REG_AI			0x14
> @@ -142,6 +144,7 @@ static enum power_supply_property bq27x00_battery_props[] = {
>  	POWER_SUPPLY_PROP_ENERGY_NOW,
>  	POWER_SUPPLY_PROP_POWER_AVG,
>  	POWER_SUPPLY_PROP_HEALTH,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static enum power_supply_property bq27425_battery_props[] = {
> @@ -156,6 +159,7 @@ static enum power_supply_property bq27425_battery_props[] = {
>  	POWER_SUPPLY_PROP_CHARGE_FULL,
>  	POWER_SUPPLY_PROP_CHARGE_NOW,
>  	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static enum power_supply_property bq27742_battery_props[] = {
> @@ -174,6 +178,7 @@ static enum power_supply_property bq27742_battery_props[] = {
>  	POWER_SUPPLY_PROP_CYCLE_COUNT,
>  	POWER_SUPPLY_PROP_POWER_AVG,
>  	POWER_SUPPLY_PROP_HEALTH,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static enum power_supply_property bq27510_battery_props[] = {
> @@ -192,6 +197,7 @@ static enum power_supply_property bq27510_battery_props[] = {
>  	POWER_SUPPLY_PROP_CYCLE_COUNT,
>  	POWER_SUPPLY_PROP_POWER_AVG,
>  	POWER_SUPPLY_PROP_HEALTH,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
>  static unsigned int poll_interval = 360;
> @@ -749,6 +755,9 @@ static int bq27x00_battery_get_property(struct power_supply *psy,
>  	case POWER_SUPPLY_PROP_HEALTH:
>  		ret = bq27x00_simple_value(di->cache.health, val);
>  		break;
> +	case POWER_SUPPLY_PROP_MANUFACTURER:
> +		val->strval = BQ27XXX_MANUFACTURER;
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
Acked-by: Dan Murphy <dmurphy@ti.com>

-- 
------------------
Dan Murphy


  reply	other threads:[~2015-07-23 15:56 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 21:51 [PATCH 0/8] Add support for additional bq27xxx devices Andrew F. Davis
2015-07-22 21:51 ` Andrew F. Davis
2015-07-22 21:51 ` [PATCH 1/8] power: bq27x00_battery: Add manufacturer property Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 15:55   ` Dan Murphy [this message]
2015-07-23 15:55     ` Dan Murphy
2015-07-23 15:59   ` Pali Rohár
2015-07-24 15:36   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 2/8] power: bq27x00_battery: Fix lines over 80 characters long Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:00   ` Pali Rohár
2015-07-23 16:02   ` Dan Murphy
2015-07-23 16:02     ` Dan Murphy
2015-07-24 15:36   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 3/8] power: bq27x00_battery: Fix function parameter alignment Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:00   ` Pali Rohár
2015-07-23 16:02   ` Dan Murphy
2015-07-23 16:02     ` Dan Murphy
2015-07-24 15:37   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 4/8] power: bq27x00_battery: Checkpatch fixes Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:01   ` Pali Rohár
2015-07-23 16:04   ` Dan Murphy
2015-07-23 16:04     ` Dan Murphy
2015-07-24 15:37   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 5/8] power: bq27x00_battery: Renaming for consistency Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:12   ` Pali Rohár
     [not found]     ` <55B11E4C.6000006@ti.com>
2015-07-23 20:15       ` Pali Rohár
2015-07-23 20:56         ` Belisko Marek
2015-07-23 21:15           ` Pali Rohár
2015-07-23 21:36             ` Belisko Marek
2015-07-24  7:44               ` Pali Rohár
2015-07-22 21:51 ` [PATCH 6/8] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:15   ` Pali Rohár
2015-07-23 17:19     ` Andrew F. Davis
2015-07-23 17:19       ` Andrew F. Davis
2015-07-28  8:41       ` Pali Rohár
2015-07-22 21:51 ` [PATCH 7/8] power: bq27xxx_battery: Add support for additional bq27xxx family devices Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:20   ` Pali Rohár
2015-07-23 17:42     ` Andrew F. Davis
2015-07-23 17:42       ` Andrew F. Davis
2015-07-28  8:43       ` Pali Rohár
2015-07-22 21:52 ` [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking Andrew F. Davis
2015-07-22 21:52   ` Andrew F. Davis
2015-07-23 16:22   ` Pali Rohár
2015-07-23 17:06     ` Joe Perches
2015-07-24 20:32       ` Andrew F. Davis
2015-07-24 20:32         ` Andrew F. Davis
2015-07-24 20:27     ` Andrew F. Davis
2015-07-24 20:27       ` Andrew F. Davis
2015-07-24 20:53       ` Pali Rohár
2015-07-23 16:27 ` [PATCH 0/8] Add support for additional bq27xxx devices Pali Rohár
2015-07-23 17:01   ` Andreas Dannenberg
2015-07-23 17:01     ` Andreas Dannenberg
2015-07-24 15:57   ` Andrew F. Davis
2015-07-24 15:57     ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B10E7F.8010106@ti.com \
    --to=dmurphy@ti.com \
    --cc=afd@ti.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.