All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] power: bq27x00_battery: Fix lines over 80 characters long
Date: Thu, 23 Jul 2015 11:02:15 -0500	[thread overview]
Message-ID: <55B11007.10504@ti.com> (raw)
In-Reply-To: <1437601920-13045-3-git-send-email-afd@ti.com>

On 07/22/2015 04:51 PM, Andrew F. Davis wrote:
> Shorted lines over 80 characters long by reducing tab count.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  drivers/power/bq27x00_battery.c | 74 ++++++++++++++++++++---------------------
>  1 file changed, 37 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 2257bd4..203cf61 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -39,49 +39,49 @@
>  
>  #include <linux/power/bq27x00_battery.h>
>  
> -#define DRIVER_VERSION			"1.2.0"
> +#define DRIVER_VERSION		"1.2.0"
>  
>  #define BQ27XXX_MANUFACTURER	"Texas Instruments"
>  
> -#define BQ27x00_REG_TEMP		0x06
> -#define BQ27x00_REG_VOLT		0x08
> -#define BQ27x00_REG_AI			0x14
> -#define BQ27x00_REG_FLAGS		0x0A
> -#define BQ27x00_REG_TTE			0x16
> -#define BQ27x00_REG_TTF			0x18
> -#define BQ27x00_REG_TTECP		0x26
> -#define BQ27x00_REG_NAC			0x0C /* Nominal available capacity */
> -#define BQ27x00_REG_LMD			0x12 /* Last measured discharge */
> -#define BQ27x00_REG_CYCT		0x2A /* Cycle count total */
> -#define BQ27x00_REG_AE			0x22 /* Available energy */
> -#define BQ27x00_POWER_AVG		0x24
> -
> -#define BQ27000_REG_RSOC		0x0B /* Relative State-of-Charge */
> -#define BQ27000_REG_ILMD		0x76 /* Initial last measured discharge */
> -#define BQ27000_FLAG_EDVF		BIT(0) /* Final End-of-Discharge-Voltage flag */
> -#define BQ27000_FLAG_EDV1		BIT(1) /* First End-of-Discharge-Voltage flag */
> -#define BQ27000_FLAG_CI			BIT(4) /* Capacity Inaccurate flag */
> -#define BQ27000_FLAG_FC			BIT(5)
> -#define BQ27000_FLAG_CHGS		BIT(7) /* Charge state flag */
> -
> -#define BQ27500_REG_SOC			0x2C
> -#define BQ27500_REG_DCAP		0x3C /* Design capacity */
> -#define BQ27500_FLAG_DSC		BIT(0)
> -#define BQ27500_FLAG_SOCF		BIT(1) /* State-of-Charge threshold final */
> -#define BQ27500_FLAG_SOC1		BIT(2) /* State-of-Charge threshold 1 */
> -#define BQ27500_FLAG_FC			BIT(9)
> -#define BQ27500_FLAG_OTC		BIT(15)
> -
> -#define BQ27742_POWER_AVG		0x76
> -
> -#define BQ27510_REG_SOC			0x20
> -#define BQ27510_REG_DCAP		0x2E /* Design capacity */
> -#define BQ27510_REG_CYCT		0x1E /* Cycle count total */
> +#define BQ27x00_REG_TEMP	0x06
> +#define BQ27x00_REG_VOLT	0x08
> +#define BQ27x00_REG_AI		0x14
> +#define BQ27x00_REG_FLAGS	0x0A
> +#define BQ27x00_REG_TTE		0x16
> +#define BQ27x00_REG_TTF		0x18
> +#define BQ27x00_REG_TTECP	0x26
> +#define BQ27x00_REG_NAC		0x0C /* Nominal available capacity */
> +#define BQ27x00_REG_LMD		0x12 /* Last measured discharge */
> +#define BQ27x00_REG_CYCT	0x2A /* Cycle count total */
> +#define BQ27x00_REG_AE		0x22 /* Available energy */
> +#define BQ27x00_POWER_AVG	0x24
> +
> +#define BQ27000_REG_RSOC	0x0B /* Relative State-of-Charge */
> +#define BQ27000_REG_ILMD	0x76 /* Initial last measured discharge */
> +#define BQ27000_FLAG_EDVF	BIT(0) /* Final End-of-Discharge-Voltage flag */
> +#define BQ27000_FLAG_EDV1	BIT(1) /* First End-of-Discharge-Voltage flag */
> +#define BQ27000_FLAG_CI		BIT(4) /* Capacity Inaccurate flag */
> +#define BQ27000_FLAG_FC		BIT(5)
> +#define BQ27000_FLAG_CHGS	BIT(7) /* Charge state flag */
> +
> +#define BQ27500_REG_SOC		0x2C
> +#define BQ27500_REG_DCAP	0x3C /* Design capacity */
> +#define BQ27500_FLAG_DSC	BIT(0)
> +#define BQ27500_FLAG_SOCF	BIT(1) /* State-of-Charge threshold final */
> +#define BQ27500_FLAG_SOC1	BIT(2) /* State-of-Charge threshold 1 */
> +#define BQ27500_FLAG_FC		BIT(9)
> +#define BQ27500_FLAG_OTC	BIT(15)
> +
> +#define BQ27742_POWER_AVG	0x76
> +
> +#define BQ27510_REG_SOC		0x20
> +#define BQ27510_REG_DCAP	0x2E /* Design capacity */
> +#define BQ27510_REG_CYCT	0x1E /* Cycle count total */
>  
>  /* bq27425 register addresses are same as bq27x00 addresses minus 4 */
> -#define BQ27425_REG_OFFSET		0x04
> +#define BQ27425_REG_OFFSET	0x04
>  #define BQ27425_REG_SOC		(0x1C + BQ27425_REG_OFFSET)
> -#define BQ27425_REG_DCAP		(0x3C + BQ27425_REG_OFFSET)
> +#define BQ27425_REG_DCAP	(0x3C + BQ27425_REG_OFFSET)
>  
>  #define BQ27000_RS			20 /* Resistor sense */
>  #define BQ27x00_POWER_CONSTANT		(256 * 29200 / 1000)

Acked-by: Dan Murphy <dmurphy@ti.com>


-- 
------------------
Dan Murphy

WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/8] power: bq27x00_battery: Fix lines over 80 characters long
Date: Thu, 23 Jul 2015 11:02:15 -0500	[thread overview]
Message-ID: <55B11007.10504@ti.com> (raw)
In-Reply-To: <1437601920-13045-3-git-send-email-afd@ti.com>

On 07/22/2015 04:51 PM, Andrew F. Davis wrote:
> Shorted lines over 80 characters long by reducing tab count.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  drivers/power/bq27x00_battery.c | 74 ++++++++++++++++++++---------------------
>  1 file changed, 37 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 2257bd4..203cf61 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -39,49 +39,49 @@
>  
>  #include <linux/power/bq27x00_battery.h>
>  
> -#define DRIVER_VERSION			"1.2.0"
> +#define DRIVER_VERSION		"1.2.0"
>  
>  #define BQ27XXX_MANUFACTURER	"Texas Instruments"
>  
> -#define BQ27x00_REG_TEMP		0x06
> -#define BQ27x00_REG_VOLT		0x08
> -#define BQ27x00_REG_AI			0x14
> -#define BQ27x00_REG_FLAGS		0x0A
> -#define BQ27x00_REG_TTE			0x16
> -#define BQ27x00_REG_TTF			0x18
> -#define BQ27x00_REG_TTECP		0x26
> -#define BQ27x00_REG_NAC			0x0C /* Nominal available capacity */
> -#define BQ27x00_REG_LMD			0x12 /* Last measured discharge */
> -#define BQ27x00_REG_CYCT		0x2A /* Cycle count total */
> -#define BQ27x00_REG_AE			0x22 /* Available energy */
> -#define BQ27x00_POWER_AVG		0x24
> -
> -#define BQ27000_REG_RSOC		0x0B /* Relative State-of-Charge */
> -#define BQ27000_REG_ILMD		0x76 /* Initial last measured discharge */
> -#define BQ27000_FLAG_EDVF		BIT(0) /* Final End-of-Discharge-Voltage flag */
> -#define BQ27000_FLAG_EDV1		BIT(1) /* First End-of-Discharge-Voltage flag */
> -#define BQ27000_FLAG_CI			BIT(4) /* Capacity Inaccurate flag */
> -#define BQ27000_FLAG_FC			BIT(5)
> -#define BQ27000_FLAG_CHGS		BIT(7) /* Charge state flag */
> -
> -#define BQ27500_REG_SOC			0x2C
> -#define BQ27500_REG_DCAP		0x3C /* Design capacity */
> -#define BQ27500_FLAG_DSC		BIT(0)
> -#define BQ27500_FLAG_SOCF		BIT(1) /* State-of-Charge threshold final */
> -#define BQ27500_FLAG_SOC1		BIT(2) /* State-of-Charge threshold 1 */
> -#define BQ27500_FLAG_FC			BIT(9)
> -#define BQ27500_FLAG_OTC		BIT(15)
> -
> -#define BQ27742_POWER_AVG		0x76
> -
> -#define BQ27510_REG_SOC			0x20
> -#define BQ27510_REG_DCAP		0x2E /* Design capacity */
> -#define BQ27510_REG_CYCT		0x1E /* Cycle count total */
> +#define BQ27x00_REG_TEMP	0x06
> +#define BQ27x00_REG_VOLT	0x08
> +#define BQ27x00_REG_AI		0x14
> +#define BQ27x00_REG_FLAGS	0x0A
> +#define BQ27x00_REG_TTE		0x16
> +#define BQ27x00_REG_TTF		0x18
> +#define BQ27x00_REG_TTECP	0x26
> +#define BQ27x00_REG_NAC		0x0C /* Nominal available capacity */
> +#define BQ27x00_REG_LMD		0x12 /* Last measured discharge */
> +#define BQ27x00_REG_CYCT	0x2A /* Cycle count total */
> +#define BQ27x00_REG_AE		0x22 /* Available energy */
> +#define BQ27x00_POWER_AVG	0x24
> +
> +#define BQ27000_REG_RSOC	0x0B /* Relative State-of-Charge */
> +#define BQ27000_REG_ILMD	0x76 /* Initial last measured discharge */
> +#define BQ27000_FLAG_EDVF	BIT(0) /* Final End-of-Discharge-Voltage flag */
> +#define BQ27000_FLAG_EDV1	BIT(1) /* First End-of-Discharge-Voltage flag */
> +#define BQ27000_FLAG_CI		BIT(4) /* Capacity Inaccurate flag */
> +#define BQ27000_FLAG_FC		BIT(5)
> +#define BQ27000_FLAG_CHGS	BIT(7) /* Charge state flag */
> +
> +#define BQ27500_REG_SOC		0x2C
> +#define BQ27500_REG_DCAP	0x3C /* Design capacity */
> +#define BQ27500_FLAG_DSC	BIT(0)
> +#define BQ27500_FLAG_SOCF	BIT(1) /* State-of-Charge threshold final */
> +#define BQ27500_FLAG_SOC1	BIT(2) /* State-of-Charge threshold 1 */
> +#define BQ27500_FLAG_FC		BIT(9)
> +#define BQ27500_FLAG_OTC	BIT(15)
> +
> +#define BQ27742_POWER_AVG	0x76
> +
> +#define BQ27510_REG_SOC		0x20
> +#define BQ27510_REG_DCAP	0x2E /* Design capacity */
> +#define BQ27510_REG_CYCT	0x1E /* Cycle count total */
>  
>  /* bq27425 register addresses are same as bq27x00 addresses minus 4 */
> -#define BQ27425_REG_OFFSET		0x04
> +#define BQ27425_REG_OFFSET	0x04
>  #define BQ27425_REG_SOC		(0x1C + BQ27425_REG_OFFSET)
> -#define BQ27425_REG_DCAP		(0x3C + BQ27425_REG_OFFSET)
> +#define BQ27425_REG_DCAP	(0x3C + BQ27425_REG_OFFSET)
>  
>  #define BQ27000_RS			20 /* Resistor sense */
>  #define BQ27x00_POWER_CONSTANT		(256 * 29200 / 1000)

Acked-by: Dan Murphy <dmurphy@ti.com>


-- 
------------------
Dan Murphy


  parent reply	other threads:[~2015-07-23 16:02 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 21:51 [PATCH 0/8] Add support for additional bq27xxx devices Andrew F. Davis
2015-07-22 21:51 ` Andrew F. Davis
2015-07-22 21:51 ` [PATCH 1/8] power: bq27x00_battery: Add manufacturer property Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 15:55   ` Dan Murphy
2015-07-23 15:55     ` Dan Murphy
2015-07-23 15:59   ` Pali Rohár
2015-07-24 15:36   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 2/8] power: bq27x00_battery: Fix lines over 80 characters long Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:00   ` Pali Rohár
2015-07-23 16:02   ` Dan Murphy [this message]
2015-07-23 16:02     ` Dan Murphy
2015-07-24 15:36   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 3/8] power: bq27x00_battery: Fix function parameter alignment Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:00   ` Pali Rohár
2015-07-23 16:02   ` Dan Murphy
2015-07-23 16:02     ` Dan Murphy
2015-07-24 15:37   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 4/8] power: bq27x00_battery: Checkpatch fixes Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:01   ` Pali Rohár
2015-07-23 16:04   ` Dan Murphy
2015-07-23 16:04     ` Dan Murphy
2015-07-24 15:37   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 5/8] power: bq27x00_battery: Renaming for consistency Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:12   ` Pali Rohár
     [not found]     ` <55B11E4C.6000006@ti.com>
2015-07-23 20:15       ` Pali Rohár
2015-07-23 20:56         ` Belisko Marek
2015-07-23 21:15           ` Pali Rohár
2015-07-23 21:36             ` Belisko Marek
2015-07-24  7:44               ` Pali Rohár
2015-07-22 21:51 ` [PATCH 6/8] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:15   ` Pali Rohár
2015-07-23 17:19     ` Andrew F. Davis
2015-07-23 17:19       ` Andrew F. Davis
2015-07-28  8:41       ` Pali Rohár
2015-07-22 21:51 ` [PATCH 7/8] power: bq27xxx_battery: Add support for additional bq27xxx family devices Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:20   ` Pali Rohár
2015-07-23 17:42     ` Andrew F. Davis
2015-07-23 17:42       ` Andrew F. Davis
2015-07-28  8:43       ` Pali Rohár
2015-07-22 21:52 ` [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking Andrew F. Davis
2015-07-22 21:52   ` Andrew F. Davis
2015-07-23 16:22   ` Pali Rohár
2015-07-23 17:06     ` Joe Perches
2015-07-24 20:32       ` Andrew F. Davis
2015-07-24 20:32         ` Andrew F. Davis
2015-07-24 20:27     ` Andrew F. Davis
2015-07-24 20:27       ` Andrew F. Davis
2015-07-24 20:53       ` Pali Rohár
2015-07-23 16:27 ` [PATCH 0/8] Add support for additional bq27xxx devices Pali Rohár
2015-07-23 17:01   ` Andreas Dannenberg
2015-07-23 17:01     ` Andreas Dannenberg
2015-07-24 15:57   ` Andrew F. Davis
2015-07-24 15:57     ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B11007.10504@ti.com \
    --to=dmurphy@ti.com \
    --cc=afd@ti.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.