All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] power: bq27x00_battery: Fix function parameter alignment
Date: Thu, 23 Jul 2015 11:02:21 -0500	[thread overview]
Message-ID: <55B1100D.7080306@ti.com> (raw)
In-Reply-To: <1437601920-13045-4-git-send-email-afd@ti.com>

On 07/22/2015 04:51 PM, Andrew F. Davis wrote:
> Fix the alignment of function parameters on new lines.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  drivers/power/bq27x00_battery.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 203cf61..9cdad19 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -210,7 +210,7 @@ MODULE_PARM_DESC(poll_interval, "battery poll interval in seconds - " \
>   */
>  
>  static inline int bq27x00_read(struct bq27x00_device_info *di, u8 reg,
> -		bool single)
> +			       bool single)
>  {
>  	if (di->chip == BQ27425)
>  		return di->bus.read(di, reg - BQ27425_REG_OFFSET, single);
> @@ -565,7 +565,7 @@ static void bq27x00_battery_poll(struct work_struct *work)
>   * Or 0 if something fails.
>   */
>  static int bq27x00_battery_current(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +				   union power_supply_propval *val)
>  {
>  	int curr;
>  	int flags;
> @@ -593,7 +593,7 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di,
>  }
>  
>  static int bq27x00_battery_status(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +				  union power_supply_propval *val)
>  {
>  	int status;
>  
> @@ -621,7 +621,7 @@ static int bq27x00_battery_status(struct bq27x00_device_info *di,
>  }
>  
>  static int bq27x00_battery_capacity_level(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +					  union power_supply_propval *val)
>  {
>  	int level;
>  
> @@ -655,7 +655,7 @@ static int bq27x00_battery_capacity_level(struct bq27x00_device_info *di,
>   * Or < 0 if something fails.
>   */
>  static int bq27x00_battery_voltage(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +				   union power_supply_propval *val)
>  {
>  	int volt;
>  
> @@ -671,7 +671,7 @@ static int bq27x00_battery_voltage(struct bq27x00_device_info *di,
>  }
>  
>  static int bq27x00_simple_value(int value,
> -	union power_supply_propval *val)
> +				union power_supply_propval *val)
>  {
>  	if (value < 0)
>  		return value;
> @@ -987,7 +987,7 @@ static inline void bq27x00_battery_i2c_exit(void) {};
>  #ifdef CONFIG_BATTERY_BQ27X00_PLATFORM
>  
>  static int bq27000_read_platform(struct bq27x00_device_info *di, u8 reg,
> -			bool single)
> +				 bool single)
>  {
>  	struct device *dev = di->dev;
>  	struct bq27000_platform_data *pdata = dev->platform_data;

Acked-by: Dan Murphy <dmurphy@ti.com>


-- 
------------------
Dan Murphy


WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/8] power: bq27x00_battery: Fix function parameter alignment
Date: Thu, 23 Jul 2015 11:02:21 -0500	[thread overview]
Message-ID: <55B1100D.7080306@ti.com> (raw)
In-Reply-To: <1437601920-13045-4-git-send-email-afd@ti.com>

On 07/22/2015 04:51 PM, Andrew F. Davis wrote:
> Fix the alignment of function parameters on new lines.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  drivers/power/bq27x00_battery.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 203cf61..9cdad19 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -210,7 +210,7 @@ MODULE_PARM_DESC(poll_interval, "battery poll interval in seconds - " \
>   */
>  
>  static inline int bq27x00_read(struct bq27x00_device_info *di, u8 reg,
> -		bool single)
> +			       bool single)
>  {
>  	if (di->chip == BQ27425)
>  		return di->bus.read(di, reg - BQ27425_REG_OFFSET, single);
> @@ -565,7 +565,7 @@ static void bq27x00_battery_poll(struct work_struct *work)
>   * Or 0 if something fails.
>   */
>  static int bq27x00_battery_current(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +				   union power_supply_propval *val)
>  {
>  	int curr;
>  	int flags;
> @@ -593,7 +593,7 @@ static int bq27x00_battery_current(struct bq27x00_device_info *di,
>  }
>  
>  static int bq27x00_battery_status(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +				  union power_supply_propval *val)
>  {
>  	int status;
>  
> @@ -621,7 +621,7 @@ static int bq27x00_battery_status(struct bq27x00_device_info *di,
>  }
>  
>  static int bq27x00_battery_capacity_level(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +					  union power_supply_propval *val)
>  {
>  	int level;
>  
> @@ -655,7 +655,7 @@ static int bq27x00_battery_capacity_level(struct bq27x00_device_info *di,
>   * Or < 0 if something fails.
>   */
>  static int bq27x00_battery_voltage(struct bq27x00_device_info *di,
> -	union power_supply_propval *val)
> +				   union power_supply_propval *val)
>  {
>  	int volt;
>  
> @@ -671,7 +671,7 @@ static int bq27x00_battery_voltage(struct bq27x00_device_info *di,
>  }
>  
>  static int bq27x00_simple_value(int value,
> -	union power_supply_propval *val)
> +				union power_supply_propval *val)
>  {
>  	if (value < 0)
>  		return value;
> @@ -987,7 +987,7 @@ static inline void bq27x00_battery_i2c_exit(void) {};
>  #ifdef CONFIG_BATTERY_BQ27X00_PLATFORM
>  
>  static int bq27000_read_platform(struct bq27x00_device_info *di, u8 reg,
> -			bool single)
> +				 bool single)
>  {
>  	struct device *dev = di->dev;
>  	struct bq27000_platform_data *pdata = dev->platform_data;

Acked-by: Dan Murphy <dmurphy@ti.com>


-- 
------------------
Dan Murphy


  parent reply	other threads:[~2015-07-23 16:02 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 21:51 [PATCH 0/8] Add support for additional bq27xxx devices Andrew F. Davis
2015-07-22 21:51 ` Andrew F. Davis
2015-07-22 21:51 ` [PATCH 1/8] power: bq27x00_battery: Add manufacturer property Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 15:55   ` Dan Murphy
2015-07-23 15:55     ` Dan Murphy
2015-07-23 15:59   ` Pali Rohár
2015-07-24 15:36   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 2/8] power: bq27x00_battery: Fix lines over 80 characters long Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:00   ` Pali Rohár
2015-07-23 16:02   ` Dan Murphy
2015-07-23 16:02     ` Dan Murphy
2015-07-24 15:36   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 3/8] power: bq27x00_battery: Fix function parameter alignment Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:00   ` Pali Rohár
2015-07-23 16:02   ` Dan Murphy [this message]
2015-07-23 16:02     ` Dan Murphy
2015-07-24 15:37   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 4/8] power: bq27x00_battery: Checkpatch fixes Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:01   ` Pali Rohár
2015-07-23 16:04   ` Dan Murphy
2015-07-23 16:04     ` Dan Murphy
2015-07-24 15:37   ` Sebastian Reichel
2015-07-22 21:51 ` [PATCH 5/8] power: bq27x00_battery: Renaming for consistency Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:12   ` Pali Rohár
     [not found]     ` <55B11E4C.6000006@ti.com>
2015-07-23 20:15       ` Pali Rohár
2015-07-23 20:56         ` Belisko Marek
2015-07-23 21:15           ` Pali Rohár
2015-07-23 21:36             ` Belisko Marek
2015-07-24  7:44               ` Pali Rohár
2015-07-22 21:51 ` [PATCH 6/8] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:15   ` Pali Rohár
2015-07-23 17:19     ` Andrew F. Davis
2015-07-23 17:19       ` Andrew F. Davis
2015-07-28  8:41       ` Pali Rohár
2015-07-22 21:51 ` [PATCH 7/8] power: bq27xxx_battery: Add support for additional bq27xxx family devices Andrew F. Davis
2015-07-22 21:51   ` Andrew F. Davis
2015-07-23 16:20   ` Pali Rohár
2015-07-23 17:42     ` Andrew F. Davis
2015-07-23 17:42       ` Andrew F. Davis
2015-07-28  8:43       ` Pali Rohár
2015-07-22 21:52 ` [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking Andrew F. Davis
2015-07-22 21:52   ` Andrew F. Davis
2015-07-23 16:22   ` Pali Rohár
2015-07-23 17:06     ` Joe Perches
2015-07-24 20:32       ` Andrew F. Davis
2015-07-24 20:32         ` Andrew F. Davis
2015-07-24 20:27     ` Andrew F. Davis
2015-07-24 20:27       ` Andrew F. Davis
2015-07-24 20:53       ` Pali Rohár
2015-07-23 16:27 ` [PATCH 0/8] Add support for additional bq27xxx devices Pali Rohár
2015-07-23 17:01   ` Andreas Dannenberg
2015-07-23 17:01     ` Andreas Dannenberg
2015-07-24 15:57   ` Andrew F. Davis
2015-07-24 15:57     ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B1100D.7080306@ti.com \
    --to=dmurphy@ti.com \
    --cc=afd@ti.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.