* [PATCH for-4.6] xl/libxl: disable PV vNUMA
@ 2015-07-30 15:12 Wei Liu
2015-07-30 15:30 ` Roger Pau Monné
0 siblings, 1 reply; 4+ messages in thread
From: Wei Liu @ 2015-07-30 15:12 UTC (permalink / raw)
To: Xen-devel; +Cc: Ian Jackson, Dario Faggioli, Wei Liu, Ian Campbell
Update xl manual and disable PV vNUMA in libxl.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>
---
docs/man/xl.cfg.pod.5 | 4 ++++
tools/libxl/libxl_create.c | 9 +++++++++
2 files changed, 13 insertions(+)
diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
index c78c3ba..782106c 100644
--- a/docs/man/xl.cfg.pod.5
+++ b/docs/man/xl.cfg.pod.5
@@ -261,6 +261,10 @@ Specify virtual NUMA configuration with positional arguments. The
nth B<VNODE_SPEC> in the list specifies the configuration of nth
virtual node.
+Note that virtual NUMA for PV guest is not yet supported, because
+there is issue with regard to cpuid handling that affects PV virtual
+NUMA.
+
Each B<VNODE_SPEC> is a list, which has a form of
"[VNODE_CONFIG_OPTION,VNODE_CONFIG_OPTION, ... ]" (without quotes).
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 4f2f50b..4f4273d 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -860,6 +860,15 @@ static void initiate_domain_create(libxl__egc *egc,
goto error_out;
}
+ /* PV vNUMA is not yet supported because there is issue with
+ * regard to cpuid handling.
+ */
+ if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
+ d_config->b_info.num_vnuma_nodes) {
+ LOG(ERROR, "PV vNUMA not yet supported");
+ goto error_out;
+ }
+
ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info);
if (ret) {
LOG(ERROR, "Unable to set domain create info defaults");
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH for-4.6] xl/libxl: disable PV vNUMA
2015-07-30 15:12 [PATCH for-4.6] xl/libxl: disable PV vNUMA Wei Liu
@ 2015-07-30 15:30 ` Roger Pau Monné
2015-07-30 15:45 ` Wei Liu
0 siblings, 1 reply; 4+ messages in thread
From: Roger Pau Monné @ 2015-07-30 15:30 UTC (permalink / raw)
To: Wei Liu, Xen-devel; +Cc: Dario Faggioli, Ian Jackson, Ian Campbell
El 30/07/15 a les 17.12, Wei Liu ha escrit:
> Update xl manual and disable PV vNUMA in libxl.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Dario Faggioli <dario.faggioli@citrix.com>
> ---
> docs/man/xl.cfg.pod.5 | 4 ++++
> tools/libxl/libxl_create.c | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> index c78c3ba..782106c 100644
> --- a/docs/man/xl.cfg.pod.5
> +++ b/docs/man/xl.cfg.pod.5
> @@ -261,6 +261,10 @@ Specify virtual NUMA configuration with positional arguments. The
> nth B<VNODE_SPEC> in the list specifies the configuration of nth
> virtual node.
>
> +Note that virtual NUMA for PV guest is not yet supported, because
> +there is issue with regard to cpuid handling that affects PV virtual
^ an ^regarding
> +NUMA.
> +
> Each B<VNODE_SPEC> is a list, which has a form of
> "[VNODE_CONFIG_OPTION,VNODE_CONFIG_OPTION, ... ]" (without quotes).
>
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 4f2f50b..4f4273d 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -860,6 +860,15 @@ static void initiate_domain_create(libxl__egc *egc,
> goto error_out;
> }
>
> + /* PV vNUMA is not yet supported because there is issue with
> + * regard to cpuid handling.
Same.
> + */
> + if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
> + d_config->b_info.num_vnuma_nodes) {
> + LOG(ERROR, "PV vNUMA not yet supported");
> + goto error_out;
> + }
> +
> ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info);
> if (ret) {
> LOG(ERROR, "Unable to set domain create info defaults");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-4.6] xl/libxl: disable PV vNUMA
2015-07-30 15:30 ` Roger Pau Monné
@ 2015-07-30 15:45 ` Wei Liu
2015-07-30 15:55 ` Andrew Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Wei Liu @ 2015-07-30 15:45 UTC (permalink / raw)
To: Roger Pau Monné
Cc: Xen-devel, Dario Faggioli, Wei Liu, Ian Jackson, Ian Campbell
On Thu, Jul 30, 2015 at 05:30:58PM +0200, Roger Pau Monné wrote:
> El 30/07/15 a les 17.12, Wei Liu ha escrit:
> > Update xl manual and disable PV vNUMA in libxl.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Dario Faggioli <dario.faggioli@citrix.com>
> > ---
> > docs/man/xl.cfg.pod.5 | 4 ++++
> > tools/libxl/libxl_create.c | 9 +++++++++
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> > index c78c3ba..782106c 100644
> > --- a/docs/man/xl.cfg.pod.5
> > +++ b/docs/man/xl.cfg.pod.5
> > @@ -261,6 +261,10 @@ Specify virtual NUMA configuration with positional arguments. The
> > nth B<VNODE_SPEC> in the list specifies the configuration of nth
> > virtual node.
> >
> > +Note that virtual NUMA for PV guest is not yet supported, because
> > +there is issue with regard to cpuid handling that affects PV virtual
> ^ an ^regarding
Added "an", but "with regard to" is a commonly used phrase.
Did I miss anything?
Wei.
> > +NUMA.
> > +
> > Each B<VNODE_SPEC> is a list, which has a form of
> > "[VNODE_CONFIG_OPTION,VNODE_CONFIG_OPTION, ... ]" (without quotes).
> >
> > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> > index 4f2f50b..4f4273d 100644
> > --- a/tools/libxl/libxl_create.c
> > +++ b/tools/libxl/libxl_create.c
> > @@ -860,6 +860,15 @@ static void initiate_domain_create(libxl__egc *egc,
> > goto error_out;
> > }
> >
> > + /* PV vNUMA is not yet supported because there is issue with
> > + * regard to cpuid handling.
>
> Same.
>
> > + */
> > + if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
> > + d_config->b_info.num_vnuma_nodes) {
> > + LOG(ERROR, "PV vNUMA not yet supported");
> > + goto error_out;
> > + }
> > +
> > ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info);
> > if (ret) {
> > LOG(ERROR, "Unable to set domain create info defaults");
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-4.6] xl/libxl: disable PV vNUMA
2015-07-30 15:45 ` Wei Liu
@ 2015-07-30 15:55 ` Andrew Cooper
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2015-07-30 15:55 UTC (permalink / raw)
To: Wei Liu, Roger Pau Monné
Cc: Xen-devel, Dario Faggioli, Ian Jackson, Ian Campbell
On 30/07/15 16:45, Wei Liu wrote:
> On Thu, Jul 30, 2015 at 05:30:58PM +0200, Roger Pau Monné wrote:
>> El 30/07/15 a les 17.12, Wei Liu ha escrit:
>>> Update xl manual and disable PV vNUMA in libxl.
>>>
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>>> ---
>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>> Cc: Dario Faggioli <dario.faggioli@citrix.com>
>>> ---
>>> docs/man/xl.cfg.pod.5 | 4 ++++
>>> tools/libxl/libxl_create.c | 9 +++++++++
>>> 2 files changed, 13 insertions(+)
>>>
>>> diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
>>> index c78c3ba..782106c 100644
>>> --- a/docs/man/xl.cfg.pod.5
>>> +++ b/docs/man/xl.cfg.pod.5
>>> @@ -261,6 +261,10 @@ Specify virtual NUMA configuration with positional arguments. The
>>> nth B<VNODE_SPEC> in the list specifies the configuration of nth
>>> virtual node.
>>>
>>> +Note that virtual NUMA for PV guest is not yet supported, because
>>> +there is issue with regard to cpuid handling that affects PV virtual
>> ^ an ^regarding
> Added "an", but "with regard to" is a commonly used phrase.
"with regards to" or "regarding" are both fine here, but the singular of
"regard" is not.
~Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-30 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-30 15:12 [PATCH for-4.6] xl/libxl: disable PV vNUMA Wei Liu
2015-07-30 15:30 ` Roger Pau Monné
2015-07-30 15:45 ` Wei Liu
2015-07-30 15:55 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.