Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Joseph Myers]

On Wed, 26 Aug 2015, Mike Frysinger wrote:

> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
> keep in sync with it.
> 
> 2015-08-25  Mike Frysinger  <vapier@gentoo.org>
> 
> 	[BZ #18863]
> 	* sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
> 	(si_call_addr): Define.
> 	(si_syscall): Define.
> 	(si_arch): Define.

OK.  CC to linux-mips because I see that the MIPS implementation of 
copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Joseph Myers]

On Wed, 26 Aug 2015, Mike Frysinger wrote:

> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
> keep in sync with it.
> 
> 2015-08-25  Mike Frysinger  <vapier@gentoo.org>
> 
> 	[BZ #18863]
> 	* sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
> 	(si_call_addr): Define.
> 	(si_syscall): Define.
> 	(si_arch): Define.

OK.  CC to linux-mips because I see that the MIPS implementation of 
copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

On 26 Aug 2015 09:30, Joseph Myers wrote:
> On Wed, 26 Aug 2015, Mike Frysinger wrote:
> > Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
> > keep in sync with it.
> > 
> > 2015-08-25  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	[BZ #18863]
> > 	* sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
> > 	(si_call_addr): Define.
> > 	(si_syscall): Define.
> > 	(si_arch): Define.
> 
> OK.  CC to linux-mips because I see that the MIPS implementation of 
> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.

i'm getting reports of seccomp misbehavior on mips already which is what
started me down this glibc path.  i suspect the original port was tested
against o32 kernels only.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Markos Chandras]

On 08/26/2015 06:10 PM, Mike Frysinger wrote:
> On 26 Aug 2015 09:30, Joseph Myers wrote:
>> On Wed, 26 Aug 2015, Mike Frysinger wrote:
>>> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
>>> keep in sync with it.
>>>
>>> 2015-08-25  Mike Frysinger  <vapier@gentoo.org>
>>>
>>> 	[BZ #18863]
>>> 	* sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
>>> 	(si_call_addr): Define.
>>> 	(si_syscall): Define.
>>> 	(si_arch): Define.
>>
>> OK.  CC to linux-mips because I see that the MIPS implementation of 
>> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
>> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
> 
> i'm getting reports of seccomp misbehavior on mips already which is what
> started me down this glibc path.  i suspect the original port was tested
> against o32 kernels only.
> -mike
> 

I have recently tested mips64 n64/n32 with the testsuite from libseccomp
and that led me to this fix

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8

if you are aware of other problems (and perhaps a test to trigger them)
that could be kernel related let me know

-- 
markos

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Markos Chandras]

On 08/26/2015 06:10 PM, Mike Frysinger wrote:
> On 26 Aug 2015 09:30, Joseph Myers wrote:
>> On Wed, 26 Aug 2015, Mike Frysinger wrote:
>>> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
>>> keep in sync with it.
>>>
>>> 2015-08-25  Mike Frysinger  <vapier@gentoo.org>
>>>
>>> 	[BZ #18863]
>>> 	* sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
>>> 	(si_call_addr): Define.
>>> 	(si_syscall): Define.
>>> 	(si_arch): Define.
>>
>> OK.  CC to linux-mips because I see that the MIPS implementation of 
>> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
>> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
> 
> i'm getting reports of seccomp misbehavior on mips already which is what
> started me down this glibc path.  i suspect the original port was tested
> against o32 kernels only.
> -mike
> 

I have recently tested mips64 n64/n32 with the testsuite from libseccomp
and that led me to this fix

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8

if you are aware of other problems (and perhaps a test to trigger them)
that could be kernel related let me know

-- 
markos

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Joseph Myers]

On Thu, 27 Aug 2015, Markos Chandras wrote:

> >> OK.  CC to linux-mips because I see that the MIPS implementation of 
> >> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
> >> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
> > 
> > i'm getting reports of seccomp misbehavior on mips already which is what
> > started me down this glibc path.  i suspect the original port was tested
> > against o32 kernels only.
> > -mike
> > 
> 
> I have recently tested mips64 n64/n32 with the testsuite from libseccomp
> and that led me to this fix
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8
> 
> if you are aware of other problems (and perhaps a test to trigger them)
> that could be kernel related let me know

My observation about copy_siginfo_to_user32 missing a case was purely 
based on the kernel source code.  I've no reason to think it has anything 
to do with seccomp problems.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Joseph Myers]

On Thu, 27 Aug 2015, Markos Chandras wrote:

> >> OK.  CC to linux-mips because I see that the MIPS implementation of 
> >> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
> >> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
> > 
> > i'm getting reports of seccomp misbehavior on mips already which is what
> > started me down this glibc path.  i suspect the original port was tested
> > against o32 kernels only.
> > -mike
> > 
> 
> I have recently tested mips64 n64/n32 with the testsuite from libseccomp
> and that led me to this fix
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8
> 
> if you are aware of other problems (and perhaps a test to trigger them)
> that could be kernel related let me know

My observation about copy_siginfo_to_user32 missing a case was purely 
based on the kernel source code.  I've no reason to think it has anything 
to do with seccomp problems.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Markos Chandras]

On 08/27/2015 10:41 AM, Joseph Myers wrote:
> On Thu, 27 Aug 2015, Markos Chandras wrote:
> 
>>>> OK.  CC to linux-mips because I see that the MIPS implementation of 
>>>> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
>>>> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
>>>
>>> i'm getting reports of seccomp misbehavior on mips already which is what
>>> started me down this glibc path.  i suspect the original port was tested
>>> against o32 kernels only.
>>> -mike
>>>
>>
>> I have recently tested mips64 n64/n32 with the testsuite from libseccomp
>> and that led me to this fix
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8
>>
>> if you are aware of other problems (and perhaps a test to trigger them)
>> that could be kernel related let me know
> 
> My observation about copy_siginfo_to_user32 missing a case was purely 
> based on the kernel source code.  I've no reason to think it has anything 
> to do with seccomp problems.
> 

Yeah, my email was directed to Mike who said he is getting reports that
seccomp on MIPS has issues and that led him to his glibc patch.

-- 
markos

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Markos Chandras]

On 08/27/2015 10:41 AM, Joseph Myers wrote:
> On Thu, 27 Aug 2015, Markos Chandras wrote:
> 
>>>> OK.  CC to linux-mips because I see that the MIPS implementation of 
>>>> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
>>>> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
>>>
>>> i'm getting reports of seccomp misbehavior on mips already which is what
>>> started me down this glibc path.  i suspect the original port was tested
>>> against o32 kernels only.
>>> -mike
>>>
>>
>> I have recently tested mips64 n64/n32 with the testsuite from libseccomp
>> and that led me to this fix
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8
>>
>> if you are aware of other problems (and perhaps a test to trigger them)
>> that could be kernel related let me know
> 
> My observation about copy_siginfo_to_user32 missing a case was purely 
> based on the kernel source code.  I've no reason to think it has anything 
> to do with seccomp problems.
> 

Yeah, my email was directed to Mike who said he is getting reports that
seccomp on MIPS has issues and that led him to his glibc patch.

-- 
markos

Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

On 27 Aug 2015 09:00, Markos Chandras wrote:
> On 08/26/2015 06:10 PM, Mike Frysinger wrote:
> > On 26 Aug 2015 09:30, Joseph Myers wrote:
> >> On Wed, 26 Aug 2015, Mike Frysinger wrote:
> >>> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
> >>> keep in sync with it.
> >>>
> >>> 2015-08-25  Mike Frysinger  <vapier@gentoo.org>
> >>>
> >>> 	[BZ #18863]
> >>> 	* sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
> >>> 	(si_call_addr): Define.
> >>> 	(si_syscall): Define.
> >>> 	(si_arch): Define.
> >>
> >> OK.  CC to linux-mips because I see that the MIPS implementation of 
> >> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so 
> >> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
> > 
> > i'm getting reports of seccomp misbehavior on mips already which is what
> > started me down this glibc path.  i suspect the original port was tested
> > against o32 kernels only.
> > -mike
> > 
> 
> I have recently tested mips64 n64/n32 with the testsuite from libseccomp
> and that led me to this fix
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8
> 
> if you are aware of other problems (and perhaps a test to trigger them)
> that could be kernel related let me know

i was waiting on kumba to file a bug, and recover my mips box when i got
local access to it again to check another report.  but if libseccomp is
passing its unittests now as n64/n32 userland, i think that should cover
things.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]