From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
robert.jarzmik@free.fr, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Yi Zhang <yizhang@marvell.com>
Subject: Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer
Date: Mon, 14 Sep 2015 10:37:08 +0530 [thread overview]
Message-ID: <55F655FC.8070308@linaro.org> (raw)
In-Reply-To: <20150911185312.GA1516@katana>
On Saturday 12 September 2015 12:23 AM, Wolfram Sang wrote:
> On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote:
>> From: Yi Zhang <yizhang@marvell.com>
>>
>> Enable i2c module/unit before transmission and disable when it
>> finishes.
>>
>> why?
>> It's because the i2c bus may be disturbed if the slave device,
>> typically a touch, powers on.
>
> I am not convinced, "may disturb" is too weak for me. It would need a
> way more detailed description of the problem which makes clear that
> this mechanism is the only way to go forward.
>
Hmm, Ok.
Not sure what else I can bring up here.
> Can't you use Runtime PM for that?
>
I haven't tried it though, I can give a try and check.
Thanks,
Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer
Date: Mon, 14 Sep 2015 10:37:08 +0530 [thread overview]
Message-ID: <55F655FC.8070308@linaro.org> (raw)
In-Reply-To: <20150911185312.GA1516@katana>
On Saturday 12 September 2015 12:23 AM, Wolfram Sang wrote:
> On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote:
>> From: Yi Zhang <yizhang@marvell.com>
>>
>> Enable i2c module/unit before transmission and disable when it
>> finishes.
>>
>> why?
>> It's because the i2c bus may be disturbed if the slave device,
>> typically a touch, powers on.
>
> I am not convinced, "may disturb" is too weak for me. It would need a
> way more detailed description of the problem which makes clear that
> this mechanism is the only way to go forward.
>
Hmm, Ok.
Not sure what else I can bring up here.
> Can't you use Runtime PM for that?
>
I haven't tried it though, I can give a try and check.
Thanks,
Vaibhav
next prev parent reply other threads:[~2015-09-14 5:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 5:59 [PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device Vaibhav Hiremath
2015-08-24 5:59 ` Vaibhav Hiremath
2015-08-24 5:59 ` Vaibhav Hiremath
2015-08-24 5:59 ` [PATCH-v5 RESEND 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa Vaibhav Hiremath
2015-08-24 5:59 ` Vaibhav Hiremath
2015-08-24 5:59 ` [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer Vaibhav Hiremath
2015-08-24 5:59 ` Vaibhav Hiremath
[not found] ` <1440395978-9065-3-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-11 18:53 ` Wolfram Sang
2015-09-11 18:53 ` Wolfram Sang
2015-09-11 18:53 ` Wolfram Sang
2015-09-14 5:07 ` Vaibhav Hiremath [this message]
2015-09-14 5:07 ` Vaibhav Hiremath
2015-10-25 8:21 ` Wolfram Sang
2015-10-25 8:21 ` Wolfram Sang
2015-08-24 5:59 ` [PATCH-v5 RESEND 3/5] i2c: pxa: Add support for pxa910/988 & new configuration features Vaibhav Hiremath
2015-08-24 5:59 ` Vaibhav Hiremath
[not found] ` <1440395978-9065-4-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-11 19:06 ` Wolfram Sang
2015-09-11 19:06 ` Wolfram Sang
2015-09-11 19:06 ` Wolfram Sang
2015-09-14 5:28 ` Vaibhav Hiremath
2015-09-14 5:28 ` Vaibhav Hiremath
2015-09-14 5:28 ` Vaibhav Hiremath
2015-10-25 8:40 ` Wolfram Sang
2015-10-25 8:40 ` Wolfram Sang
2015-10-25 8:25 ` Wolfram Sang
2015-10-25 8:25 ` Wolfram Sang
2015-08-24 5:59 ` [PATCH-v5 RESEND 4/5] Documentation: binding: add sclk adjustment properties to i2c-pxa Vaibhav Hiremath
2015-08-24 5:59 ` Vaibhav Hiremath
[not found] ` <1440395978-9065-5-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-10-25 8:37 ` Wolfram Sang
2015-10-25 8:37 ` Wolfram Sang
2015-10-25 8:37 ` Wolfram Sang
2015-08-24 5:59 ` [PATCH-v5 RESEND 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support Vaibhav Hiremath
2015-08-24 5:59 ` Vaibhav Hiremath
[not found] ` <1440395978-9065-1-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-02 6:47 ` [PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device Vaibhav Hiremath
2015-09-02 6:47 ` Vaibhav Hiremath
2015-09-02 6:47 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F655FC.8070308@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
--cc=yizhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.