From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Lukasz Majewski <l.majewski@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support
Date: Tue, 13 Oct 2015 09:14:38 +0900 [thread overview]
Message-ID: <561C4CEE.3050905@samsung.com> (raw)
In-Reply-To: <CANAwSgSLFviT4ZNXTYwxYs2pbrr9ozJmPMauhgRPO0556Rsr_g@mail.gmail.com>
On 13.10.2015 00:32, Anand Moon wrote:
> Hi Krzysztof,
>
> On 12 October 2015 at 11:14, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 12.10.2015 00:46, Anand Moon wrote:
>>> Added support for UHS-I bus speed 50MB/s (SDR50, DDR50) 104MB/s (SDR104)
>>
>> This description is not entirely correct. The MMC driver already
>> supports these UHS speeds (you did not any code) so you rather enabled
>> it (description of bindings says "is supported").
>>
>> You mentioned DDR50 but I don't see respective property below.
>>
>> How do you know that these modes are really supported? I don't know. Can
>> you convince me?
>
> Setting this DDR50 capability give me this error. That's the reason to
> drop this capability.
But you mentioned it in commit message! "Added support for UHS-I ...
(DDR50)"
In the same time dropping DDR50 is not an sufficient proof that "SDR50
and SDR104 are really supported".
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support
Date: Tue, 13 Oct 2015 09:14:38 +0900 [thread overview]
Message-ID: <561C4CEE.3050905@samsung.com> (raw)
In-Reply-To: <CANAwSgSLFviT4ZNXTYwxYs2pbrr9ozJmPMauhgRPO0556Rsr_g@mail.gmail.com>
On 13.10.2015 00:32, Anand Moon wrote:
> Hi Krzysztof,
>
> On 12 October 2015 at 11:14, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 12.10.2015 00:46, Anand Moon wrote:
>>> Added support for UHS-I bus speed 50MB/s (SDR50, DDR50) 104MB/s (SDR104)
>>
>> This description is not entirely correct. The MMC driver already
>> supports these UHS speeds (you did not any code) so you rather enabled
>> it (description of bindings says "is supported").
>>
>> You mentioned DDR50 but I don't see respective property below.
>>
>> How do you know that these modes are really supported? I don't know. Can
>> you convince me?
>
> Setting this DDR50 capability give me this error. That's the reason to
> drop this capability.
But you mentioned it in commit message! "Added support for UHS-I ...
(DDR50)"
In the same time dropping DDR50 is not an sufficient proof that "SDR50
and SDR104 are really supported".
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-13 0:14 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 15:46 [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon
2015-10-11 15:46 ` Anand Moon
2015-10-11 15:46 ` [PATCH 2/3] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3 Anand Moon
2015-10-11 15:46 ` Anand Moon
2015-10-12 4:42 ` Krzysztof Kozlowski
2015-10-12 4:42 ` Krzysztof Kozlowski
2015-10-12 5:49 ` Krzysztof Kozlowski
2015-10-12 5:49 ` Krzysztof Kozlowski
2015-10-12 11:08 ` Anand Moon
2015-10-12 11:08 ` Anand Moon
2015-10-12 12:13 ` Krzysztof Kozlowski
2015-10-12 12:13 ` Krzysztof Kozlowski
2015-10-12 14:33 ` Anand Moon
2015-10-12 14:33 ` Anand Moon
2015-10-13 0:10 ` Krzysztof Kozlowski
2015-10-13 0:10 ` Krzysztof Kozlowski
2015-10-13 2:29 ` Anand Moon
2015-10-13 2:29 ` Anand Moon
2015-10-13 2:39 ` Jaehoon Chung
2015-10-13 2:39 ` Jaehoon Chung
[not found] ` <561C6ED3.4090101-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 2:45 ` Anand Moon
2015-10-13 2:45 ` Anand Moon
2015-10-13 2:45 ` Anand Moon
2015-10-11 15:46 ` [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon
2015-10-11 15:46 ` Anand Moon
[not found] ` <1444578364-1384-3-git-send-email-linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-12 5:44 ` Krzysztof Kozlowski
2015-10-12 5:44 ` Krzysztof Kozlowski
2015-10-12 5:44 ` Krzysztof Kozlowski
2015-10-12 10:46 ` Anand Moon
2015-10-12 10:46 ` Anand Moon
2015-10-12 10:51 ` Jaehoon Chung
2015-10-12 10:51 ` Jaehoon Chung
2015-10-12 11:23 ` Anand Moon
2015-10-12 11:23 ` Anand Moon
2015-10-12 12:42 ` Krzysztof Kozlowski
2015-10-12 12:42 ` Krzysztof Kozlowski
2015-10-12 13:04 ` Jaehoon Chung
2015-10-12 13:04 ` Jaehoon Chung
2015-10-12 13:16 ` Krzysztof Kozlowski
2015-10-12 13:16 ` Krzysztof Kozlowski
2015-10-13 2:28 ` Jaehoon Chung
2015-10-13 2:28 ` Jaehoon Chung
2015-10-12 15:32 ` Anand Moon
2015-10-12 15:32 ` Anand Moon
2015-10-13 0:14 ` Krzysztof Kozlowski [this message]
2015-10-13 0:14 ` Krzysztof Kozlowski
2015-10-13 3:08 ` Anand Moon
2015-10-13 3:08 ` Anand Moon
2015-10-13 3:43 ` Krzysztof Kozlowski
2015-10-13 3:43 ` Krzysztof Kozlowski
[not found] ` <561C7DF1.6000609-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 3:49 ` Anand Moon
2015-10-13 3:49 ` Anand Moon
2015-10-13 3:49 ` Anand Moon
2015-10-13 16:27 ` Anand Moon
2015-10-13 16:27 ` Anand Moon
2015-10-13 16:27 ` Anand Moon
2015-10-13 23:59 ` Krzysztof Kozlowski
2015-10-13 23:59 ` Krzysztof Kozlowski
2015-10-14 1:06 ` Alim Akhtar
2015-10-14 1:06 ` Alim Akhtar
2015-10-14 1:15 ` Krzysztof Kozlowski
2015-10-14 1:15 ` Krzysztof Kozlowski
2015-10-14 1:40 ` Jaehoon Chung
2015-10-14 1:40 ` Jaehoon Chung
2015-10-14 1:52 ` Krzysztof Kozlowski
2015-10-14 1:52 ` Krzysztof Kozlowski
2015-10-14 2:08 ` Alim Akhtar
2015-10-14 2:08 ` Alim Akhtar
2015-10-14 2:13 ` Alim Akhtar
2015-10-14 2:13 ` Alim Akhtar
2015-10-14 2:20 ` Krzysztof Kozlowski
2015-10-14 2:20 ` Krzysztof Kozlowski
2015-10-14 2:26 ` Alim Akhtar
2015-10-14 2:26 ` Alim Akhtar
2015-10-14 22:40 ` Doug Anderson
2015-10-14 22:40 ` Doug Anderson
2015-10-19 10:11 ` Anand Moon
2015-10-19 10:11 ` Anand Moon
2015-10-19 13:43 ` Krzysztof Kozlowski
2015-10-19 13:43 ` Krzysztof Kozlowski
[not found] ` <CANAwSgSd8sHDcmGmck=Em2H5WJzVWM28cbvs9z6CFgpuTY_Juw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-19 15:11 ` Doug Anderson
2015-10-19 15:11 ` Doug Anderson
2015-10-19 15:11 ` Doug Anderson
2015-10-14 3:58 ` Anand Moon
2015-10-14 3:58 ` Anand Moon
2015-10-14 4:18 ` Krzysztof Kozlowski
2015-10-14 4:18 ` Krzysztof Kozlowski
2015-10-21 10:28 ` Jaehoon Chung
2015-10-21 10:28 ` Jaehoon Chung
2015-10-12 4:29 ` [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Krzysztof Kozlowski
2015-10-12 4:29 ` Krzysztof Kozlowski
2015-10-12 4:43 ` Jaehoon Chung
2015-10-12 4:43 ` Jaehoon Chung
2015-10-12 14:47 ` Anand Moon
2015-10-12 14:47 ` Anand Moon
2015-10-13 0:12 ` Krzysztof Kozlowski
2015-10-13 0:12 ` Krzysztof Kozlowski
[not found] ` <561C4C88.2040004-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 2:06 ` Jaehoon Chung
2015-10-13 2:06 ` Jaehoon Chung
2015-10-13 2:06 ` Jaehoon Chung
2015-10-13 3:21 ` Anand Moon
2015-10-13 3:21 ` Anand Moon
[not found] ` <561C6713.1070508-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 4:07 ` Anand Moon
2015-10-13 4:07 ` Anand Moon
2015-10-13 4:07 ` Anand Moon
2015-10-13 2:41 ` Anand Moon
2015-10-13 2:41 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561C4CEE.3050905@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.