All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: lee.jones@linaro.org, broonie@kernel.org,
	linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
Date: Mon, 02 Nov 2015 08:46:21 +0900	[thread overview]
Message-ID: <5636A44D.4090908@samsung.com> (raw)
In-Reply-To: <20151101174048.GD22331@piout.net>

On 02.11.2015 02:40, Alexandre Belloni wrote:
> On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote :
>> RTC found in s2mps15 is almost same as one found on s2mps13
>> with few differences in RTC_UPDATE register fields, like:
>> 1> Bit[4] and Bit[1] are reversed
>>    - On s2mps13
>>           WUDR -> bit[4], AUDR -> bit[1]
>>    - On s2mps15
>> 	  WUDR -> bit[1], AUDR -> bit[4]
>> 2> In case of s2mps13, for alarm register, need to set both
>>    WDUR and ADUR high, whereas for s2mps15 only set AUDR to high.
>> 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used
>>    at the same time.
>>
>> This patch add required changes to enable s2mps15 rtc timer.
>>
>> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>>  drivers/rtc/rtc-s5m.c           |   37 +++++++++++++++++++++++++++++++++----
>>  include/linux/mfd/samsung/rtc.h |    2 ++
>>  2 files changed, 35 insertions(+), 4 deletions(-)
>>
> Applied after fixing the small alignment issue, thanks.
> 

I think you cannot apply it directly because it depends on headers from
patch 2/4. It won't build.

Best regards,
Krzysztof

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: lee.jones@linaro.org, broonie@kernel.org,
	linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC
Date: Mon, 02 Nov 2015 08:46:21 +0900	[thread overview]
Message-ID: <5636A44D.4090908@samsung.com> (raw)
In-Reply-To: <20151101174048.GD22331@piout.net>

On 02.11.2015 02:40, Alexandre Belloni wrote:
> On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote :
>> RTC found in s2mps15 is almost same as one found on s2mps13
>> with few differences in RTC_UPDATE register fields, like:
>> 1> Bit[4] and Bit[1] are reversed
>>    - On s2mps13
>>           WUDR -> bit[4], AUDR -> bit[1]
>>    - On s2mps15
>> 	  WUDR -> bit[1], AUDR -> bit[4]
>> 2> In case of s2mps13, for alarm register, need to set both
>>    WDUR and ADUR high, whereas for s2mps15 only set AUDR to high.
>> 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used
>>    at the same time.
>>
>> This patch add required changes to enable s2mps15 rtc timer.
>>
>> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>>  drivers/rtc/rtc-s5m.c           |   37 +++++++++++++++++++++++++++++++++----
>>  include/linux/mfd/samsung/rtc.h |    2 ++
>>  2 files changed, 35 insertions(+), 4 deletions(-)
>>
> Applied after fixing the small alignment issue, thanks.
> 

I think you cannot apply it directly because it depends on headers from
patch 2/4. It won't build.

Best regards,
Krzysztof

  reply	other threads:[~2015-11-01 23:46 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30  6:25 [rtc-linux] [PATCH v5 0/4] mfd: sec: add S2MPS15 PMIC support Alim Akhtar
2015-10-30  6:25 ` Alim Akhtar
2015-10-30  6:25 ` [rtc-linux] [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC Alim Akhtar
2015-10-30  6:25   ` Alim Akhtar
2015-10-30  7:42   ` [rtc-linux] " Krzysztof Kozlowski
2015-10-30  7:42     ` Krzysztof Kozlowski
2015-10-30  9:25     ` [rtc-linux] " Alim Akhtar
2015-10-30  9:25       ` Alim Akhtar
2015-10-30 17:24   ` [rtc-linux] " Lee Jones
2015-10-30 17:24     ` Lee Jones
2015-11-06 22:33   ` [rtc-linux] " Rob Herring
2015-11-06 22:33     ` Rob Herring
2015-11-06 22:33     ` Rob Herring
2015-11-07  1:11     ` [rtc-linux] " Alim Akhtar
2015-11-07  1:11       ` Alim Akhtar
2015-11-07  1:11       ` Alim Akhtar
2015-11-07  3:09     ` [rtc-linux] " Krzysztof Kozlowski
2015-11-07  3:09       ` Krzysztof Kozlowski
2015-11-09  5:54       ` Alim Akhtar
2015-11-09  5:54         ` Alim Akhtar
2015-11-09  6:40         ` Krzysztof Kozlowski
2015-11-09  6:40           ` Krzysztof Kozlowski
2015-10-30  6:25 ` [rtc-linux] [PATCH v5 2/4] mfd: sec: Add support for S2MPS15 PMIC Alim Akhtar
2015-10-30  6:25   ` Alim Akhtar
2015-10-30  6:25 ` [rtc-linux] [PATCH v5 3/4] regulator: s2mps11: add support for S2MPS15 regulators Alim Akhtar
2015-10-30  6:25   ` Alim Akhtar
2015-10-30  6:25 ` [rtc-linux] [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC Alim Akhtar
2015-10-30  6:25   ` Alim Akhtar
2015-10-30  8:38   ` [rtc-linux] " Krzysztof Kozlowski
2015-10-30  8:38     ` Krzysztof Kozlowski
2015-10-30  9:28     ` [rtc-linux] " Alim Akhtar
2015-10-30  9:28       ` Alim Akhtar
2015-10-30 17:23   ` [rtc-linux] " Lee Jones
2015-10-30 17:23     ` Lee Jones
2015-11-01 17:40   ` [rtc-linux] " Alexandre Belloni
2015-11-01 17:40     ` Alexandre Belloni
2015-11-01 23:46     ` Krzysztof Kozlowski [this message]
2015-11-01 23:46       ` Krzysztof Kozlowski
2015-11-02  0:47       ` [rtc-linux] " Alexandre Belloni
2015-11-02  0:47         ` Alexandre Belloni
2015-11-02  9:03         ` [rtc-linux] " Lee Jones
2015-11-02  9:03           ` Lee Jones
2015-11-02 10:19           ` [rtc-linux] " Alexandre Belloni
2015-11-02 10:19             ` Alexandre Belloni
2015-11-02 10:58             ` [rtc-linux] " Lee Jones
2015-11-02 10:58               ` Lee Jones
2015-11-19 18:00 ` [rtc-linux] Re: [PATCH v5 0/4] mfd: sec: add S2MPS15 PMIC support Alim Akhtar
2015-11-19 18:00   ` Alim Akhtar
2015-11-20  9:05   ` [rtc-linux] " Lee Jones
2015-11-20  9:05     ` Lee Jones
2015-11-20  9:15     ` [rtc-linux] " Alim Akhtar
2015-11-20  9:15       ` Alim Akhtar
2015-11-20 10:31       ` [rtc-linux] " Lee Jones
2015-11-20 10:31         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5636A44D.4090908@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=alim.akhtar@samsung.com \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.