* [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER @ 2015-11-13 10:04 Hongxu Jia 2015-11-13 10:13 ` Andreas Müller 0 siblings, 1 reply; 9+ messages in thread From: Hongxu Jia @ 2015-11-13 10:04 UTC (permalink / raw) To: openembedded-devel The NETWORK_MANAGER is connman-gnome in oe-core by default, which conflicts with networkmanager. And networkmanager is required by xfce4-power-manager in meta-xfce. So we explicitly set networkmanager to NETWORK_MANAGER for meta-xfce. Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> --- meta-xfce/conf/layer.conf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta-xfce/conf/layer.conf b/meta-xfce/conf/layer.conf index 55bcef6..e38d85d 100644 --- a/meta-xfce/conf/layer.conf +++ b/meta-xfce/conf/layer.conf @@ -17,3 +17,6 @@ LAYERDEPENDS_xfce-layer += "openembedded-layer" LAYERDEPENDS_xfce-layer += "gnome-layer" LAYERDEPENDS_xfce-layer += "openembedded-layer" LAYERDEPENDS_xfce-layer += "meta-python" + +# It is required by xfce4-power-manager +NETWORK_MANAGER = "networkmanager" -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 10:04 [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER Hongxu Jia @ 2015-11-13 10:13 ` Andreas Müller 2015-11-13 10:19 ` Martin Jansa 0 siblings, 1 reply; 9+ messages in thread From: Andreas Müller @ 2015-11-13 10:13 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org On Fri, Nov 13, 2015 at 11:04 AM, Hongxu Jia <hongxu.jia@windriver.com> wrote: > The NETWORK_MANAGER is connman-gnome in oe-core by default, > which conflicts with networkmanager. And networkmanager is > required by xfce4-power-manager in meta-xfce. So we explicitly > set networkmanager to NETWORK_MANAGER for meta-xfce. > > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> > --- > meta-xfce/conf/layer.conf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta-xfce/conf/layer.conf b/meta-xfce/conf/layer.conf > index 55bcef6..e38d85d 100644 > --- a/meta-xfce/conf/layer.conf > +++ b/meta-xfce/conf/layer.conf > @@ -17,3 +17,6 @@ LAYERDEPENDS_xfce-layer += "openembedded-layer" > LAYERDEPENDS_xfce-layer += "gnome-layer" > LAYERDEPENDS_xfce-layer += "openembedded-layer" > LAYERDEPENDS_xfce-layer += "meta-python" > + > +# It is required by xfce4-power-manager > +NETWORK_MANAGER = "networkmanager" > -- I was wondering why I never needed such kind of patch and checked: In my layers It is only used in packagegroup-core-x11-sato. So I am fine with this patch but could you mention packagegroup-core-x11-sato in the commit message please. Andreas ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 10:13 ` Andreas Müller @ 2015-11-13 10:19 ` Martin Jansa 2015-11-13 10:36 ` Andreas Müller 2015-11-13 10:36 ` Hongxu Jia 0 siblings, 2 replies; 9+ messages in thread From: Martin Jansa @ 2015-11-13 10:19 UTC (permalink / raw) To: openembedded-devel Why not use VIRTUAL-RUNTIME variable like in other places? And if it's needed by xfce4-power-manager, then why don't you add it to RDEPENDS there? On Fri, Nov 13, 2015 at 11:13 AM, Andreas Müller < schnitzeltony@googlemail.com> wrote: > On Fri, Nov 13, 2015 at 11:04 AM, Hongxu Jia <hongxu.jia@windriver.com> > wrote: > > The NETWORK_MANAGER is connman-gnome in oe-core by default, > > which conflicts with networkmanager. And networkmanager is > > required by xfce4-power-manager in meta-xfce. So we explicitly > > set networkmanager to NETWORK_MANAGER for meta-xfce. > > > > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> > > --- > > meta-xfce/conf/layer.conf | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/meta-xfce/conf/layer.conf b/meta-xfce/conf/layer.conf > > index 55bcef6..e38d85d 100644 > > --- a/meta-xfce/conf/layer.conf > > +++ b/meta-xfce/conf/layer.conf > > @@ -17,3 +17,6 @@ LAYERDEPENDS_xfce-layer += "openembedded-layer" > > LAYERDEPENDS_xfce-layer += "gnome-layer" > > LAYERDEPENDS_xfce-layer += "openembedded-layer" > > LAYERDEPENDS_xfce-layer += "meta-python" > > + > > +# It is required by xfce4-power-manager > > +NETWORK_MANAGER = "networkmanager" > > -- > I was wondering why I never needed such kind of patch and checked: In > my layers It is only used in packagegroup-core-x11-sato. > > So I am fine with this patch but could you mention > packagegroup-core-x11-sato in the commit message please. > > Andreas > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 10:19 ` Martin Jansa @ 2015-11-13 10:36 ` Andreas Müller 2015-11-13 11:45 ` Hongxu Jia 2015-11-13 10:36 ` Hongxu Jia 1 sibling, 1 reply; 9+ messages in thread From: Andreas Müller @ 2015-11-13 10:36 UTC (permalink / raw) To: openembedded-devel@lists.openembedded.org On Fri, Nov 13, 2015 at 11:19 AM, Martin Jansa <martin.jansa@gmail.com> wrote: > Why not use VIRTUAL-RUNTIME variable like in other places? And if it's > needed by xfce4-power-manager, then why don't you add it to RDEPENDS there? > networkmanager is already in RDEPENDS of xfce4-power-manager. I think when building an image packagegroup-core-x11-sato there is a conflict. I looked into this a bit more and think: 1. networkmanger support is optional so a packagroup would allow conman and xfce4-power-manager live together in harmony 2. I think the patch goes much to far: To have networkmanager in images based on packagegroup-core-x11-sato the correct way would be to write NETWORK_MANAGER = "networkmanager" in the image recipe. Andreas ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 10:36 ` Andreas Müller @ 2015-11-13 11:45 ` Hongxu Jia 2015-11-13 12:05 ` Andreas Müller 0 siblings, 1 reply; 9+ messages in thread From: Hongxu Jia @ 2015-11-13 11:45 UTC (permalink / raw) To: schnitzeltony, Martin Jansa; +Cc: openembedded-devel On 11/13/2015 06:36 PM, Andreas Müller wrote: > On Fri, Nov 13, 2015 at 11:19 AM, Martin Jansa <martin.jansa@gmail.com> wrote: >> Why not use VIRTUAL-RUNTIME variable like in other places? And if it's >> needed by xfce4-power-manager, then why don't you add it to RDEPENDS there? >> > networkmanager is already in RDEPENDS of xfce4-power-manager. I think > when building an image packagegroup-core-x11-sato there is a conflict. > > I looked into this a bit more and think: > 1. networkmanger support is optional so a packagroup would allow > conman and xfce4-power-manager live together in harmony > 2. I think the patch goes much to far: To have networkmanager in > images based on packagegroup-core-x11-sato the correct way would be to > write NETWORK_MANAGER = "networkmanager" in the image recipe. Hi Andreas, The condition of writing NETWORK_MANAGER = "networkmanager" is packagegroup-core-x11-sato + xfce4-power-manager, I think it is not proper to test the existence of them in an image recipe. Hi Martin & Andreas, How about we still do the setting in meta-xfce's local.conf and replace networkmanager with variable ${NETWORK_MANAGER} in xfce4-power-manager's RDEPENDS. So we could globally control network manager by variable ${NETWORK_MANAGER} for the similar issue. //Hongxu > Andreas ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 11:45 ` Hongxu Jia @ 2015-11-13 12:05 ` Andreas Müller 0 siblings, 0 replies; 9+ messages in thread From: Andreas Müller @ 2015-11-13 12:05 UTC (permalink / raw) To: Hongxu Jia; +Cc: openembedded-devel@lists.openembedded.org On Fri, Nov 13, 2015 at 12:45 PM, Hongxu Jia <hongxu.jia@windriver.com> wrote: > On 11/13/2015 06:36 PM, Andreas Müller wrote: >> >> On Fri, Nov 13, 2015 at 11:19 AM, Martin Jansa <martin.jansa@gmail.com> >> wrote: >>> >>> Why not use VIRTUAL-RUNTIME variable like in other places? And if it's >>> needed by xfce4-power-manager, then why don't you add it to RDEPENDS >>> there? >>> >> networkmanager is already in RDEPENDS of xfce4-power-manager. I think >> when building an image packagegroup-core-x11-sato there is a conflict. >> >> I looked into this a bit more and think: >> 1. networkmanger support is optional so a packagroup would allow >> conman and xfce4-power-manager live together in harmony >> 2. I think the patch goes much to far: To have networkmanager in >> images based on packagegroup-core-x11-sato the correct way would be to >> write NETWORK_MANAGER = "networkmanager" in the image recipe. > > > Hi Andreas, > > The condition of writing NETWORK_MANAGER = "networkmanager" is > packagegroup-core-x11-sato + xfce4-power-manager, I think it is not > proper to test the existence of them in an image recipe. Here I was wrong > > Hi Martin & Andreas, > > How about we still do the setting in meta-xfce's local.conf and replace > networkmanager with variable ${NETWORK_MANAGER} in > xfce4-power-manager's RDEPENDS. > > So we could globally control network manager by variable > ${NETWORK_MANAGER} for the similar issue. > > //Hongxu >> >> Andreas > packagegroup-core-x11-sato ships a more or less complete matchbox-desktop. Why build this together with xfce? OK even if you really want to do that for some reason - I think this is a corner case. So why adding a layer - global variable for this? So I think * If you want to use xfce4-power-manager + packagegroup-core-x11-sato + connman -> add a packageconfig in xfce4-power-manager * If you are looking for a solution to make packagegroup-core-x11-sato use networkmanager ask somwhere else this is not meta-xfce's job Andreas Andreas ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 10:19 ` Martin Jansa 2015-11-13 10:36 ` Andreas Müller @ 2015-11-13 10:36 ` Hongxu Jia 2015-11-13 10:49 ` Hongxu Jia 1 sibling, 1 reply; 9+ messages in thread From: Hongxu Jia @ 2015-11-13 10:36 UTC (permalink / raw) To: openembedded-devel On 11/13/2015 06:19 PM, Martin Jansa wrote: > Why not use VIRTUAL-RUNTIME variable like in other places? If use it, I will rename NETWORK_MANAGER with VIRTUAL-RUNTIME_networkmanager in packagegroup-core-x11-sato, to see oe-core whether accept it or not. > And if it's > needed by xfce4-power-manager, then why don't you add it to RDEPENDS there? It is reasonable, add the variable(NETWORK_MANAGER or VIRTUAL-RUNTIME_networkmanager) to xfce4-power-manager'S RDEPENDS //Hongxu > On Fri, Nov 13, 2015 at 11:13 AM, Andreas Müller < > schnitzeltony@googlemail.com> wrote: > >> On Fri, Nov 13, 2015 at 11:04 AM, Hongxu Jia <hongxu.jia@windriver.com> >> wrote: >>> The NETWORK_MANAGER is connman-gnome in oe-core by default, >>> which conflicts with networkmanager. And networkmanager is >>> required by xfce4-power-manager in meta-xfce. So we explicitly >>> set networkmanager to NETWORK_MANAGER for meta-xfce. >>> >>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> >>> --- >>> meta-xfce/conf/layer.conf | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/meta-xfce/conf/layer.conf b/meta-xfce/conf/layer.conf >>> index 55bcef6..e38d85d 100644 >>> --- a/meta-xfce/conf/layer.conf >>> +++ b/meta-xfce/conf/layer.conf >>> @@ -17,3 +17,6 @@ LAYERDEPENDS_xfce-layer += "openembedded-layer" >>> LAYERDEPENDS_xfce-layer += "gnome-layer" >>> LAYERDEPENDS_xfce-layer += "openembedded-layer" >>> LAYERDEPENDS_xfce-layer += "meta-python" >>> + >>> +# It is required by xfce4-power-manager >>> +NETWORK_MANAGER = "networkmanager" >>> -- >> I was wondering why I never needed such kind of patch and checked: In >> my layers It is only used in packagegroup-core-x11-sato. >> >> So I am fine with this patch but could you mention >> packagegroup-core-x11-sato in the commit message please. >> >> Andreas >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 10:36 ` Hongxu Jia @ 2015-11-13 10:49 ` Hongxu Jia 2015-11-13 10:53 ` Andreas Müller 0 siblings, 1 reply; 9+ messages in thread From: Hongxu Jia @ 2015-11-13 10:49 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-devel On 11/13/2015 06:36 PM, Hongxu Jia wrote: > On 11/13/2015 06:19 PM, Martin Jansa wrote: > >> Why not use VIRTUAL-RUNTIME variable like in other places? > Hi Martin, With more investigation, I am afraid it looks not good to rename NETWORK_MANAGER in oe-core: In meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb ...... NETWORK_MANAGER ?= "connman-gnome" NETWORK_MANAGER_libc-uclibc = "" RDEPENDS_${PN}-base = "\ ... ${NETWORK_MANAGER} \ ...... If we name them with VIRTUAL-RUNTIME_networkmanager to replace, we have like this ...... VIRTUAL-RUNTIME_networkmanager ?= "connman-gnome" VIRTUAL-RUNTIME_networkmanager_libc-uclibc = "" RDEPENDS_${PN}-base = "\ ... ${VIRTUAL-RUNTIME_networkmanager} \ ...... It looks too many overrides, do you have any suggestions? //Hongxu > If use it, I will rename NETWORK_MANAGER with > VIRTUAL-RUNTIME_networkmanager > in packagegroup-core-x11-sato, to see oe-core whether accept it or not. > >> And if it's >> needed by xfce4-power-manager, then why don't you add it to RDEPENDS >> there? > > It is reasonable, add the variable(NETWORK_MANAGER or > VIRTUAL-RUNTIME_networkmanager) to xfce4-power-manager'S RDEPENDS > > //Hongxu > >> On Fri, Nov 13, 2015 at 11:13 AM, Andreas Müller < >> schnitzeltony@googlemail.com> wrote: >> >>> On Fri, Nov 13, 2015 at 11:04 AM, Hongxu Jia <hongxu.jia@windriver.com> >>> wrote: >>>> The NETWORK_MANAGER is connman-gnome in oe-core by default, >>>> which conflicts with networkmanager. And networkmanager is >>>> required by xfce4-power-manager in meta-xfce. So we explicitly >>>> set networkmanager to NETWORK_MANAGER for meta-xfce. >>>> >>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> >>>> --- >>>> meta-xfce/conf/layer.conf | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/meta-xfce/conf/layer.conf b/meta-xfce/conf/layer.conf >>>> index 55bcef6..e38d85d 100644 >>>> --- a/meta-xfce/conf/layer.conf >>>> +++ b/meta-xfce/conf/layer.conf >>>> @@ -17,3 +17,6 @@ LAYERDEPENDS_xfce-layer += "openembedded-layer" >>>> LAYERDEPENDS_xfce-layer += "gnome-layer" >>>> LAYERDEPENDS_xfce-layer += "openembedded-layer" >>>> LAYERDEPENDS_xfce-layer += "meta-python" >>>> + >>>> +# It is required by xfce4-power-manager >>>> +NETWORK_MANAGER = "networkmanager" >>>> -- >>> I was wondering why I never needed such kind of patch and checked: In >>> my layers It is only used in packagegroup-core-x11-sato. >>> >>> So I am fine with this patch but could you mention >>> packagegroup-core-x11-sato in the commit message please. >>> >>> Andreas >>> -- >>> _______________________________________________ >>> Openembedded-devel mailing list >>> Openembedded-devel@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >>> > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER 2015-11-13 10:49 ` Hongxu Jia @ 2015-11-13 10:53 ` Andreas Müller 0 siblings, 0 replies; 9+ messages in thread From: Andreas Müller @ 2015-11-13 10:53 UTC (permalink / raw) To: Hongxu Jia; +Cc: openembedded-devel@lists.openembedded.org On Fri, Nov 13, 2015 at 11:49 AM, Hongxu Jia <hongxu.jia@windriver.com> wrote: > On 11/13/2015 06:36 PM, Hongxu Jia wrote: >> >> On 11/13/2015 06:19 PM, Martin Jansa wrote: >> >>> Why not use VIRTUAL-RUNTIME variable like in other places? >> >> > > Hi Martin, > > With more investigation, I am afraid it looks not good to rename > NETWORK_MANAGER in > oe-core: > In meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb > ...... > NETWORK_MANAGER ?= "connman-gnome" > NETWORK_MANAGER_libc-uclibc = "" > RDEPENDS_${PN}-base = "\ > ... > ${NETWORK_MANAGER} \ > ...... > > If we name them with VIRTUAL-RUNTIME_networkmanager to replace, we have like > this > ...... > VIRTUAL-RUNTIME_networkmanager ?= "connman-gnome" > VIRTUAL-RUNTIME_networkmanager_libc-uclibc = "" > RDEPENDS_${PN}-base = "\ > ... > ${VIRTUAL-RUNTIME_networkmanager} \ > ...... > > It looks too many overrides, do you have any suggestions? Suggestion: read my previous mail :) Andreas ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-13 12:05 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-13 10:04 [meta-xfce][PATCH] meta-xfce/layer: explicitly set networkmanager to NETWORK_MANAGER Hongxu Jia 2015-11-13 10:13 ` Andreas Müller 2015-11-13 10:19 ` Martin Jansa 2015-11-13 10:36 ` Andreas Müller 2015-11-13 11:45 ` Hongxu Jia 2015-11-13 12:05 ` Andreas Müller 2015-11-13 10:36 ` Hongxu Jia 2015-11-13 10:49 ` Hongxu Jia 2015-11-13 10:53 ` Andreas Müller
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.