From: Cyrille Pitchen <cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: Mans Rullgard <mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>,
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Yang,
Wenyou" <Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice
Date: Tue, 12 Jan 2016 09:39:41 +0100 [thread overview]
Message-ID: <5694BBCD.8020700@atmel.com> (raw)
In-Reply-To: <1452528102-26458-1-git-send-email-mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
Hi Mans,
I've tried to apply your patch on a next-20160112 branch to test it but it
failed. I've also looked at the for-next branch of the SPI sub-system git
tree.
It seems that one issue occurred within a chunk patching the atmel_spi_setup()
function. Please see below.
Le 11/01/2016 17:01, Mans Rullgard a écrit :
[...]
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 08cbb3e43c76..d4a806e24060 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
[...]
> @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi)
> }
>
> asd->npcs_pin = npcs_pin;
> + asd->use_cs_gpio = use_cs_gpio;
> spi->controller_state = asd;
> } else {
> atmel_spi_lock(as);
[...]
There is no 'else' statement in the source code I'm looking at.
Best regards,
Cyrille
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: cyrille.pitchen@atmel.com (Cyrille Pitchen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice
Date: Tue, 12 Jan 2016 09:39:41 +0100 [thread overview]
Message-ID: <5694BBCD.8020700@atmel.com> (raw)
In-Reply-To: <1452528102-26458-1-git-send-email-mans@mansr.com>
Hi Mans,
I've tried to apply your patch on a next-20160112 branch to test it but it
failed. I've also looked at the for-next branch of the SPI sub-system git
tree.
It seems that one issue occurred within a chunk patching the atmel_spi_setup()
function. Please see below.
Le 11/01/2016 17:01, Mans Rullgard a ?crit :
[...]
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 08cbb3e43c76..d4a806e24060 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
[...]
> @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi)
> }
>
> asd->npcs_pin = npcs_pin;
> + asd->use_cs_gpio = use_cs_gpio;
> spi->controller_state = asd;
> } else {
> atmel_spi_lock(as);
[...]
There is no 'else' statement in the source code I'm looking at.
Best regards,
Cyrille
WARNING: multiple messages have this Message-ID (diff)
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
To: Mans Rullgard <mans@mansr.com>,
<linux-arm-kernel@lists.infradead.org>,
"Yang, Wenyou" <Wenyou.Yang@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice
Date: Tue, 12 Jan 2016 09:39:41 +0100 [thread overview]
Message-ID: <5694BBCD.8020700@atmel.com> (raw)
In-Reply-To: <1452528102-26458-1-git-send-email-mans@mansr.com>
Hi Mans,
I've tried to apply your patch on a next-20160112 branch to test it but it
failed. I've also looked at the for-next branch of the SPI sub-system git
tree.
It seems that one issue occurred within a chunk patching the atmel_spi_setup()
function. Please see below.
Le 11/01/2016 17:01, Mans Rullgard a écrit :
[...]
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 08cbb3e43c76..d4a806e24060 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
[...]
> @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi)
> }
>
> asd->npcs_pin = npcs_pin;
> + asd->use_cs_gpio = use_cs_gpio;
> spi->controller_state = asd;
> } else {
> atmel_spi_lock(as);
[...]
There is no 'else' statement in the source code I'm looking at.
Best regards,
Cyrille
next prev parent reply other threads:[~2016-01-12 8:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 16:01 [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Mans Rullgard
2016-01-11 16:01 ` Mans Rullgard
2016-01-11 16:01 ` Mans Rullgard
[not found] ` <1452528102-26458-1-git-send-email-mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org>
2016-01-11 16:13 ` Mark Brown
2016-01-11 16:13 ` Mark Brown
2016-01-11 16:13 ` Mark Brown
[not found] ` <20160111161333.GK6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-11 16:16 ` Måns Rullgård
2016-01-11 16:16 ` Måns Rullgård
2016-01-11 16:16 ` Måns Rullgård
2016-01-11 16:24 ` Mark Brown
2016-01-11 16:24 ` Mark Brown
2016-01-12 8:39 ` Cyrille Pitchen [this message]
2016-01-12 8:39 ` Cyrille Pitchen
2016-01-12 8:39 ` Cyrille Pitchen
[not found] ` <5694BBCD.8020700-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-01-12 8:51 ` Måns Rullgård
2016-01-12 8:51 ` Måns Rullgård
2016-01-12 8:51 ` Måns Rullgård
2016-01-12 8:52 ` Nicolas Ferre
2016-01-12 8:52 ` Nicolas Ferre
2016-01-12 8:52 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694BBCD.8020700@atmel.com \
--to=cyrille.pitchen-aife0yeh4naavxtiumwx3w@public.gmane.org \
--cc=Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.