All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Mike Frysinger <vapier@gentoo.org>, linux-kernel@vger.kernel.org
Cc: hch@lst.de, keith.busch@intel.com, axboe@fb.com, stable@vger.kernel.org
Subject: Re: [PATCH] uapi: update install list after nvme.h rename
Date: Tue, 12 Jan 2016 09:45:58 +0100	[thread overview]
Message-ID: <5694BD46.3030004@suse.cz> (raw)
In-Reply-To: <1452474851-386-1-git-send-email-vapier@gentoo.org>

On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
> Commit 9d99a8dda154 ("nvme: move hardware structures out of the uapi
> version of nvme.h") renamed nvme.h to nvme_ioctl.h, but the uapi list
> still refers to nvme.h.  People trying to install the headers hit a
> failure as the header no longer exists.

Wouldn't reverting the rename be nicer to userspace? So that the
filename is preserved and anybody who #included nvme.h still can do so?

> Cc: stable@vger.kernel.org
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  include/uapi/linux/Kbuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
> index dc6172c..7bb6aeb 100644
> --- a/include/uapi/linux/Kbuild
> +++ b/include/uapi/linux/Kbuild
> @@ -307,7 +307,7 @@ header-y += nfs_mount.h
>  header-y += nl80211.h
>  header-y += n_r3964.h
>  header-y += nubus.h
> -header-y += nvme.h
> +header-y += nvme_ioctl.h
>  header-y += nvram.h
>  header-y += omap3isp.h
>  header-y += omapfb.h
> 


-- 
js
suse labs

  reply	other threads:[~2016-01-12  8:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11  1:14 [PATCH] uapi: update install list after nvme.h rename Mike Frysinger
2016-01-12  8:45 ` Jiri Slaby [this message]
2016-01-14  1:17   ` Mike Frysinger
2016-01-14  8:26     ` Jiri Slaby
2016-01-14  8:30       ` Jiri Slaby
2016-02-19 22:23       ` Mario Limonciello
2016-02-19 22:37         ` Jens Axboe
2016-01-12 15:11 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5694BD46.3030004@suse.cz \
    --to=jslaby@suse.cz \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.