From: Jens Axboe <axboe@fb.com>
To: Mario Limonciello <mario_limonciello@dell.com>,
Jiri Slaby <jslaby@suse.cz>, <linux-kernel@vger.kernel.org>,
<hch@lst.de>, <keith.busch@intel.com>, <stable@vger.kernel.org>
Cc: Michal Marek <MMarek@suse.com>,
Kernel Build Daemon <kbuild@suse.de>,
"Dominguez, Jared" <Jared_Dominguez@dell.com>
Subject: Re: [PATCH] uapi: update install list after nvme.h rename
Date: Fri, 19 Feb 2016 15:37:50 -0700 [thread overview]
Message-ID: <56C7993E.2040907@fb.com> (raw)
In-Reply-To: <56C795EC.9010003@dell.com>
On 02/19/2016 03:23 PM, Mario Limonciello wrote:
>
>
> On 01/14/2016 02:26 AM, Jiri Slaby wrote:
>> On 01/14/2016, 02:17 AM, Mike Frysinger wrote:
>>> On 12 Jan 2016 09:45, Jiri Slaby wrote:
>>>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
>>>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of the
>>>>> uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h, but
>>>>> the uapi list still refers to nvme.h. People trying to install
>>>>> the headers hit a failure as the header no longer exists.
>>>>
>>>> Wouldn't reverting the rename be nicer to userspace? So that the
>>>> filename is preserved and anybody who #included nvme.h still can
>>>> do so?
>>
>>> i have no opinion on either route
>>
> Can someone with authority please decide on what to do about this?
> It's wrecking havoc in userspace right now on stuff that needs nvme.h.
The patch is in Linus' tree, and it was marked stable as well. So stable
will pick it up, when the next 4.4-stable is spun.
--
Jens Axboe
next prev parent reply other threads:[~2016-02-19 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 1:14 [PATCH] uapi: update install list after nvme.h rename Mike Frysinger
2016-01-12 8:45 ` Jiri Slaby
2016-01-14 1:17 ` Mike Frysinger
2016-01-14 8:26 ` Jiri Slaby
2016-01-14 8:30 ` Jiri Slaby
2016-02-19 22:23 ` Mario Limonciello
2016-02-19 22:37 ` Jens Axboe [this message]
2016-01-12 15:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C7993E.2040907@fb.com \
--to=axboe@fb.com \
--cc=Jared_Dominguez@dell.com \
--cc=MMarek@suse.com \
--cc=hch@lst.de \
--cc=jslaby@suse.cz \
--cc=kbuild@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.