From: Jiri Slaby <jslaby@suse.cz>
To: linux-kernel@vger.kernel.org, hch@lst.de, keith.busch@intel.com,
axboe@fb.com, stable@vger.kernel.org
Cc: Michal Marek <MMarek@suse.com>,
Kernel Build Daemon <kbuild@suse.de>,
Fengguang Wu <fengguang.wu@intel.com>,
kbuild-all@01.org
Subject: Re: [PATCH] uapi: update install list after nvme.h rename
Date: Thu, 14 Jan 2016 09:30:49 +0100 [thread overview]
Message-ID: <56975CB9.6020700@suse.cz> (raw)
In-Reply-To: <56975BA7.10905@suse.cz>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 01/14/2016, 09:26 AM, Jiri Slaby wrote:
> On 01/14/2016, 02:17 AM, Mike Frysinger wrote:
>> On 12 Jan 2016 09:45, Jiri Slaby wrote:
>>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
>>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of
>>>> the uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h,
>>>> but the uapi list still refers to nvme.h. People trying to
>>>> install the headers hit a failure as the header no longer
>>>> exists.
>>>
>>> Wouldn't reverting the rename be nicer to userspace? So that
>>> the filename is preserved and anybody who #included nvme.h
>>> still can do so?
>
>> i have no opinion on either route
>
>> on a related note, shouldn't headers install be part of the
>> automatic kernel checks that are run against repos on kernel.org
>> ? who runs that thing ?
^^^^^
You have Fengguang's 0-day build robot on your mind? (CCed)
> I have been thinking about at least 'test -f' for all 'headers-y'
> during make all. What do you think, Michal?
- --
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJWl1y5AAoJEL0lsQQGtHBJz/YP/27RtFl7wjkyhwY935/2FQeM
XmZ0/WUz2vJdMT6MNC8+cwZ5Vfua7SgNbXh8wLkzDxBufc3vBe3eugfTmrn4kAsL
GglaCDCvI5tduWVwV2CPvr1fSc9Jazj89OQld7+VhqIbKFxY4WkhWV06tHKUEPXd
2vgtSwsY4ka0CLWgdAsJZfdhBIG7tBwrlgxaWGf/kcUCRz9cavNt8FWGXUGWHnDI
J8h6eGld8TJPzvYEdHQD/MlAf/7Kle0m5MhMy+uUHdFrDWPrwqMLTDburcHyh59v
QatkLXyn7yZ2NeqPdF8FHW7Mp+A5oP+exSme7TYmKZzMNmwdx8um+gjUcd2Aq6LB
n/IhZp5rZBaPU6/CgYKvwy+jGPfkDI1WITO3YQlCkc/SzdvhjufgAFZ7MGYVA3NZ
iKsSMIi33ncN7D7TNevkPlHylp8HSx91girRtp0sP7cO2INRCl98SSiL9bq+a1Vm
tc3t64QE1YJ7/gsQ1/sfjVZIQ5sFNzTn9I4KpDWPkSWaOTl3ikULwxhop1touTdq
BGq+kVB20/cmt7sUNc4dieM97mlMD55vT3QQ1qyuUsyAdrdWE4npxo5OE43YBORL
/a8KJVscITLq7OK/QwlPi0wbSFlfGOe3LtFS8CqVWRBhQ+3Udy4eL4m7d9cB0Ats
ChQQpLBSRpN3sjuypY8d
=8T96
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-01-14 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 1:14 [PATCH] uapi: update install list after nvme.h rename Mike Frysinger
2016-01-12 8:45 ` Jiri Slaby
2016-01-14 1:17 ` Mike Frysinger
2016-01-14 8:26 ` Jiri Slaby
2016-01-14 8:30 ` Jiri Slaby [this message]
2016-02-19 22:23 ` Mario Limonciello
2016-02-19 22:37 ` Jens Axboe
2016-01-12 15:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56975CB9.6020700@suse.cz \
--to=jslaby@suse.cz \
--cc=MMarek@suse.com \
--cc=axboe@fb.com \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=kbuild-all@01.org \
--cc=kbuild@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.