From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused
Date: Mon, 25 Jan 2016 16:19:24 +0000 [thread overview]
Message-ID: <56A64B0C.2010809@arm.com> (raw)
In-Reply-To: <1453737499-1960073-1-git-send-email-arnd@arndb.de>
On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
>
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
>
> This marks the array as __maybe_unused to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/irq-s3c24xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
> return ERR_PTR(ret);
> }
>
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Arnd Bergmann <arnd@arndb.de>, Jason Cooper <jason@lakedaemon.net>
Cc: linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused
Date: Mon, 25 Jan 2016 16:19:24 +0000 [thread overview]
Message-ID: <56A64B0C.2010809@arm.com> (raw)
In-Reply-To: <1453737499-1960073-1-git-send-email-arnd@arndb.de>
On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
>
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
>
> This marks the array as __maybe_unused to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/irq-s3c24xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
> return ERR_PTR(ret);
> }
>
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-01-25 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:58 [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused Arnd Bergmann
2016-01-25 15:58 ` Arnd Bergmann
2016-01-25 16:19 ` Marc Zyngier [this message]
2016-01-25 16:19 ` Marc Zyngier
2016-01-26 15:03 ` [tip:irq/urgent] irqchip/s3c24xx: Mark " tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A64B0C.2010809@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.