* [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused
@ 2016-01-25 15:58 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-01-25 15:58 UTC (permalink / raw)
To: Jason Cooper, Marc Zyngier
Cc: linux-arm-kernel, Arnd Bergmann, Thomas Gleixner, linux-kernel
The init_eint array in the s3c24xx irqchip driver is used by
every individual chip variant, but Kconfig allows building
the driver when they are all disabled, and that leads to
a harmless compile-time warning:
drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
This marks the array as __maybe_unused to avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/irqchip/irq-s3c24xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
index c71914e8f596..5dc5a760c723 100644
--- a/drivers/irqchip/irq-s3c24xx.c
+++ b/drivers/irqchip/irq-s3c24xx.c
@@ -605,7 +605,7 @@ err:
return ERR_PTR(ret);
}
-static struct s3c_irq_data init_eint[32] = {
+static struct s3c_irq_data __maybe_unused init_eint[32] = {
{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused
2016-01-25 15:58 ` Arnd Bergmann
@ 2016-01-25 16:19 ` Marc Zyngier
-1 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2016-01-25 16:19 UTC (permalink / raw)
To: linux-arm-kernel
On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
>
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
>
> This marks the array as __maybe_unused to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/irq-s3c24xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
> return ERR_PTR(ret);
> }
>
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused
@ 2016-01-25 16:19 ` Marc Zyngier
0 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2016-01-25 16:19 UTC (permalink / raw)
To: Arnd Bergmann, Jason Cooper
Cc: linux-arm-kernel, Thomas Gleixner, linux-kernel
On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
>
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
>
> This marks the array as __maybe_unused to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/irqchip/irq-s3c24xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
> return ERR_PTR(ret);
> }
>
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
> { .type = S3C_IRQTYPE_NONE, }, /* reserved */
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:irq/urgent] irqchip/s3c24xx: Mark init_eint as __maybe_unused
2016-01-25 15:58 ` Arnd Bergmann
(?)
(?)
@ 2016-01-26 15:03 ` tip-bot for Arnd Bergmann
-1 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Arnd Bergmann @ 2016-01-26 15:03 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, arnd, jason, marc.zyngier, linux-kernel, mingo, tglx
Commit-ID: eb249a11913d316fc1a27dd07a1e1e43bda9199d
Gitweb: http://git.kernel.org/tip/eb249a11913d316fc1a27dd07a1e1e43bda9199d
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Mon, 25 Jan 2016 16:58:08 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 26 Jan 2016 16:00:14 +0100
irqchip/s3c24xx: Mark init_eint as __maybe_unused
The init_eint array in the s3c24xx irqchip driver is used by
every individual chip variant, but Kconfig allows building
the driver when they are all disabled, and that leads to
a harmless compile-time warning:
drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
This marks the array as __maybe_unused to avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1453737499-1960073-1-git-send-email-arnd@arndb.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-s3c24xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
index c71914e..5dc5a76 100644
--- a/drivers/irqchip/irq-s3c24xx.c
+++ b/drivers/irqchip/irq-s3c24xx.c
@@ -605,7 +605,7 @@ err:
return ERR_PTR(ret);
}
-static struct s3c_irq_data init_eint[32] = {
+static struct s3c_irq_data __maybe_unused init_eint[32] = {
{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
^ permalink raw reply related [flat|nested] 5+ messages in thread