From: Wim Coekaerts <wim.coekaerts@oracle.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: wim@iguana.be, Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org,
sparclinux <sparclinux@vger.kernel.org>
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Date: Thu, 28 Jan 2016 14:53:19 -0800 [thread overview]
Message-ID: <56AA9BDF.6070907@oracle.com> (raw)
In-Reply-To: <CAGRGNgWKzomgV2199r_Ym-DbGpeHz5dLwcWkC5-Lz+pftqBF9g@mail.gmail.com>
On 01/28/2016 02:50 PM, Julian Calaby wrote:
> Hi Wim,
>
> Sorry to keep iterating on this, but I noticed two small things you
> could improve:
yeah I was considering that although it makes the code a bit more
readable but
fine happy to tweak that. no problem.
the static is definitely no longer needed after all the cleanup that
happened.
WARNING: multiple messages have this Message-ID (diff)
From: Wim Coekaerts <wim.coekaerts@oracle.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: wim@iguana.be, Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org,
sparclinux <sparclinux@vger.kernel.org>
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Date: Thu, 28 Jan 2016 22:53:19 +0000 [thread overview]
Message-ID: <56AA9BDF.6070907@oracle.com> (raw)
In-Reply-To: <CAGRGNgWKzomgV2199r_Ym-DbGpeHz5dLwcWkC5-Lz+pftqBF9g@mail.gmail.com>
On 01/28/2016 02:50 PM, Julian Calaby wrote:
> Hi Wim,
>
> Sorry to keep iterating on this, but I noticed two small things you
> could improve:
yeah I was considering that although it makes the code a bit more
readable but
fine happy to tweak that. no problem.
the static is definitely no longer needed after all the cleanup that
happened.
next prev parent reply other threads:[~2016-01-28 22:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 21:46 [PATCH v6] Add sun4v_wdt watchdog driver Wim Coekaerts
2016-01-28 21:46 ` Wim Coekaerts
2016-01-28 22:50 ` Julian Calaby
2016-01-28 22:50 ` Julian Calaby
2016-01-28 22:53 ` Wim Coekaerts [this message]
2016-01-28 22:53 ` Wim Coekaerts
2016-01-29 0:24 ` Guenter Roeck
2016-01-29 0:24 ` Guenter Roeck
2016-01-29 0:35 ` Wim Coekaerts
2016-01-29 0:35 ` Wim Coekaerts
2016-01-29 11:56 ` Stanislav Kholmanskikh
2016-01-29 11:56 ` Stanislav Kholmanskikh
2016-01-29 15:12 ` Stanislav Kholmanskikh
2016-01-29 15:12 ` Stanislav Kholmanskikh
2016-01-29 15:23 ` Guenter Roeck
2016-01-29 15:23 ` Guenter Roeck
2016-01-29 17:39 ` Wim Coekaerts
2016-01-29 17:39 ` Wim Coekaerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA9BDF.6070907@oracle.com \
--to=wim.coekaerts@oracle.com \
--cc=julian.calaby@gmail.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sparclinux@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.