Re: [PATCH v6] Add sun4v_wdt watchdog driver

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Wim Coekaerts <wim.coekaerts@oracle.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Julian Calaby <julian.calaby@gmail.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
	sparclinux <sparclinux@vger.kernel.org>
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Date: Thu, 28 Jan 2016 16:35:56 -0800	[thread overview]
Message-ID: <56AAB3EC.6070802@oracle.com> (raw)
In-Reply-To: <56AAB157.3070809@roeck-us.net>


On 1/28/16 4:24 PM, Guenter Roeck wrote:
> On 01/28/2016 02:53 PM, Wim Coekaerts wrote:
>> On 01/28/2016 02:50 PM, Julian Calaby wrote:
>>> Hi Wim,
>>>
>>> Sorry to keep iterating on this, but I noticed two small things you
>>> could improve:
>>
>> yeah I was considering that although it makes the code a bit more 
>> readable but
>> fine happy to tweak that. no problem.
>>
>> the static is definitely no longer needed after all the cleanup that 
>> happened.
>>
>
> It would be great if you can drop the static. I'll leave the other one 
> for you
> to decide; I was 50/50 on it myself. I don't have any further comments 
> (assuming
> you ran the patch through checkpatch).
>
> Thanks,
> Guenter
>

awesome I will drop the static. I did run through checkpatch. all good 
there :)

I'll sleep on the value one. :)

Thanks!
Wim

WARNING: multiple messages have this Message-ID (diff)

From: Wim Coekaerts <wim.coekaerts@oracle.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Julian Calaby <julian.calaby@gmail.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
	sparclinux <sparclinux@vger.kernel.org>
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Date: Fri, 29 Jan 2016 00:35:56 +0000	[thread overview]
Message-ID: <56AAB3EC.6070802@oracle.com> (raw)
In-Reply-To: <56AAB157.3070809@roeck-us.net>


On 1/28/16 4:24 PM, Guenter Roeck wrote:
> On 01/28/2016 02:53 PM, Wim Coekaerts wrote:
>> On 01/28/2016 02:50 PM, Julian Calaby wrote:
>>> Hi Wim,
>>>
>>> Sorry to keep iterating on this, but I noticed two small things you
>>> could improve:
>>
>> yeah I was considering that although it makes the code a bit more 
>> readable but
>> fine happy to tweak that. no problem.
>>
>> the static is definitely no longer needed after all the cleanup that 
>> happened.
>>
>
> It would be great if you can drop the static. I'll leave the other one 
> for you
> to decide; I was 50/50 on it myself. I don't have any further comments 
> (assuming
> you ran the patch through checkpatch).
>
> Thanks,
> Guenter
>

awesome I will drop the static. I did run through checkpatch. all good 
there :)

I'll sleep on the value one. :)

Thanks!
Wim

next prev parent reply	other threads:[~2016-01-29  0:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 21:46 [PATCH v6] Add sun4v_wdt watchdog driver Wim Coekaerts
2016-01-28 21:46 ` Wim Coekaerts
2016-01-28 22:50 ` Julian Calaby
2016-01-28 22:50   ` Julian Calaby
2016-01-28 22:53   ` Wim Coekaerts
2016-01-28 22:53     ` Wim Coekaerts
2016-01-29  0:24     ` Guenter Roeck
2016-01-29  0:24       ` Guenter Roeck
2016-01-29  0:35       ` Wim Coekaerts [this message]
2016-01-29  0:35         ` Wim Coekaerts
2016-01-29 11:56 ` Stanislav Kholmanskikh
2016-01-29 11:56   ` Stanislav Kholmanskikh
2016-01-29 15:12 ` Stanislav Kholmanskikh
2016-01-29 15:12   ` Stanislav Kholmanskikh
2016-01-29 15:23   ` Guenter Roeck
2016-01-29 15:23     ` Guenter Roeck
2016-01-29 17:39     ` Wim Coekaerts
2016-01-29 17:39       ` Wim Coekaerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AAB3EC.6070802@oracle.com \
    --to=wim.coekaerts@oracle.com \
    --cc=julian.calaby@gmail.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sparclinux@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.